html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,issue,performed_via_github_app https://github.com/simonw/datasette/issues/751#issuecomment-623207541,https://api.github.com/repos/simonw/datasette/issues/751,623207541,MDEyOklzc3VlQ29tbWVudDYyMzIwNzU0MQ==,9599,2020-05-04T00:13:09Z,2020-05-04T00:13:09Z,OWNER,Relevant code: https://github.com/simonw/datasette/blob/07e208cc6d9e901b87552c1be2854c220b3f9b6d/datasette/views/table.py#L519-L520,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",611540797, https://github.com/simonw/datasette/issues/751#issuecomment-623207636,https://api.github.com/repos/simonw/datasette/issues/751,623207636,MDEyOklzc3VlQ29tbWVudDYyMzIwNzYzNg==,9599,2020-05-04T00:13:46Z,2020-05-04T00:13:46Z,OWNER,"Syntax suggestion: ```json { ""databases"": { ""mydatabase"": { ""tables"": { ""example_table"": { ""sort"": ""created"", ""size"": 10 } } } } } ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",611540797, https://github.com/simonw/datasette/issues/751#issuecomment-623207741,https://api.github.com/repos/simonw/datasette/issues/751,623207741,MDEyOklzc3VlQ29tbWVudDYyMzIwNzc0MQ==,9599,2020-05-04T00:14:35Z,2020-05-04T00:14:35Z,OWNER,"I'm calling it `""size""` for consistency with the querystring parameter `_size=`, even though `""page_size""` might be a more accurate name.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",611540797, https://github.com/simonw/datasette/issues/754#issuecomment-623560217,https://api.github.com/repos/simonw/datasette/issues/754,623560217,MDEyOklzc3VlQ29tbWVudDYyMzU2MDIxNw==,9599,2020-05-04T16:15:28Z,2020-05-04T16:15:28Z,OWNER,"I think those will be fixed by an upgrade to aiofiles 0.5.0: https://github.com/Tinche/aiofiles/compare/v0.4.0...v0.5.0","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",611997130, https://github.com/simonw/datasette/pull/725#issuecomment-623560732,https://api.github.com/repos/simonw/datasette/issues/725,623560732,MDEyOklzc3VlQ29tbWVudDYyMzU2MDczMg==,9599,2020-05-04T16:16:21Z,2020-05-04T16:16:21Z,OWNER,This may fix #754 warnings.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",598891570, https://github.com/simonw/datasette/issues/754#issuecomment-623561480,https://api.github.com/repos/simonw/datasette/issues/754,623561480,MDEyOklzc3VlQ29tbWVudDYyMzU2MTQ4MA==,9599,2020-05-04T16:17:42Z,2020-05-04T16:17:42Z,OWNER,Sure enough this run https://travis-ci.org/github/simonw/datasette/jobs/674415040 from that PR no longer shows the warnings.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",611997130, https://github.com/simonw/datasette/pull/719#issuecomment-623591293,https://api.github.com/repos/simonw/datasette/issues/719,623591293,MDEyOklzc3VlQ29tbWVudDYyMzU5MTI5Mw==,9599,2020-05-04T17:14:23Z,2020-05-04T17:14:23Z,OWNER,"Thanks, this is a smart fix.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",594553553, https://github.com/simonw/datasette/issues/752#issuecomment-623598224,https://api.github.com/repos/simonw/datasette/issues/752,623598224,MDEyOklzc3VlQ29tbWVudDYyMzU5ODIyNA==,9599,2020-05-04T17:28:11Z,2020-05-04T17:28:20Z,OWNER,"Good catch: it looks like we're not specifying the charset for those pages: ``` $ curl -i 'https://latest.datasette.io/404' HTTP/1.1 404 Not Found access-control-allow-origin: * content-type: text/html Date: Mon, 04 May 2020 16:23:25 GMT Server: Google Frontend Content-Length: 605