html_url,issue_url,id,node_id,user,user_label,created_at,updated_at,author_association,body,reactions,issue,issue_label,performed_via_github_app
https://github.com/simonw/datasette/issues/498#issuecomment-508590397,https://api.github.com/repos/simonw/datasette/issues/498,508590397,MDEyOklzc3VlQ29tbWVudDUwODU5MDM5Nw==,7936571,chrismp,2019-07-04T23:34:41Z,2019-07-04T23:34:41Z,NONE,I'll take your suggestion and do this all in Javascript. Would I need to make a `static/` folder in my datasette project's root directory and make a custom `index.html` template that pulls from `static/js/search-all-fts.js`? Or would you suggest another way?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",451513541,Full text search of all tables at once?,
https://github.com/simonw/datasette/issues/538#issuecomment-508346394,https://api.github.com/repos/simonw/datasette/issues/538,508346394,MDEyOklzc3VlQ29tbWVudDUwODM0NjM5NA==,9599,simonw,2019-07-04T05:43:24Z,2019-07-04T05:43:24Z,OWNER,"Re-opening this because I messed it up: the secret options are still visible in `/-/metadata` because I mutate the dictionary in place!

https://github.com/simonw/datasette/blob/a2d45931935f6bb73605a94afedf9e78308c95d6/datasette/app.py#L273-L279","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",463915863,Mechanism for secrets in plugin configuration,
https://github.com/simonw/datasette/pull/539#issuecomment-508343359,https://api.github.com/repos/simonw/datasette/issues/539,508343359,MDEyOklzc3VlQ29tbWVudDUwODM0MzM1OQ==,9599,simonw,2019-07-04T05:27:47Z,2019-07-04T05:27:47Z,OWNER,"For some reason the way I have set these tests up keeps throwing [variations on this error](https://travis-ci.org/simonw/datasette/builds/554055865):
```
self = <click.testing.CliRunner object at 0x7fccc0d940f0>
    @contextlib.contextmanager
    def isolated_filesystem(self):
        """"""A context manager that creates a temporary folder and changes
        the current working directory to it for isolated filesystem tests.
        """"""
>       cwd = os.getcwd()
E       FileNotFoundError: [Errno 2] No such file or directory
/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages/click/testing.py:364: FileNotFoundError
```
After much trial and error the cause appears to be the way I was trying to create custom metadata like so:
```python
 def test_plugin_config_env():
    os.environ[""FOO_ENV""] = ""FROM_ENVIRONMENT""
    for client in make_app_client(
        metadata={""plugins"": {""env-plugin"": {""foo"": {""$env"": ""FOO_ENV""}}}}
    ):
        assert {""foo"": ""FROM_ENVIRONMENT""} == client.ds.plugin_config(""env-plugin"")
    del os.environ[""FOO_ENV""]
```
It wasnt't the `os.environ` manipulation OR the `tempfile` stuff - it appeared to be the usage of `make_app_client()`. When I stopped trying to do that (and moved my test configuration into `METADATA` in the `fixtures.py` module) the tests started passing again.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",464040911,Secret plugin configuration options,
https://github.com/simonw/datasette/pull/539#issuecomment-508343497,https://api.github.com/repos/simonw/datasette/issues/539,508343497,MDEyOklzc3VlQ29tbWVudDUwODM0MzQ5Nw==,9599,simonw,2019-07-04T05:28:30Z,2019-07-04T05:28:30Z,OWNER,This seems to have fixed the weird errors: https://github.com/simonw/datasette/pull/539/commits/fd6164b03ebe450a9a00df2e5be2dc7bbfbd9a3f,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",464040911,Secret plugin configuration options,