html_url,issue_url,id,node_id,user,user_label,created_at,updated_at,author_association,body,reactions,issue,issue_label,performed_via_github_app https://github.com/simonw/datasette/issues/981#issuecomment-701153543,https://api.github.com/repos/simonw/datasette/issues/981,701153543,MDEyOklzc3VlQ29tbWVudDcwMTE1MzU0Mw==,9599,simonw,2020-09-30T04:46:05Z,2020-09-30T05:11:45Z,OWNER,"Prototype: ```html
``` ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",711627628,Action menu for table columns, https://github.com/simonw/datasette/issues/981#issuecomment-701153600,https://api.github.com/repos/simonw/datasette/issues/981,701153600,MDEyOklzc3VlQ29tbWVudDcwMTE1MzYwMA==,9599,simonw,2020-09-30T04:46:18Z,2020-09-30T04:46:18Z,OWNER,"More options: ```html ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",711627628,Action menu for table columns, https://github.com/simonw/datasette/issues/981#issuecomment-701153822,https://api.github.com/repos/simonw/datasette/issues/981,701153822,MDEyOklzc3VlQ29tbWVudDcwMTE1MzgyMg==,9599,simonw,2020-09-30T04:47:10Z,2020-09-30T04:47:10Z,OWNER,"Future version could have expanding out nested side menus that let you do things like ""calculate sum/avg for this column against this-other-column"".","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",711627628,Action menu for table columns, https://github.com/simonw/datasette/issues/981#issuecomment-701153982,https://api.github.com/repos/simonw/datasette/issues/981,701153982,MDEyOklzc3VlQ29tbWVudDcwMTE1Mzk4Mg==,9599,simonw,2020-09-30T04:47:54Z,2020-09-30T04:47:54Z,OWNER,"I think the accessible way to do this is with absolute positioning - have a menu icon in the `` which, when clicked, causes the dropdown menu to appear as an absolutely positioned `
` that is not located within the DOM hierarchy of the`` itself but is positioned to show up in the correct place.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",711627628,Action menu for table columns, https://github.com/simonw/datasette/issues/981#issuecomment-701157010,https://api.github.com/repos/simonw/datasette/issues/981,701157010,MDEyOklzc3VlQ29tbWVudDcwMTE1NzAxMA==,9599,simonw,2020-09-30T05:00:42Z,2020-09-30T20:06:59Z,OWNER,"Maybe use this as the icon: ```svg ``` ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",711627628,Action menu for table columns, https://github.com/simonw/datasette/issues/982#issuecomment-701585075,https://api.github.com/repos/simonw/datasette/issues/982,701585075,MDEyOklzc3VlQ29tbWVudDcwMTU4NTA3NQ==,9599,simonw,2020-09-30T19:05:11Z,2020-09-30T19:05:11Z,OWNER,The form needs to switch from GET to POST if the query is a write query. JavaScript can handle this based on the checkbox - if a user does not have JavaScript submitting the form will cause the form action to be changed to POST and the form to be redisplayed.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",712202333,"SQL editor should allow execution of write queries, if you have permission", https://github.com/simonw/datasette/issues/982#issuecomment-701585695,https://api.github.com/repos/simonw/datasette/issues/982,701585695,MDEyOklzc3VlQ29tbWVudDcwMTU4NTY5NQ==,9599,simonw,2020-09-30T19:06:29Z,2020-09-30T19:06:29Z,OWNER,This is a little related to the error display issue #619 in that both will require some reworking of how the code is structured.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",712202333,"SQL editor should allow execution of write queries, if you have permission", https://github.com/simonw/datasette/issues/981#issuecomment-701615291,https://api.github.com/repos/simonw/datasette/issues/981,701615291,MDEyOklzc3VlQ29tbWVudDcwMTYxNTI5MQ==,9599,simonw,2020-09-30T20:04:34Z,2020-09-30T20:05:37Z,OWNER,"Another potential action: * Show rows where this is not blank (equivalent to `is not blank` filter) This could be displayed conditionally based on if the column is detected to have any blank rows in it? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",711627628,Action menu for table columns, https://github.com/simonw/datasette/issues/981#issuecomment-701616922,https://api.github.com/repos/simonw/datasette/issues/981,701616922,MDEyOklzc3VlQ29tbWVudDcwMTYxNjkyMg==,9599,simonw,2020-09-30T20:08:02Z,2020-09-30T20:08:02Z,OWNER,It would be neat to provide a JavaScript plugin hook that plugins can use to add their own options to this menu. No idea what that would look like though.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",711627628,Action menu for table columns, https://github.com/simonw/sqlite-utils/issues/182#issuecomment-701626134,https://api.github.com/repos/simonw/sqlite-utils/issues/182,701626134,MDEyOklzc3VlQ29tbWVudDcwMTYyNjEzNA==,9599,simonw,2020-09-30T20:27:09Z,2020-09-30T20:27:42Z,OWNER,"It looks like http://maps.natalian.org/data.txt is encoded as `latin-1`, but `sqlite-utils` assumes `utf-8` and hence breaks. It would be worth improving the error message here. I could also add a `--encoding latin-1` option to `sqlite-utils insert` to help in consuming files that are stored in charsets other than `utf-8`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",711649325,"Better handling of encodings other than utf-8 for ""sqlite-utils insert""", https://github.com/simonw/sqlite-utils/pull/178#issuecomment-701627158,https://api.github.com/repos/simonw/sqlite-utils/issues/178,701627158,MDEyOklzc3VlQ29tbWVudDcwMTYyNzE1OA==,9599,simonw,2020-09-30T20:29:11Z,2020-09-30T20:29:11Z,OWNER,Thanks for the fix!,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",709043182,Update README.md, https://github.com/simonw/datasette/issues/983#issuecomment-701629984,https://api.github.com/repos/simonw/datasette/issues/983,701629984,MDEyOklzc3VlQ29tbWVudDcwMTYyOTk4NA==,9599,simonw,2020-09-30T20:34:43Z,2020-09-30T20:34:43Z,OWNER,"I had a look around and there isn't an obvious pluggy equivalent in JavaScript world at the moment. Lots of frameworks like jQuery and Vue have their own custom plugin mechanisms. https://github.com/rekit/js-plugin is a simple standalone plugin mechanism. Not quite as full-featured as Pluggy though - in particular I like how Pluggy supports multiple plugins returning results for the same hook that get concatenated into a list of results. https://css-tricks.com/designing-a-javascript-plugin-system/ has some ideas.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",712260429,JavaScript plugin hooks mechanism similar to pluggy, https://github.com/simonw/datasette/issues/981#issuecomment-701642448,https://api.github.com/repos/simonw/datasette/issues/981,701642448,MDEyOklzc3VlQ29tbWVudDcwMTY0MjQ0OA==,9599,simonw,2020-09-30T20:59:33Z,2020-09-30T20:59:33Z,OWNER,I think I've got everything I need to implement this now.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",711627628,Action menu for table columns, https://github.com/simonw/datasette/issues/981#issuecomment-701659197,https://api.github.com/repos/simonw/datasette/issues/981,701659197,MDEyOklzc3VlQ29tbWVudDcwMTY1OTE5Nw==,9599,simonw,2020-09-30T21:34:44Z,2020-09-30T21:34:44Z,OWNER,"Showing ""facet by this"" on the primary key column doesn't make sense.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",711627628,Action menu for table columns, https://github.com/simonw/datasette/issues/981#issuecomment-701664306,https://api.github.com/repos/simonw/datasette/issues/981,701664306,MDEyOklzc3VlQ29tbWVudDcwMTY2NDMwNg==,9599,simonw,2020-09-30T21:47:08Z,2020-09-30T21:47:08Z,OWNER,"The arrow icon didn't make sense because I already have a triangle icon showing sort order. I'm trying a cog icon instead: ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",711627628,Action menu for table columns, https://github.com/simonw/datasette/issues/981#issuecomment-701668526,https://api.github.com/repos/simonw/datasette/issues/981,701668526,MDEyOklzc3VlQ29tbWVudDcwMTY2ODUyNg==,9599,simonw,2020-09-30T21:57:22Z,2020-09-30T21:57:22Z,OWNER,"A bunch of things to fix: - It clobbers existing querystring parameters - it needs to leave these alone (but replace the current sort order) - Facet option should not show up if you are already faceting by that column - There's no way to close the menu once it has opened! - Accessibility: SVG icon doesn't even have an alt attribute yet. Should use ARIA when the thing appears. It's also not visible on mobile, need to think about how that will work.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",711627628,Action menu for table columns, https://github.com/simonw/sqlite-utils/issues/183#issuecomment-701678659,https://api.github.com/repos/simonw/sqlite-utils/issues/183,701678659,MDEyOklzc3VlQ29tbWVudDcwMTY3ODY1OQ==,9599,simonw,2020-09-30T22:23:36Z,2020-09-30T22:23:36Z,OWNER,"It just ran and didn't find anything. I'll leave it enabled for a while but I may turn it off again, it could be that this kind of Python library isn't really what it's useful for.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",712316959,Try out GitHub code scanning, https://github.com/simonw/datasette/issues/981#issuecomment-701679729,https://api.github.com/repos/simonw/datasette/issues/981,701679729,MDEyOklzc3VlQ29tbWVudDcwMTY3OTcyOQ==,9599,simonw,2020-09-30T22:26:33Z,2020-09-30T22:26:33Z,OWNER,"Bug: https://latest.datasette.io/fixtures/sortable?_sort=sortable ![sort-bug](https://user-images.githubusercontent.com/9599/94746304-4e7c9380-0331-11eb-8e81-7245529c4654.gif) ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",711627628,Action menu for table columns, https://github.com/simonw/datasette/issues/981#issuecomment-701697918,https://api.github.com/repos/simonw/datasette/issues/981,701697918,MDEyOklzc3VlQ29tbWVudDcwMTY5NzkxOA==,9599,simonw,2020-09-30T23:24:14Z,2020-09-30T23:25:28Z,OWNER,"I could provide the ""Show non-blank values"" option only for columns where there are blank values visible on the current page. This could be a bit confusing though, since the absence of that option could suggest that there are no blank values at all when that's actually not true. One option: run a separate `fetch()` call that figures out if any of the columns contain blank values, which gets a bit of extra time to execute. Only show the ""Show non-blank values"" option in the menu once that has returned.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",711627628,Action menu for table columns, https://github.com/simonw/datasette/issues/981#issuecomment-701703472,https://api.github.com/repos/simonw/datasette/issues/981,701703472,MDEyOklzc3VlQ29tbWVudDcwMTcwMzQ3Mg==,9599,simonw,2020-09-30T23:43:30Z,2020-09-30T23:43:30Z,OWNER,"I'm going to go based just on the visible values on the current page. I think that's good enough, and it avoids the complexity involved in doing a server-side check for blank values.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",711627628,Action menu for table columns, https://github.com/simonw/datasette/issues/981#issuecomment-701704716,https://api.github.com/repos/simonw/datasette/issues/981,701704716,MDEyOklzc3VlQ29tbWVudDcwMTcwNDcxNg==,9599,simonw,2020-09-30T23:48:36Z,2020-09-30T23:48:36Z,OWNER,"Since this menu doesn't provide new functionality, I'm going to ignore the fact that it doesn't exist on portrait mobile view for the moment. Likewise, I'm going to skip making it accessible for the moment since lacking accessibility doesn't prevent functionality from being accessed - the menu-less experience currently works the same as the portrait mobile experience.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",711627628,Action menu for table columns, https://github.com/simonw/datasette/issues/981#issuecomment-701707116,https://api.github.com/repos/simonw/datasette/issues/981,701707116,MDEyOklzc3VlQ29tbWVudDcwMTcwNzExNg==,9599,simonw,2020-09-30T23:58:17Z,2020-09-30T23:58:17Z,OWNER,"Now live at https://latest.datasette.io/fixtures/facetable ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",711627628,Action menu for table columns,