html_url,issue_url,id,node_id,user,user_label,created_at,updated_at,author_association,body,reactions,issue,issue_label,performed_via_github_app https://github.com/simonw/datasette/issues/1246#issuecomment-787611153,https://api.github.com/repos/simonw/datasette/issues/1246,787611153,MDEyOklzc3VlQ29tbWVudDc4NzYxMTE1Mw==,9599,simonw,2021-03-01T03:30:57Z,2021-03-01T03:30:57Z,OWNER,"I'm going to try a new pattern for testing this, enabled by #1151 - the test will create a new named in-memory database, write some records to it and then run some test facets against that. This will save me from having to add yet another fixtures table for this.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",817597268,Suggest for ArrayFacet possibly confused by blank values, https://github.com/simonw/datasette/issues/1247#issuecomment-787616158,https://api.github.com/repos/simonw/datasette/issues/1247,787616158,MDEyOklzc3VlQ29tbWVudDc4NzYxNjE1OA==,9599,simonw,2021-03-01T03:49:27Z,2021-03-01T03:49:27Z,OWNER,"A couple of options: ```python datasette.add_memory_database(""test_json_array"") # or make that first argument to add_database() optional and support: datasette.add_database(memory_name=""test_json_array"") ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",818430405,datasette.add_memory_database() method, https://github.com/simonw/datasette/issues/1247#issuecomment-787616446,https://api.github.com/repos/simonw/datasette/issues/1247,787616446,MDEyOklzc3VlQ29tbWVudDc4NzYxNjQ0Ng==,9599,simonw,2021-03-01T03:50:37Z,2021-03-01T03:50:37Z,OWNER,"I like the `.add_memory_database()` option. I also like that it makes it more obvious that this is a capability of Datasette, since I'm excited to see more plugins, features and tests that take advantage of it.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",818430405,datasette.add_memory_database() method,