html_url,issue_url,id,node_id,user,user_label,created_at,updated_at,author_association,body,reactions,issue,issue_label,performed_via_github_app https://github.com/simonw/sqlite-utils/issues/159#issuecomment-693199049,https://api.github.com/repos/simonw/sqlite-utils/issues/159,693199049,MDEyOklzc3VlQ29tbWVudDY5MzE5OTA0OQ==,9599,simonw,2020-09-16T06:20:26Z,2020-09-16T06:20:26Z,OWNER,"See #121 - I need to think harder about how this all interacts with transactions. You can do this: ```python with db.conn: db[""mytable""].delete_where() ``` But that should be documented and maybe rethought.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",702386948,.delete_where() does not auto-commit (unlike .insert() or .upsert()), https://github.com/simonw/sqlite-utils/pull/158#issuecomment-693199392,https://api.github.com/repos/simonw/sqlite-utils/issues/158,693199392,MDEyOklzc3VlQ29tbWVudDY5MzE5OTM5Mg==,9599,simonw,2020-09-16T06:21:29Z,2020-09-16T06:21:29Z,OWNER,Thanks!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",697203800,Fix accidental mega long line in docs, https://github.com/simonw/sqlite-utils/issues/159#issuecomment-693486183,https://api.github.com/repos/simonw/sqlite-utils/issues/159,693486183,MDEyOklzc3VlQ29tbWVudDY5MzQ4NjE4Mw==,11712349,spdkils,2020-09-16T15:34:13Z,2020-09-16T15:34:13Z,NONE,"I appreciate the response, it's just unexpected. If I insert, it commits, if I update it commits, if I upsert it commits... if I delete.. it doesn't??? Confused me... I did just db commit it... But it's confusing.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",702386948,.delete_where() does not auto-commit (unlike .insert() or .upsert()), https://github.com/simonw/sqlite-utils/issues/159#issuecomment-693589321,https://api.github.com/repos/simonw/sqlite-utils/issues/159,693589321,MDEyOklzc3VlQ29tbWVudDY5MzU4OTMyMQ==,9599,simonw,2020-09-16T18:41:42Z,2020-09-16T18:41:42Z,OWNER,Yeah I'm going to class this as a bug - that's definitely confusing.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",702386948,.delete_where() does not auto-commit (unlike .insert() or .upsert()), https://github.com/simonw/sqlite-utils/issues/159#issuecomment-693694343,https://api.github.com/repos/simonw/sqlite-utils/issues/159,693694343,MDEyOklzc3VlQ29tbWVudDY5MzY5NDM0Mw==,9599,simonw,2020-09-16T22:15:39Z,2020-09-16T22:15:39Z,OWNER,"Independent of the transaction changes in #121 I may be able to check `self.conn.in_transaction` to see if a transaction is active and, if one is NOT active, execute the delete inside of one. https://docs.python.org/3/library/sqlite3.html#sqlite3.Connection.in_transaction","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",702386948,.delete_where() does not auto-commit (unlike .insert() or .upsert()), https://github.com/simonw/sqlite-utils/issues/159#issuecomment-693694968,https://api.github.com/repos/simonw/sqlite-utils/issues/159,693694968,MDEyOklzc3VlQ29tbWVudDY5MzY5NDk2OA==,9599,simonw,2020-09-16T22:17:19Z,2020-09-16T22:17:19Z,OWNER,"That's strange... this test here doesn't manually commit a transaction and passes: https://github.com/simonw/sqlite-utils/blob/7805d53bcf11199bd1f2b07e05ae90151f9d0eb0/tests/test_delete.py#L17-L23","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",702386948,.delete_where() does not auto-commit (unlike .insert() or .upsert()), https://github.com/simonw/sqlite-utils/issues/159#issuecomment-693695177,https://api.github.com/repos/simonw/sqlite-utils/issues/159,693695177,MDEyOklzc3VlQ29tbWVudDY5MzY5NTE3Nw==,9599,simonw,2020-09-16T22:17:53Z,2020-09-16T22:17:53Z,OWNER,@spdkils can you share a minimal code example that exhibits the behavior you're seeing?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",702386948,.delete_where() does not auto-commit (unlike .insert() or .upsert()),