html_url,issue_url,id,node_id,user,user_label,created_at,updated_at,author_association,body,reactions,issue,issue_label,performed_via_github_app
https://github.com/simonw/datasette/issues/984#issuecomment-701708072,https://api.github.com/repos/simonw/datasette/issues/984,701708072,MDEyOklzc3VlQ29tbWVudDcwMTcwODA3Mg==,9599,simonw,2020-10-01T00:01:36Z,2020-10-01T00:01:36Z,OWNER,Column action menus are the cog icons on https://latest.datasette.io/fixtures/facetable,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",712368432,Review accessibility of new column action menus,
https://github.com/simonw/datasette/issues/530#issuecomment-701720034,https://api.github.com/repos/simonw/datasette/issues/530,701720034,MDEyOklzc3VlQ29tbWVudDcwMTcyMDAzNA==,9599,simonw,2020-10-01T00:42:08Z,2020-10-01T00:42:08Z,OWNER,"I've changed my mind - especially since Datasette now ships with default JavaScript for the column menus in #981. I'm not going to extract CodeMirror into a plugin, I'll leave it where it is.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",460540321,Extract codemirror SQL editor out into a plugin,
https://github.com/simonw/datasette/pull/986#issuecomment-702171636,https://api.github.com/repos/simonw/datasette/issues/986,702171636,MDEyOklzc3VlQ29tbWVudDcwMjE3MTYzNg==,22429695,codecov[bot],2020-10-01T14:24:11Z,2020-10-01T14:24:11Z,NONE,"# [Codecov](https://codecov.io/gh/simonw/datasette/pull/986?src=pr&el=h1) Report
> Merging [#986](https://codecov.io/gh/simonw/datasette/pull/986?src=pr&el=desc) into [main](https://codecov.io/gh/simonw/datasette/commit/141544613f9e76ddb74eee38d6f8ee1e0e70f833?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/simonw/datasette/pull/986?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## main #986 +/- ##
=======================================
Coverage 84.28% 84.28%
=======================================
Files 28 28
Lines 3850 3850
=======================================
Hits 3245 3245
Misses 605 605
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/986?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/986?src=pr&el=footer). Last update [1415446...76f7094](https://codecov.io/gh/simonw/datasette/pull/986?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",712889459,"Allow facet by primary keys, fixes #985",
https://github.com/simonw/datasette/issues/985#issuecomment-702132019,https://api.github.com/repos/simonw/datasette/issues/985,702132019,MDEyOklzc3VlQ29tbWVudDcwMjEzMjAxOQ==,9599,simonw,2020-10-01T13:23:48Z,2020-10-01T13:23:48Z,OWNER,"The code that skips the ""facet by this"" menu option for primary key columns could take into account if there are multiple primary keys.
https://github.com/simonw/datasette/blob/141544613f9e76ddb74eee38d6f8ee1e0e70f833/datasette/static/table.js#L91-L98","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",712839383,Column actions should support facet by compound primary keys,
https://github.com/simonw/datasette/issues/987#issuecomment-702240916,https://api.github.com/repos/simonw/datasette/issues/987,702240916,MDEyOklzc3VlQ29tbWVudDcwMjI0MDkxNg==,9599,simonw,2020-10-01T16:10:44Z,2020-10-01T16:10:44Z,OWNER,https://github.com/simonw/datasette/blob/141544613f9e76ddb74eee38d6f8ee1e0e70f833/datasette/templates/_table.html#L6,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",712984738,Documented HTML hooks for JavaScript plugin authors,
https://github.com/simonw/datasette/issues/987#issuecomment-702241397,https://api.github.com/repos/simonw/datasette/issues/987,702241397,MDEyOklzc3VlQ29tbWVudDcwMjI0MTM5Nw==,9599,simonw,2020-10-01T16:11:31Z,2020-10-01T16:11:31Z,OWNER,"This should be a new page in the documentation, which will be expanded later on to cover things like the proposed JavaScript plugin hooks system from #983.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",712984738,Documented HTML hooks for JavaScript plugin authors,
https://github.com/simonw/datasette/pull/986#issuecomment-702265255,https://api.github.com/repos/simonw/datasette/issues/986,702265255,MDEyOklzc3VlQ29tbWVudDcwMjI2NTI1NQ==,9599,simonw,2020-10-01T16:51:45Z,2020-10-01T16:51:45Z,OWNER,Thanks for taking a look! The fix ended up being a little different from this because I still want to disable faceting on regular single primary keys (since faceting by those won't ever produce interesting results) - here's what I used: https://github.com/simonw/datasette/commit/5d6bc4c268f9f155e59561671f8617addd3e91bc,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",712889459,"Allow facet by primary keys, fixes #985",
https://github.com/simonw/datasette/issues/865#issuecomment-702418045,https://api.github.com/repos/simonw/datasette/issues/865,702418045,MDEyOklzc3VlQ29tbWVudDcwMjQxODA0NQ==,9599,simonw,2020-10-01T21:54:00Z,2020-10-01T21:54:00Z,OWNER,"Had a thought: this is likely to break in plugins too, such as `datasette-edit-schema` which constructs URLs for redirects e.g. here: https://github.com/simonw/datasette-edit-schema/blob/dbd0abee6dd3385b114cfe9671f7ead1c4855b60/datasette_edit_schema/__init__.py#L46-L48","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",644582921,"base_url doesn't seem to work when adding criteria and clicking ""apply""",