{"html_url": "https://github.com/simonw/datasette/issues/93#issuecomment-754215392", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/93", "id": 754215392, "node_id": "MDEyOklzc3VlQ29tbWVudDc1NDIxNTM5Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-04T20:59:20Z", "updated_at": "2021-01-04T21:03:14Z", "author_association": "OWNER", "body": "Updated `pyinstaller` recipe - lots of hidden imports needed now:\r\n```\r\npip install wheel\r\npip install datasette pyinstaller\r\n\r\nBASE=$(python -c 'import os; print(os.path.dirname(__import__(\"datasette\").__file__))') \\\r\n    pyinstaller -F \\\r\n        --add-data \"$BASE/templates:datasette/templates\" \\\r\n        --add-data \"$BASE/static:datasette/static\" \\\r\n        --hidden-import datasette.publish \\\r\n        --hidden-import datasette.publish.heroku \\\r\n        --hidden-import datasette.publish.cloudrun \\\r\n        --hidden-import datasette.facets \\\r\n        --hidden-import datasette.sql_functions \\\r\n        --hidden-import datasette.actor_auth_cookie \\\r\n        --hidden-import datasette.default_permissions \\\r\n        --hidden-import datasette.default_magic_parameters \\\r\n        --hidden-import datasette.blob_renderer \\\r\n        --hidden-import datasette.default_menu_links \\\r\n        --hidden-import uvicorn \\\r\n        --hidden-import uvicorn.logging \\\r\n        --hidden-import uvicorn.loops \\\r\n        --hidden-import uvicorn.loops.auto \\\r\n        --hidden-import uvicorn.protocols \\\r\n        --hidden-import uvicorn.protocols.http \\\r\n        --hidden-import uvicorn.protocols.http.auto \\\r\n        --hidden-import uvicorn.protocols.websockets \\\r\n        --hidden-import uvicorn.protocols.websockets.auto \\\r\n        --hidden-import uvicorn.lifespan \\\r\n        --hidden-import uvicorn.lifespan.on \\\r\n        $(which datasette)\r\n```", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 273944952, "label": "Package as standalone binary"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/913#issuecomment-754187326", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/913", "id": 754187326, "node_id": "MDEyOklzc3VlQ29tbWVudDc1NDE4NzMyNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-04T20:03:50Z", "updated_at": "2021-01-04T20:03:50Z", "author_association": "OWNER", "body": "I renamed `--config` to `--setting` and changed it to work like this:\r\n\r\n    datasette --setting sql_time_limit_ms 1000\r\n\r\nNote the lack of colons.\r\n\r\nThis actually makes colons cleaner to use for plugins - I could support this:\r\n\r\n    datasette --setting datasette-insert:unsafe 1", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 670209331, "label": "Mechanism for passing additional options to `datasette my.db` that affect plugins"}, "performed_via_github_app": null}