{"html_url": "https://github.com/simonw/datasette/issues/266#issuecomment-397912840", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/266", "id": 397912840, "node_id": "MDEyOklzc3VlQ29tbWVudDM5NzkxMjg0MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-06-17T23:13:35Z", "updated_at": "2018-06-17T23:16:42Z", "author_association": "OWNER", "body": "This worked! https://github.com/simonw/datasette/commit/5a0a82faf9cf9dd109d76181ed00eea19472087c - it spat out a 76MB CSV when I ran it against the sf-trees demo database.\r\n\r\nIt was just a quick hack though - it currently ignores `_labels=` and `_dl=` which need to be supported.\r\n\r\nI'm going to add a config option for turning full CSV export off just in case any Datasette users are uncomfortable with URLs that churn out that much data in one go.\r\n\r\n```\r\n    ConfigOption(\"allow_csv_stream\", True, \"\"\"\r\n        Allow .csv?_stream=1 to download all rows (ignoring max_returned_rows)\r\n    \"\"\".strip()),\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 323681589, "label": "Export to CSV"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/313#issuecomment-397900434", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/313", "id": 397900434, "node_id": "MDEyOklzc3VlQ29tbWVudDM5NzkwMDQzNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-06-17T19:23:23Z", "updated_at": "2018-06-17T19:23:23Z", "author_association": "OWNER", "body": "This will require some relatively sophisticated Travis build steps. Useful docs: https://docs.travis-ci.com/user/build-stages/ - useful example: https://docs.travis-ci.com/user/build-stages/deploy-heroku/", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 333086005, "label": "Deploy demo of Datasette on every commit that passes tests"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/313#issuecomment-397907987", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/313", "id": 397907987, "node_id": "MDEyOklzc3VlQ29tbWVudDM5NzkwNzk4Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-06-17T21:32:52Z", "updated_at": "2018-06-17T21:32:52Z", "author_association": "OWNER", "body": "This very nearly works...\r\n\r\n* https://latest.datasette.io/\r\n* https://f0c1722.datasette.io/\r\n\r\nBut... https://f0c1722.datasette.io/-/versions isn't showing the correct note:\r\n```\r\n{\r\n    \"datasette\": {\r\n        \"version\": \"0.22.1\"\r\n    }\r\n    ...\r\n```\r\nThere should be a `\"note\"` field there with the full commit hash.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 333086005, "label": "Deploy demo of Datasette on every commit that passes tests"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/313#issuecomment-397908093", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/313", "id": 397908093, "node_id": "MDEyOklzc3VlQ29tbWVudDM5NzkwODA5Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-06-17T21:34:52Z", "updated_at": "2018-06-17T21:34:52Z", "author_association": "OWNER", "body": "It looks like all of my test deploys ended up going to the same Zeit deployment ID: https://zeit.co/simonw/datasette-latest/rbmtcedvlj\r\n\r\nThis is strange... the Dockerfile should be different for each one (due to the differing version-note).\r\n\r\nhttps://github.com/simonw/datasette/commit/db1e6bc182d11f333e6addaa1a6be87625a4e12b#diff-34418c57343344c73271e13b01b7fcd9R255", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 333086005, "label": "Deploy demo of Datasette on every commit that passes tests"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/313#issuecomment-397908185", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/313", "id": 397908185, "node_id": "MDEyOklzc3VlQ29tbWVudDM5NzkwODE4NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-06-17T21:36:50Z", "updated_at": "2018-06-17T21:36:50Z", "author_association": "OWNER", "body": "```\r\nThe command \"datasette publish now fixtures.db -m fixtures.json --token=$NOW_TOKEN --branch=$TRAVIS_COMMIT --version-note=$TRAVIS_COMMIT\" exited with 0.\r\n```\r\n\r\nPartial log of the ``datasette publish now`` output:\r\n\r\n```\r\n> Step 5/7 : RUN datasette inspect fixtures.db --inspect-file inspect-data.json\r\n>  ---> Running in d373f330e53e\r\n>  ---> 09bab386aaa3\r\n> Removing intermediate container d373f330e53e\r\n> Step 6/7 : EXPOSE 8001\r\n>  ---> Running in e0fe37b3061c\r\n>  ---> 47798440e214\r\n> Removing intermediate container e0fe37b3061c\r\n> Step 7/7 : CMD datasette serve --host 0.0.0.0 fixtures.db --cors --port 8001 --inspect-file inspect-data.json --metadata metadata.json --version-note f0c17229b7a7914d3da02e087dfd0e25d8321448\r\n```\r\n\r\nSo it looks like `--version-note` is being correctly set there.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 333086005, "label": "Deploy demo of Datasette on every commit that passes tests"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/313#issuecomment-397908614", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/313", "id": 397908614, "node_id": "MDEyOklzc3VlQ29tbWVudDM5NzkwODYxNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-06-17T21:44:51Z", "updated_at": "2018-06-17T21:45:03Z", "author_association": "OWNER", "body": "Aha!\r\n```1.03s$ now alias --token=$NOW_TOKEN\r\n> Error! Couldn't find a deployment to alias. Please provide one as an argument.\r\nThe command \"now alias --token=$NOW_TOKEN\" exited with 1.\r\n```\r\nThat explains it. I need to set the same alias in my call to `datasette publish`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 333086005, "label": "Deploy demo of Datasette on every commit that passes tests"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/313#issuecomment-397908947", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/313", "id": 397908947, "node_id": "MDEyOklzc3VlQ29tbWVudDM5NzkwODk0Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-06-17T21:51:34Z", "updated_at": "2018-06-17T21:51:34Z", "author_association": "OWNER", "body": "That fixed it! https://958b75c.datasette.io/-/versions\r\n\r\n```\r\n{\r\n  \"python\": {\r\n    \"version\": \"3.6.5\",\r\n    \"full\": \"3.6.5 (default, Jun  6 2018, 19:19:24) \\n[GCC 6.3.0 20170516]\"\r\n  },\r\n  \"datasette\": {\r\n    \"version\": \"0+unknown\",\r\n    \"note\": \"958b75c69841ef5913da86e0eb2df634a9b95fda\"\r\n  },\r\n  \"sqlite\": {\r\n    \"version\": \"3.16.2\",\r\n    \"fts_versions\": [\r\n      \"FTS5\",\r\n      \"FTS4\",\r\n      \"FTS3\"\r\n    ],\r\n    \"extensions\": {\r\n      \"json1\": null\r\n    }\r\n  }\r\n}\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 333086005, "label": "Deploy demo of Datasette on every commit that passes tests"}, "performed_via_github_app": null}