{"html_url": "https://github.com/simonw/datasette/issues/419#issuecomment-488528111", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/419", "id": 488528111, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4ODUyODExMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-02T01:14:58Z", "updated_at": "2019-05-02T01:14:58Z", "author_association": "OWNER", "body": "I just closed #420 - all of the places in the codebase that were using `.inspect()` should have been eliminated.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 421551434, "label": "Default to opening files in mutable mode, special option for immutable files"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/422#issuecomment-488558896", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/422", "id": 488558896, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4ODU1ODg5Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-02T05:43:11Z", "updated_at": "2019-05-02T05:43:11Z", "author_association": "OWNER", "body": "I'm doing this with time limits right now, which I think is good enough for the moment.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 423316403, "label": "Figure out what to do about table counts in a mutable world"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/427#issuecomment-488564761", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/427", "id": 488564761, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4ODU2NDc2MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-02T06:24:49Z", "updated_at": "2019-05-03T00:07:16Z", "author_association": "OWNER", "body": "https://github.com/simonw/datasette/compare/facet-refactor-2 is almost ready to merge now. The remaining things to do are listed as TODOs there:\r\n\r\n- [x] Ensure facet is not suggested if it is already active\r\n- [x] Don't allow facets to be hidden if they were configured in metadata.json\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 431800286, "label": "New design for facet abstraction, including querystring and metadata.json"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/427#issuecomment-488564891", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/427", "id": 488564891, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4ODU2NDg5MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-02T06:25:41Z", "updated_at": "2019-05-02T06:25:41Z", "author_association": "OWNER", "body": "It would be neat to ship at least one additional face with this work - probably either `ArrayFacet` or `DateFacet`. I think `ArrayFacet` because it demonstrates the only-if-json1-enabled functionality.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 431800286, "label": "New design for facet abstraction, including querystring and metadata.json"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/431#issuecomment-488555399", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/431", "id": 488555399, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4ODU1NTM5OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-02T05:13:54Z", "updated_at": "2019-05-02T05:13:54Z", "author_association": "OWNER", "body": "Datasette master now treats databases as readonly but NOT immutable. This means you can make changes to those databases from another process and those changes will be instantly reflected in the Datasette interface.\r\n\r\nAs such, reloading on database change is no longer necessary. Closing this ticket.", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 432870248, "label": "Datasette doesn't reload when database file changes"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/438#issuecomment-488554835", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/438", "id": 488554835, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4ODU1NDgzNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-02T05:09:18Z", "updated_at": "2019-05-02T05:09:18Z", "author_association": "OWNER", "body": "https://docs.pytest.org/en/latest/example/simple.html#detect-if-running-from-within-a-pytest-run", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 438200529, "label": "Plugins are loaded when running pytest"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/432#issuecomment-488595724", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/432", "id": 488595724, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4ODU5NTcyNA==", "user": {"value": 45057, "label": "russss"}, "created_at": "2019-05-02T08:50:53Z", "updated_at": "2019-05-02T08:50:53Z", "author_association": "CONTRIBUTOR", "body": "> Can I pull those needs out of the Facet class somehow?\r\n\r\nI was thinking that it might be handy for datasette to have a request object which wraps the Sanic Request. This could include the datasette-specific querystring decoding and the `special_args` parsing from TableView.data.\r\n\r\nThis would mean that we could expose the request object to plugin hooks without coupling them to Sanic.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 432893491, "label": "Refactor facets to a class and new plugin, refs #427"}, "performed_via_github_app": null}