{"html_url": "https://github.com/simonw/datasette/issues/558#issuecomment-511168964", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/558", "id": 511168964, "node_id": "MDEyOklzc3VlQ29tbWVudDUxMTE2ODk2NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-14T02:57:53Z", "updated_at": "2019-07-14T02:57:53Z", "author_association": "OWNER", "body": "I think I've fixed it. Here's a demo: https://latest.datasette.io/fixtures/%F0%9D%90%9C%F0%9D%90%A2%F0%9D%90%AD%F0%9D%90%A2%F0%9D%90%9E%F0%9D%90%AC", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 467218270, "label": "Support unicode in url"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/560#issuecomment-511170166", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/560", "id": 511170166, "node_id": "MDEyOklzc3VlQ29tbWVudDUxMTE3MDE2Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-14T03:31:42Z", "updated_at": "2019-07-14T03:31:42Z", "author_association": "OWNER", "body": "```\r\nTypeError: textarea is null[Learn More] codemirror-5.31.0.js:9508:3\r\n    fromTextArea http://127.0.0.1:8001/-/static/codemirror-5.31.0.js:9508\r\n    <anonymous> http://127.0.0.1:8001/fixtures:286\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 467790646, "label": "CodeMirror fails to load on database page"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/560#issuecomment-511170264", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/560", "id": 511170264, "node_id": "MDEyOklzc3VlQ29tbWVudDUxMTE3MDI2NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-14T03:34:24Z", "updated_at": "2019-07-14T03:34:24Z", "author_association": "OWNER", "body": "Here's why:\r\n\r\nhttps://github.com/simonw/datasette/blob/6abe6faff6b035e9334dd05f8c741ae9b7a47440/datasette/templates/_codemirror_foot.html#L2\r\n\r\nThis works on the `query.html` template:\r\n\r\nhttps://github.com/simonw/datasette/blob/6abe6faff6b035e9334dd05f8c741ae9b7a47440/datasette/templates/query.html#L38\r\n\r\nBut fails on the `database.html` template:\r\n\r\nhttps://github.com/simonw/datasette/blob/6abe6faff6b035e9334dd05f8c741ae9b7a47440/datasette/templates/database.html#L28", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 467790646, "label": "CodeMirror fails to load on database page"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/35#issuecomment-511216484", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/35", "id": 511216484, "node_id": "MDEyOklzc3VlQ29tbWVudDUxMTIxNjQ4NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-14T16:26:49Z", "updated_at": "2019-07-14T16:26:49Z", "author_association": "OWNER", "body": "The last touched primary key should go in `last_pk`.\r\n\r\nhttps://github.com/simonw/sqlite-utils/blob/ba6bd47f15c154e348c3c85c05858053a4ab7bab/docs/python-api.rst#L126", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 462430920, "label": "table.update(...) method"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/35#issuecomment-511216664", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/35", "id": 511216664, "node_id": "MDEyOklzc3VlQ29tbWVudDUxMTIxNjY2NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-14T16:29:22Z", "updated_at": "2019-07-14T16:29:22Z", "author_association": "OWNER", "body": "Should this support both dictionaries AND keyword arguments?\r\n```python\r\ndb[\"events_venues\"].update((3, 2), custom_label=\"Label\")\r\n```\r\nPros: this is quite nice to look at.\r\nCons: would have to continue supporting dictionaries as well, since otherwise you won't be able to update columns with names that are not valid Python identifiers. So now there are two ways.\r\n\r\nI'm going to stick with dictionaries only for the moment.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 462430920, "label": "table.update(...) method"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/38#issuecomment-511219187", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/38", "id": 511219187, "node_id": "MDEyOklzc3VlQ29tbWVudDUxMTIxOTE4Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-14T17:05:26Z", "updated_at": "2019-07-14T17:05:26Z", "author_association": "OWNER", "body": "I think I need to solve #36 (compound primary key support) first.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 467862459, "label": "table.update() method"}, "performed_via_github_app": null}