{"html_url": "https://github.com/simonw/datasette/issues/584#issuecomment-543427426", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/584", "id": 543427426, "node_id": "MDEyOklzc3VlQ29tbWVudDU0MzQyNzQyNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-10-18T00:39:15Z", "updated_at": "2019-10-18T00:39:15Z", "author_association": "OWNER", "body": "It looks like this is the problem:\r\nhttps://github.com/simonw/datasette/blob/90d4f497f9b3f6a5882937c91fddb496ac3e7368/datasette/utils/asgi.py#L216-L223\r\nThat should be `utf-8`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 503190241, "label": "Codec error in some CSV exports"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/597#issuecomment-543900283", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/597", "id": 543900283, "node_id": "MDEyOklzc3VlQ29tbWVudDU0MzkwMDI4Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-10-18T19:25:57Z", "updated_at": "2019-10-18T19:27:06Z", "author_association": "OWNER", "body": "I'm suspicious of this code here:\r\nhttps://github.com/simonw/datasette/blob/b6ad1fdc7068cb8248787843e7438d1f19fa2e3a/datasette/views/base.py#L193-L205", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 508070977, "label": "If you have databases called foo.db and foo-bar.db you cannot visit /foo-bar"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/598#issuecomment-543991999", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/598", "id": 543991999, "node_id": "MDEyOklzc3VlQ29tbWVudDU0Mzk5MTk5OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-10-18T22:52:21Z", "updated_at": "2019-10-18T22:52:21Z", "author_association": "OWNER", "body": "This is fixed in master - should be releasing the fix as Datasette 0.30 in the next few days. #584 ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 508100844, "label": "Character encoding bug with CSV export"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/601#issuecomment-543986312", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/601", "id": 543986312, "node_id": "MDEyOklzc3VlQ29tbWVudDU0Mzk4NjMxMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-10-18T22:38:00Z", "updated_at": "2019-10-18T22:38:00Z", "author_association": "OWNER", "body": "@rixx does this look like the right way to do #600 to you?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 509340359, "label": "Don't auto-format SQL on page load"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/601#issuecomment-544008463", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/601", "id": 544008463, "node_id": "MDEyOklzc3VlQ29tbWVudDU0NDAwODQ2Mw==", "user": {"value": 2657547, "label": "rixx"}, "created_at": "2019-10-18T23:39:21Z", "updated_at": "2019-10-18T23:39:21Z", "author_association": "CONTRIBUTOR", "body": "That looks right, and I completely agree with the intent.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 509340359, "label": "Don't auto-format SQL on page load"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/601#issuecomment-544008944", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/601", "id": 544008944, "node_id": "MDEyOklzc3VlQ29tbWVudDU0NDAwODk0NA==", "user": {"value": 2657547, "label": "rixx"}, "created_at": "2019-10-18T23:40:48Z", "updated_at": "2019-10-18T23:40:48Z", "author_association": "CONTRIBUTOR", "body": "The only negative impact that comes to mind is that now you have no way to get the read-only query to be formatted nicely, I think, so maybe a second PR adding the formatting functionality even to the read-only page would be good?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 509340359, "label": "Don't auto-format SQL on page load"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/601#issuecomment-544014518", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/601", "id": 544014518, "node_id": "MDEyOklzc3VlQ29tbWVudDU0NDAxNDUxOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-10-18T23:57:44Z", "updated_at": "2019-10-18T23:57:44Z", "author_association": "OWNER", "body": "That's a good idea. It could even be smart about it and only show the \"Format SQL\" button on that page of the output of the function would differ from what's there already.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 509340359, "label": "Don't auto-format SQL on page load"}, "performed_via_github_app": null}