{"html_url": "https://github.com/dogsheep/dogsheep-photos/issues/12#issuecomment-618796564", "issue_url": "https://api.github.com/repos/dogsheep/dogsheep-photos/issues/12", "id": 618796564, "node_id": "MDEyOklzc3VlQ29tbWVudDYxODc5NjU2NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-04-24T04:35:25Z", "updated_at": "2020-04-24T04:35:25Z", "author_association": "MEMBER", "body": "Code: https://github.com/dogsheep/photos-to-sqlite/blob/a388cf1f1b6b67752d669466cda8b171b6582171/photos_to_sqlite/cli.py#L109-L114", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 606033104, "label": "If less than 500MB, show size in MB not GB"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/648#issuecomment-618775028", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/648", "id": 618775028, "node_id": "MDEyOklzc3VlQ29tbWVudDYxODc3NTAyOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-04-24T03:01:32Z", "updated_at": "2020-04-24T03:01:32Z", "author_association": "OWNER", "body": "Now that I've closed #577 this should be pretty easy to implement.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 534492501, "label": "Mechanism for adding arbitrary pages like /about"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/648#issuecomment-618775631", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/648", "id": 618775631, "node_id": "MDEyOklzc3VlQ29tbWVudDYxODc3NTYzMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-04-24T03:03:35Z", "updated_at": "2020-04-24T03:03:35Z", "author_association": "OWNER", "body": "> Stretch goal: it would be neat if these pages could return custom HTTP headers (eg content-type) and maybe even status codes (eg for redirects) somehow.\r\n\r\nI think I could do that with a custom template function - if that function is called during the render then we follow those instructions instead of returning the rendered HTML.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 534492501, "label": "Mechanism for adding arbitrary pages like /about"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/648#issuecomment-619259859", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/648", "id": 619259859, "node_id": "MDEyOklzc3VlQ29tbWVudDYxOTI1OTg1OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-04-24T22:10:34Z", "updated_at": "2020-04-24T22:10:34Z", "author_association": "OWNER", "body": "The trickiest part here is the 404 logic. It's spread out through a couple of places right now. It's in `datasette.utils.asgi.AsgiRouter`:\r\n\r\nhttps://github.com/simonw/datasette/blob/227bb3e91fe34811a9374150798643a5af98ed79/datasette/utils/asgi.py#L98-L134\r\n\r\nThen also in the `DatasetteRouter subclass of that:\r\n\r\nhttps://github.com/simonw/datasette/blob/227bb3e91fe34811a9374150798643a5af98ed79/datasette/app.py#L736-L757", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 534492501, "label": "Mechanism for adding arbitrary pages like /about"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/648#issuecomment-619263600", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/648", "id": 619263600, "node_id": "MDEyOklzc3VlQ29tbWVudDYxOTI2MzYwMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-04-24T22:23:13Z", "updated_at": "2020-04-24T22:23:13Z", "author_association": "OWNER", "body": "Idea: `handle_404` can hand certain not found errors off to `handle_500` so it can render them correctly;\r\n\r\nhttps://github.com/simonw/datasette/blob/227bb3e91fe34811a9374150798643a5af98ed79/datasette/app.py#L748-L765", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 534492501, "label": "Mechanism for adding arbitrary pages like /about"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/731#issuecomment-618758326", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/731", "id": 618758326, "node_id": "MDEyOklzc3VlQ29tbWVudDYxODc1ODMyNg==", "user": {"value": 25778, "label": "eyeseast"}, "created_at": "2020-04-24T01:55:00Z", "updated_at": "2020-04-24T01:55:00Z", "author_association": "CONTRIBUTOR", "body": "Mounting `./static` at `/static` seems the simplest way. Saves you the trouble of deciding what else (`img` for example) gets special treatment.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 605110015, "label": "Option to automatically configure based on directory layout"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/731#issuecomment-618772317", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/731", "id": 618772317, "node_id": "MDEyOklzc3VlQ29tbWVudDYxODc3MjMxNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-04-24T02:49:46Z", "updated_at": "2020-04-24T02:49:46Z", "author_association": "OWNER", "body": "Yeah I'll do that. My original thinking on allowing the `--static` option to mount other things to the root is that it would make it easy for people to add HTML \"pages\" to their site - like https://www.niche-museums.com/map for example.\r\n\r\nBut I've proposed a better solution for that here: #648", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 605110015, "label": "Option to automatically configure based on directory layout"}, "performed_via_github_app": null}