{"html_url": "https://github.com/simonw/datasette/issues/956#issuecomment-683212246", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/956", "id": 683212246, "node_id": "MDEyOklzc3VlQ29tbWVudDY4MzIxMjI0Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-08-29T01:21:26Z", "updated_at": "2020-08-29T01:21:26Z", "author_association": "OWNER", "body": "I added this but I have no idea if I got it right or not: https://github.com/simonw/datasette/blob/c36e287d71d68ecb2a45e9808eede15f19f931fb/.github/workflows/publish.yml#L58-L63", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 688427751, "label": "Push to Docker Hub failed - but it shouldn't run for alpha releases anyway"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/956#issuecomment-683212421", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/956", "id": 683212421, "node_id": "MDEyOklzc3VlQ29tbWVudDY4MzIxMjQyMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-08-29T01:22:23Z", "updated_at": "2020-08-29T01:22:23Z", "author_association": "OWNER", "body": "Here's the error message again:\r\n\r\n> invalid argument `\"***/datasette::0.49a0\"` for `\"-t, --tag\"` flag: invalid reference format", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 688427751, "label": "Push to Docker Hub failed - but it shouldn't run for alpha releases anyway"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/956#issuecomment-683212960", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/956", "id": 683212960, "node_id": "MDEyOklzc3VlQ29tbWVudDY4MzIxMjk2MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-08-29T01:25:34Z", "updated_at": "2020-08-29T01:25:34Z", "author_association": "OWNER", "body": "So I guess this bit is wrong: https://github.com/simonw/datasette/blob/c36e287d71d68ecb2a45e9808eede15f19f931fb/.github/workflows/publish.yml#L71-L73", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 688427751, "label": "Push to Docker Hub failed - but it shouldn't run for alpha releases anyway"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/956#issuecomment-683213973", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/956", "id": 683213973, "node_id": "MDEyOklzc3VlQ29tbWVudDY4MzIxMzk3Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-08-29T01:31:39Z", "updated_at": "2020-08-29T01:31:39Z", "author_association": "OWNER", "body": "Here's how the old Travis mechanism worked: https://github.com/simonw/datasette/blob/52eabb019d4051084b21524bd0fd9c2731126985/.travis.yml#L41-L47\r\n\r\nSo I was assuming that the eqivalent of `$REPO:$TRAVIS_TAG` in GitHub Actions is `$REPO::${GITHUB_REF#refs/tags/}`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 688427751, "label": "Push to Docker Hub failed - but it shouldn't run for alpha releases anyway"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/956#issuecomment-683214102", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/956", "id": 683214102, "node_id": "MDEyOklzc3VlQ29tbWVudDY4MzIxNDEwMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-08-29T01:32:21Z", "updated_at": "2020-08-29T01:32:21Z", "author_association": "OWNER", "body": "Maybe the bug here is the double colon?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 688427751, "label": "Push to Docker Hub failed - but it shouldn't run for alpha releases anyway"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/957#issuecomment-683355508", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/957", "id": 683355508, "node_id": "MDEyOklzc3VlQ29tbWVudDY4MzM1NTUwOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-08-29T23:54:01Z", "updated_at": "2020-08-29T23:54:01Z", "author_association": "OWNER", "body": "Reviewing https://github.com/search?q=user%3Asimonw+%22from+datasette%22&type=Code I spotted these others:\r\n\r\n```python\r\n# Various:\r\nfrom datasette.utils import path_with_replaced_args\r\nfrom datasette.plugins import pm\r\nfrom datasette.utils import QueryInterrupted\r\nfrom datasette.utils.asgi import Response, Forbidden, NotFound\r\n\r\n# datasette-publish-vercel:\r\nfrom datasette.publish.common import (\r\n    add_common_publish_arguments_and_options,\r\n    fail_if_publish_binary_not_installed\r\n)\r\nfrom datasette.utils import temporary_docker_directory\r\n\r\n# datasette-insert\r\nfrom datasette.utils import actor_matches_allow, sqlite3\r\n\r\n# obsolete: russian-ira-facebook-ads-datasette \r\nfrom datasette.utils import TableFilter\r\n\r\n# simonw/museums\r\nfrom datasette.utils.asgi import asgi_send\r\n\r\n# datasette-media\r\nfrom datasette.utils.asgi import Response, asgi_send_file\r\n\r\n# datasette/tests/plugins/my_plugin.py\r\nfrom datasette.facets import Facet\r\n\r\n# datasette-graphql\r\nfrom datasette.views.table import TableView\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 688622148, "label": "Simplify imports of common classes"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/957#issuecomment-683355598", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/957", "id": 683355598, "node_id": "MDEyOklzc3VlQ29tbWVudDY4MzM1NTU5OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-08-29T23:55:10Z", "updated_at": "2020-08-29T23:55:34Z", "author_association": "OWNER", "body": "Of these I think I'm going to promote the following to being importable directly `from datasette`:\r\n\r\n- `from datasette.app import Datasette`\r\n- `from datasette.utils import QueryInterrupted`\r\n- `from datasette.utils.asgi import Response, Forbidden, NotFound`\r\n- `from datasette.utils import actor_matches_allow`\r\n\r\nAll of the rest are infrequently used enough (or clearly named enough) that I'm happy to leave them as-is.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 688622148, "label": "Simplify imports of common classes"}, "performed_via_github_app": null}