{"html_url": "https://github.com/simonw/datasette/issues/1394#issuecomment-880287483", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1394", "id": 880287483, "node_id": "MDEyOklzc3VlQ29tbWVudDg4MDI4NzQ4Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-15T00:01:47Z", "updated_at": "2021-07-15T00:01:47Z", "author_association": "OWNER", "body": "I wrote this code:\r\n```python\r\n_order_by_re = re.compile(r\"(^.*) order by [a-zA-Z_][a-zA-Z0-9_]+( desc)?$\", re.DOTALL)\r\n_order_by_braces_re = re.compile(r\"(^.*) order by \\[[^\\]]+\\]( desc)?$\", re.DOTALL)\r\n\r\n\r\ndef strip_order_by(sql):\r\n    for regex in (_order_by_re, _order_by_braces_re):\r\n        match = regex.match(sql)\r\n        if match is not None:\r\n            return match.group(1)\r\n    return sql\r\n\r\n@pytest.mark.parametrize(\r\n    \"sql,expected\",\r\n    [\r\n        (\"blah\", \"blah\"),\r\n        (\"select * from foo\", \"select * from foo\"),\r\n        (\"select * from foo order by bah\", \"select * from foo\"),\r\n        (\"select * from foo order by bah desc\", \"select * from foo\"),\r\n        (\"select * from foo order by [select]\", \"select * from foo\"),\r\n        (\"select * from foo order by [select] desc\", \"select * from foo\"),\r\n    ],\r\n)\r\ndef test_strip_order_by(sql, expected):\r\n    assert strip_order_by(sql) == expected\r\n```\r\nBut it turns out I don't need it! The SQL that is passed to the facet class is created by this code: https://github.com/simonw/datasette/blob/ba11ef27edd6981eeb26d7ecf5aa236707f5f8ce/datasette/views/table.py#L677-L684\r\n\r\nAnd the only place that uses that `sql_no_limit` variable is here: https://github.com/simonw/datasette/blob/ba11ef27edd6981eeb26d7ecf5aa236707f5f8ce/datasette/views/table.py#L733-L745\r\n\r\nSo I can change that to `sql_no_limit_no_order` and fix the bug that way instead.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 944870799, "label": "Big performance boost on faceting: skip the inner order by"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1394#issuecomment-880900534", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1394", "id": 880900534, "node_id": "MDEyOklzc3VlQ29tbWVudDg4MDkwMDUzNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-15T17:58:03Z", "updated_at": "2021-07-15T17:58:03Z", "author_association": "OWNER", "body": "Started a conversation about this on the SQLite forum: https://sqlite.org/forum/forumpost/2d76f2bcf65d256a?t=h", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 944870799, "label": "Big performance boost on faceting: skip the inner order by"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1396#issuecomment-880324637", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1396", "id": 880324637, "node_id": "MDEyOklzc3VlQ29tbWVudDg4MDMyNDYzNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-15T01:46:26Z", "updated_at": "2021-07-15T01:46:26Z", "author_association": "OWNER", "body": "I manually published the Docker image using https://github.com/simonw/datasette/actions/workflows/push_docker_tag.yml https://github.com/simonw/datasette/runs/3072505126\r\n\r\nThe 0.58 release shows up on https://hub.docker.com/r/datasetteproject/datasette/tags?page=1&ordering=last_updated now - BUT the `latest` tag still points to a version from a month ago.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 944903881, "label": "\"invalid reference format\" publishing Docker image"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1396#issuecomment-880325004", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1396", "id": 880325004, "node_id": "MDEyOklzc3VlQ29tbWVudDg4MDMyNTAwNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-15T01:47:17Z", "updated_at": "2021-07-15T01:47:17Z", "author_association": "OWNER", "body": "This is the part of the publish workflow that failed and threw the \"invalid reference format\" error: https://github.com/simonw/datasette/blob/084cfe1e00e1a4c0515390a513aca286eeea20c2/.github/workflows/publish.yml#L100-L119", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 944903881, "label": "\"invalid reference format\" publishing Docker image"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1396#issuecomment-880325362", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1396", "id": 880325362, "node_id": "MDEyOklzc3VlQ29tbWVudDg4MDMyNTM2Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-15T01:48:11Z", "updated_at": "2021-07-15T01:48:11Z", "author_association": "OWNER", "body": "In particular these three lines: https://github.com/simonw/datasette/blob/084cfe1e00e1a4c0515390a513aca286eeea20c2/.github/workflows/publish.yml#L117-L119", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 944903881, "label": "\"invalid reference format\" publishing Docker image"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1396#issuecomment-880326049", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1396", "id": 880326049, "node_id": "MDEyOklzc3VlQ29tbWVudDg4MDMyNjA0OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-15T01:50:05Z", "updated_at": "2021-07-15T01:50:05Z", "author_association": "OWNER", "body": "I think I made a mistake in this commit: https://github.com/simonw/datasette/commit/0486303b60ce2784fd2e2ecdbecf304b7d6e6659\r\n\r\n<img width=\"770\" alt=\"Explicitly_push_version_tag__refs__1281_\u00b7_simonw_datasette_0486303\" src=\"https://user-images.githubusercontent.com/9599/125715241-dc96d147-191a-4a69-bdf0-1cb092d97330.png\">\r\n\r\nIt looks like I copied `$VERSION_TAG` from here - but it's not available in the `publish.yml` flow: https://github.com/simonw/datasette/blob/0486303b60ce2784fd2e2ecdbecf304b7d6e6659/.github/workflows/push_docker_tag.yml#L18-L25", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 944903881, "label": "\"invalid reference format\" publishing Docker image"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1396#issuecomment-880372149", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1396", "id": 880372149, "node_id": "MDEyOklzc3VlQ29tbWVudDg4MDM3MjE0OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-15T03:56:49Z", "updated_at": "2021-07-15T03:56:49Z", "author_association": "OWNER", "body": "I'm going to leave this open until I next successfully publish a new version.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 944903881, "label": "\"invalid reference format\" publishing Docker image"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1396#issuecomment-880374156", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1396", "id": 880374156, "node_id": "MDEyOklzc3VlQ29tbWVudDg4MDM3NDE1Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-15T04:03:18Z", "updated_at": "2021-07-15T04:03:18Z", "author_association": "OWNER", "body": "I fixed  `datasette:latest` by running the following on my laptop:\r\n```\r\ndocker pull datasetteproject/datasette:0.58\r\ndocker tag datasetteproject/datasette:0.58 datasetteproject/datasette:latest\r\ndocker login -u datasetteproject -p ...\r\ndocker push datasetteproject/datasette:latest\r\n```\r\nConfirmed on https://hub.docker.com/r/datasetteproject/datasette/tags?page=1&ordering=last_updated that `datasette:latest` and `datasette:0.58` both now have the same digest of `3b5ba478040e`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 944903881, "label": "\"invalid reference format\" publishing Docker image"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1396#issuecomment-880967052", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1396", "id": 880967052, "node_id": "MDEyOklzc3VlQ29tbWVudDg4MDk2NzA1Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-15T19:47:25Z", "updated_at": "2021-07-15T19:47:25Z", "author_association": "OWNER", "body": "Actually I'm going to close this now and re-open it if the problem occurs again in the future.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 944903881, "label": "\"invalid reference format\" publishing Docker image"}, "performed_via_github_app": null}