{"html_url": "https://github.com/simonw/datasette/issues/678#issuecomment-589897959", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/678", "id": 589897959, "node_id": "MDEyOklzc3VlQ29tbWVudDU4OTg5Nzk1OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-22T01:02:47Z", "updated_at": "2020-02-22T01:02:47Z", "author_association": "OWNER", "body": "While I'm at it, the hook should accept an optional `database` name argument as well.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 569253072, "label": "prepare_connection() plugin hook should accept optional datasette argument"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/678#issuecomment-589908060", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/678", "id": 589908060, "node_id": "MDEyOklzc3VlQ29tbWVudDU4OTkwODA2MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-22T02:28:51Z", "updated_at": "2020-02-22T02:28:51Z", "author_association": "OWNER", "body": "Done. Updated documentation is here: https://datasette.readthedocs.io/en/latest/plugins.html#prepare-connection-conn-database-datasette", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 569253072, "label": "prepare_connection() plugin hook should accept optional datasette argument"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/676#issuecomment-589908293", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/676", "id": 589908293, "node_id": "MDEyOklzc3VlQ29tbWVudDU4OTkwODI5Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-22T02:31:21Z", "updated_at": "2020-02-22T02:31:21Z", "author_association": "OWNER", "body": "I'm afraid this is by design: supporting wildcards in that mode was more-or-less accidental and often resulted in unexpected user-facing syntax errors when users accidentally entered search text that included characters with special meaning to SQLite.\r\n\r\nYou can still execute wildcard searches but you have to do so using custom SQL statements.\r\n\r\nI'm open to suggestions for more friendly ways to support this functionality. Would an alternative `_search_wildcard=` URL parameter be worth supporting I wonder? What's your specific use-case for wildcards?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 568091133, "label": "?_searchmode=raw option for running FTS searches without escaping characters"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/669#issuecomment-589908363", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/669", "id": 589908363, "node_id": "MDEyOklzc3VlQ29tbWVudDU4OTkwODM2Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-22T02:32:00Z", "updated_at": "2020-02-22T02:32:00Z", "author_association": "OWNER", "body": "Thanks for spotting this!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 563348959, "label": "fix db-to-sqlite command in ecosystem doc page"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/666#issuecomment-589908465", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/666", "id": 589908465, "node_id": "MDEyOklzc3VlQ29tbWVudDU4OTkwODQ2NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-22T02:33:18Z", "updated_at": "2020-02-22T02:33:18Z", "author_association": "OWNER", "body": "This is a smart optimization. I'd like to add a test for it, since the logic is a tiny bit more complex.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 562085508, "label": "Use inspect-file, if possible, for total row count"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/675#issuecomment-589908912", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/675", "id": 589908912, "node_id": "MDEyOklzc3VlQ29tbWVudDU4OTkwODkxMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-22T02:38:21Z", "updated_at": "2020-02-22T02:38:21Z", "author_association": "OWNER", "body": "Interesting feature suggestion.\r\n\r\nMy initial instinct was that this would be better handled using the layered nature of Docker - so build a Docker image with `datasette package` and then have a separate custom script which takes that image, copies in the extra data and outputs a new image.\r\n\r\nBut... `datasette package` is already meant to be more convenient than messing around with Docker by hand like this - so actually having a `--copy` option like you describe here feels like it's within scope of what `datasette package` is meant to do.\r\n\r\nSo yeah - if you're happy to design this I think it would be worth us adding.\r\n\r\nSmall design suggestion: allow `--copy` to be applied multiple times, so you can do something like this:\r\n\r\n    datasette package \\\r\n        --copy ~/project/templates /templates \\\r\n        --copy ~/project/README.md /README.md \\\r\n        data.db\r\n\r\nAlso since Click arguments can take multiple options I don't think you need to have the `:` in there - although if it better matches Docker's own UI it might be more consistent to have it.", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 567902704, "label": "--cp option for datasette publish and datasette package for shipping additional files and directories"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/679#issuecomment-589909401", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/679", "id": 589909401, "node_id": "MDEyOklzc3VlQ29tbWVudDU4OTkwOTQwMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-22T02:43:42Z", "updated_at": "2020-02-22T02:46:16Z", "author_association": "OWNER", "body": "Before shipping there are a few additions I can make to the https://datasette.readthedocs.io/en/stable/ecosystem.html page:\r\n\r\n* https://github.com/simonw/shapefile-to-sqlite\r\n* https://github.com/simonw/datasette-mask-columns (which will itself depend on 0.36 being out)\r\n* https://github.com/simonw/datasette-auth-existing-cookies\r\n* https://github.com/simonw/datasette-sentry\r\n\r\nI could also add links to associated blog entries directly to those descriptions on the ecosystem page:\r\n\r\n* https://simonwillison.net/2020/Jan/29/weeknotes-datasette-cookies-sentry/\r\n* https://simonwillison.net/2020/Feb/19/shapefile-to-sqlite/", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 569268612, "label": "Release 0.36"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/680#issuecomment-589914711", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/680", "id": 589914711, "node_id": "MDEyOklzc3VlQ29tbWVudDU4OTkxNDcxMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-22T03:51:47Z", "updated_at": "2020-02-22T03:51:47Z", "author_association": "OWNER", "body": "I considered just updating the GitHub release with a link to the release notes, but I'm building other things against the GitHub releases API such that it's nicer to have the release notes live there.\r\n\r\nI bet I could use pandoc to automate the conversion of the formats in one or other direction.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 569275763, "label": "Release automation: automate the bit that posts the GitHub release"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/679#issuecomment-589914753", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/679", "id": 589914753, "node_id": "MDEyOklzc3VlQ29tbWVudDU4OTkxNDc1Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-22T03:52:13Z", "updated_at": "2020-02-22T03:52:13Z", "author_association": "OWNER", "body": "https://datasette.readthedocs.io/en/stable/changelog.html#v0-36", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 569268612, "label": "Release 0.36"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/678#issuecomment-589914811", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/678", "id": 589914811, "node_id": "MDEyOklzc3VlQ29tbWVudDU4OTkxNDgxMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-02-22T03:53:07Z", "updated_at": "2020-02-22T03:53:19Z", "author_association": "OWNER", "body": "Shipped in 0.36 https://datasette.readthedocs.io/en/stable/changelog.html#v0-36", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 569253072, "label": "prepare_connection() plugin hook should accept optional datasette argument"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/676#issuecomment-589922016", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/676", "id": 589922016, "node_id": "MDEyOklzc3VlQ29tbWVudDU4OTkyMjAxNg==", "user": {"value": 58088336, "label": "tunguyenatwork"}, "created_at": "2020-02-22T05:50:10Z", "updated_at": "2020-02-22T05:50:10Z", "author_association": "NONE", "body": "Thanks Simon,\r\nMy use case is using Datasette for full text search type ahead.  That was working pretty well. The _search_wildcard= option will be awesome.  Thanks\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 568091133, "label": "?_searchmode=raw option for running FTS searches without escaping characters"}, "performed_via_github_app": null}