{"html_url": "https://github.com/simonw/datasette/issues/606#issuecomment-548673320", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/606", "id": 548673320, "node_id": "MDEyOklzc3VlQ29tbWVudDU0ODY3MzMyMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-01T05:41:03Z", "updated_at": "2019-11-01T05:41:03Z", "author_association": "OWNER", "body": "Couldn't easily write a test for this as plugin tests don't currently work against packaged plugins.\r\n\r\nHere's the new `datasette plugins` output:\r\n```\r\n$ datasette plugins\r\n[\r\n    {\r\n        \"name\": \"datasette-cluster-map\",\r\n        \"static\": true,\r\n        \"templates\": false,\r\n        \"version\": \"0.6\"\r\n    },\r\n    {\r\n        \"name\": \"datasette-json-html\",\r\n        \"static\": false,\r\n        \"templates\": false,\r\n        \"version\": \"0.5\"\r\n    },\r\n    {\r\n        \"name\": \"datasette-vega\",\r\n        \"static\": true,\r\n        \"templates\": false,\r\n        \"version\": \"0.6.2\"\r\n    }\r\n]\r\n```\r\nSame output from `/-/plugins`", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 512218858, "label": "/-/plugins shows incorrect name for plugins"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/574#issuecomment-548963625", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/574", "id": 548963625, "node_id": "MDEyOklzc3VlQ29tbWVudDU0ODk2MzYyNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-01T21:53:05Z", "updated_at": "2019-11-01T21:53:05Z", "author_association": "OWNER", "body": "That's a great idea, thanks for the feedback.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 494685791, "label": "Improve usage description of --host option"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/574#issuecomment-548964895", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/574", "id": 548964895, "node_id": "MDEyOklzc3VlQ29tbWVudDU0ODk2NDg5NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-01T21:58:17Z", "updated_at": "2019-11-01T21:58:17Z", "author_association": "OWNER", "body": "New description:\r\n```\r\n  -h, --host TEXT           Host for server. Defaults to 127.0.0.1 which means\r\n                            only connections from the local machine will be\r\n                            allowed. Use 0.0.0.0 to listen to all IPs and\r\n                            allow access from other machines.\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 494685791, "label": "Improve usage description of --host option"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/611#issuecomment-548967432", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/611", "id": 548967432, "node_id": "MDEyOklzc3VlQ29tbWVudDU0ODk2NzQzMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-01T22:08:57Z", "updated_at": "2019-11-01T22:09:16Z", "author_association": "OWNER", "body": "Argh this is actually a bug in the already-shipped plugins themselves:\r\n\r\n```python\r\n@hookimpl\r\ndef extra_js_urls():\r\n    return [\r\n        {\r\n            \"url\": \"https://unpkg.com/leaflet@1.5.1/dist/leaflet.js\",\r\n            \"sri\": \"sha512-GffPMF3RvMeYyc1LWMHtK8EbPv0iNZ8/oTtHPx9/cc2ILxQ+u905qIwdpULaqDkyBKgOaB57QTMg7ztg8Jm2Og==\",\r\n        },\r\n        \"/-/static-plugins/datasette_leaflet_geojson/datasette-leaflet-geojson.js\",\r\n    ]\r\n```\r\nhttps://github.com/simonw/datasette-leaflet-geojson/blob/f8b5b1bd797b8c1b9a1771c259037dca258cce40/datasette_leaflet_geojson/__init__.py#L14-L22\r\n\r\nMaybe I should revert #606?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 516370822, "label": "Static assets no longer loading for installed plugins"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/611#issuecomment-548967774", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/611", "id": 548967774, "node_id": "MDEyOklzc3VlQ29tbWVudDU0ODk2Nzc3NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-01T22:10:31Z", "updated_at": "2019-11-01T22:10:31Z", "author_association": "OWNER", "body": "The alternative would be to ship brand new fixed versions of all of these plugins and have those fixes require a minimum release of Datasette.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 516370822, "label": "Static assets no longer loading for installed plugins"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/611#issuecomment-548968034", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/611", "id": 548968034, "node_id": "MDEyOklzc3VlQ29tbWVudDU0ODk2ODAzNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-01T22:11:33Z", "updated_at": "2019-11-01T22:11:33Z", "author_association": "OWNER", "body": "Or I could support both `with-hyphens` and `with_underscores` variants of the plugin names? That would provide a painless upgrade path - maybe this is something I could clean up in the backwards compatibility breaking 1.0 version?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 516370822, "label": "Static assets no longer loading for installed plugins"}, "performed_via_github_app": null}