{"html_url": "https://github.com/simonw/datasette/issues/394#issuecomment-604166918", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/394", "id": 604166918, "node_id": "MDEyOklzc3VlQ29tbWVudDYwNDE2NjkxOA==", "user": {"value": 127565, "label": "wragge"}, "created_at": "2020-03-26T00:56:30Z", "updated_at": "2020-03-26T00:56:30Z", "author_association": "CONTRIBUTOR", "body": "Thanks! I'm trying to launch Datasette from *within* a notebook using the jupyter-server-proxy and the new `base_url` parameter. While the assets load ok, and the breadcrumb navigation works, the facet links don't seem to use the `base_url`. Or have I missed something?\r\n\r\nMy test repository is here: https://github.com/wragge/datasette-test", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 396212021, "label": "base_url configuration setting"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/712#issuecomment-604193362", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/712", "id": 604193362, "node_id": "MDEyOklzc3VlQ29tbWVudDYwNDE5MzM2Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-03-26T02:32:57Z", "updated_at": "2020-03-26T02:32:57Z", "author_association": "OWNER", "body": "Weird... the unit test I just added passes. So suggested facets look like they're OK.\r\n\r\nAnd yet the demo in https://mybinder.org/v2/gh/wragge/datasette-test/master?urlpath=lab doesn't work.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 588108428, "label": "base_url doesn't entirely work for running Datasette inside Binder"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/712#issuecomment-604194598", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/712", "id": 604194598, "node_id": "MDEyOklzc3VlQ29tbWVudDYwNDE5NDU5OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-03-26T02:37:46Z", "updated_at": "2020-03-26T02:37:46Z", "author_association": "OWNER", "body": "Here's the truncatted HTML for https://hub.gke.mybinder.org/user/wragge-datasette-test-czqms2oy/proxy/8001/results/articles\r\n```html\r\n\r\n\r\n
\r\nThis data as json, CSV (advanced)
\r\n\r\n Suggested facets: newspaper_id, newspaper_title, page, category, illustrated, corrections, date (date)\r\n
\r\n\r\n Link\r\n | \r\n\r\n rowid \u25bc\r\n | \r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 588108428, "label": "base_url doesn't entirely work for running Datasette inside Binder"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/712#issuecomment-604195577", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/712", "id": 604195577, "node_id": "MDEyOklzc3VlQ29tbWVudDYwNDE5NTU3Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-03-26T02:41:40Z", "updated_at": "2020-03-26T02:41:40Z", "author_association": "OWNER", "body": "Aha! It turns out my demo at https://github.com/simonw/jupyterserverproxy-datasette-demo suffers from the same bug.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 588108428, "label": "base_url doesn't entirely work for running Datasette inside Binder"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/712#issuecomment-604194872", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/712", "id": 604194872, "node_id": "MDEyOklzc3VlQ29tbWVudDYwNDE5NDg3Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-03-26T02:38:48Z", "updated_at": "2020-03-26T04:04:04Z", "author_association": "OWNER", "body": "I have a hunch about this: maybe the URLs that work are the ones that use `{{ base_url }}` directly in the template, while the ones that break are the ones that reconstruct the URL based on the incoming path?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 588108428, "label": "base_url doesn't entirely work for running Datasette inside Binder"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/712#issuecomment-604218449", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/712", "id": 604218449, "node_id": "MDEyOklzc3VlQ29tbWVudDYwNDIxODQ0OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-03-26T04:12:59Z", "updated_at": "2020-03-26T04:15:18Z", "author_association": "OWNER", "body": "I'm running this latest release like so:\r\n\r\nLaunch this binder: https://mybinder.org/v2/gh/wragge/datasette-test/master?urlpath=lab\r\n\r\nOpen the notebook.\r\n\r\nIn the notebook run this:\r\n\r\n !pip install datasette-debug-asgi https://github.com/simonw/datasette/archive/7b205af0b53c92d17b69f8c95d70a24a0c06ebce.zip\r\n\r\nAnd use this block to run Datasette:\r\n\r\n```\r\n# Get current running servers\r\nservers = list_running_servers()\r\n\r\n# Get the current base url\r\nbase_url = next(servers)['base_url']\r\n\r\n# Create a base url for Datasette suing the proxy path\r\nproxy_url = f'{base_url}proxy/8001/'\r\n\r\n# Display a link to Datasette\r\ndisplay(HTML(f'
---|