{"html_url": "https://github.com/simonw/sqlite-utils/pull/480#issuecomment-1232089808", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/480", "id": 1232089808, "node_id": "IC_kwDOCGYnMM5JcDLQ", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-08-30T19:43:02Z", "updated_at": "2022-08-30T19:43:02Z", "author_association": "OWNER", "body": "Yeah this seems like a reasonable addition to me. \r\n\r\nNeeds a test, which can go next to this one: https://github.com/simonw/sqlite-utils/blob/087753cd42c406f1e060c1822dcd9b5fda3d60f4/tests/test_fts.py#L561", "reactions": "{\"total_count\": 1, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 1, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1355433619, "label": "search_sql add include_rank option"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1796#issuecomment-1231127175", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1796", "id": 1231127175, "node_id": "IC_kwDOBm6k_c5JYYKH", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-08-30T04:30:29Z", "updated_at": "2022-08-30T04:30:29Z", "author_association": "OWNER", "body": "I wonder if CodeMirror 6 would be a good time to revisit this:\r\n- #1614", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1355148385, "label": "Research an upgrade to CodeMirror 6"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1796#issuecomment-1231127022", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1796", "id": 1231127022, "node_id": "IC_kwDOBm6k_c5JYYHu", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-08-30T04:30:07Z", "updated_at": "2022-08-30T04:30:07Z", "author_association": "OWNER", "body": "Also relevant: Wikimedia are upgrading to CodeMirror 6 partly because of improved mobile support: https://phabricator.wikimedia.org/T259059", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1355148385, "label": "Research an upgrade to CodeMirror 6"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1796#issuecomment-1231126795", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1796", "id": 1231126795, "node_id": "IC_kwDOBm6k_c5JYYEL", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-08-30T04:29:35Z", "updated_at": "2022-08-30T04:29:35Z", "author_association": "OWNER", "body": "I wrote upgrade instructions for CodeMirror here: https://docs.datasette.io/en/0.62/contributing.html#upgrading-codemirror\r\n\r\nSee also:\r\n- #948\r\n\r\nBut... those instructions don't work any more, because they start with downloading the CodeMirror zip - but according to https://codemirror.net/docs/migration/\r\n\r\n> The 5.x library was distributed as UMD modules, which could either be loaded directly with <script> tags or bundled as CommonJS modules. The new version exposes only modules, which will require some kind of build step before you can use them.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1355148385, "label": "Research an upgrade to CodeMirror 6"}, "performed_via_github_app": null}