{"html_url": "https://github.com/simonw/datasette/issues/203#issuecomment-381300336", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/203", "id": 381300336, "node_id": "MDEyOklzc3VlQ29tbWVudDM4MTMwMDMzNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-04-14T03:35:02Z", "updated_at": "2018-04-14T03:35:02Z", "author_association": "OWNER", "body": "This is really cool - I'm very impressed by pint.\r\n\r\nI'd like to figure out a sensible opt-in way to expose this in the JSON output as well. Maybe with a `&_units=true` parameter?\r\n\r\nWe should definitely expose the units section from the table metadata in the output of https://wtr-api.herokuapp.com/wtr-663ea99/license_frequency.json", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 313837303, "label": "Support for units"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/203#issuecomment-381300386", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/203", "id": 381300386, "node_id": "MDEyOklzc3VlQ29tbWVudDM4MTMwMDM4Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-04-14T03:35:56Z", "updated_at": "2018-04-14T03:35:56Z", "author_association": "OWNER", "body": "In #204 you said \"I'd like to add support for using units when querying but this is PR is pretty usable as-is.\" - I'm fascinated to hear more about how this could work.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 313837303, "label": "Support for units"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/203#issuecomment-381330075", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/203", "id": 381330075, "node_id": "MDEyOklzc3VlQ29tbWVudDM4MTMzMDA3NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-04-14T13:41:53Z", "updated_at": "2018-04-14T13:41:53Z", "author_association": "OWNER", "body": "Presumably units only work for numeric fields? If that's the case then automatically processing them if the incoming query string argument has a unit suffix makes total sense to me.\r\n\r\nHere's a pretty crazy idea: what if we exposed unit conversion to SQL as a custom SQLite function? That way it would be possible to optionally use units in actual custom SQL queries. \r\n\r\nI'd have to think quite carefully about performance implications here - wouldn't want a poorly considered unit calculation over a 500,000 row table to lock up the server. But I think the 1s query time limit might still prevent that.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 313837303, "label": "Support for units"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/205#issuecomment-381330220", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/205", "id": 381330220, "node_id": "MDEyOklzc3VlQ29tbWVudDM4MTMzMDIyMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-04-14T13:44:15Z", "updated_at": "2018-04-14T13:44:15Z", "author_association": "OWNER", "body": "This looks great so far - love the new documentation. Let's throw in a unit test or two for the basic unit filters (mainly as a protection against accidental regressions in the future).", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 314319372, "label": "Support filtering with units and more"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/207#issuecomment-381334973", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/207", "id": 381334973, "node_id": "MDEyOklzc3VlQ29tbWVudDM4MTMzNDk3Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-04-14T14:59:52Z", "updated_at": "2018-04-14T14:59:52Z", "author_association": "OWNER", "body": "I'm going to merge this and then add a unit test.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 314329002, "label": "Link foreign keys which don't have labels"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/205#issuecomment-381336696", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/205", "id": 381336696, "node_id": "MDEyOklzc3VlQ29tbWVudDM4MTMzNjY5Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-04-14T15:24:04Z", "updated_at": "2018-04-14T15:24:04Z", "author_association": "OWNER", "body": "I merged this to master in c857608738d6b6c3e4f3248304a22f8b2648dd3e - thanks @russss!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 314319372, "label": "Support filtering with units and more"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/203#issuecomment-381348849", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/203", "id": 381348849, "node_id": "MDEyOklzc3VlQ29tbWVudDM4MTM0ODg0OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-04-14T18:12:52Z", "updated_at": "2018-04-14T18:12:52Z", "author_association": "OWNER", "body": "I think I'm going to hold on to the custom sql function idea for the moment and implement it as an example plugin.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 313837303, "label": "Support for units"}, "performed_via_github_app": null}