{"html_url": "https://github.com/simonw/datasette/issues/301#issuecomment-407979065", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/301", "id": 407979065, "node_id": "MDEyOklzc3VlQ29tbWVudDQwNzk3OTA2NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-07-26T05:17:34Z", "updated_at": "2018-07-26T05:17:34Z", "author_association": "OWNER", "body": "This code now lives in https://github.com/simonw/datasette/blob/master/datasette/publish/heroku.py", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 328155946, "label": "--spatialite option for \"datasette publish heroku\""}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/217#issuecomment-407980050", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/217", "id": 407980050, "node_id": "MDEyOklzc3VlQ29tbWVudDQwNzk4MDA1MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-07-26T05:24:17Z", "updated_at": "2018-07-26T05:24:17Z", "author_association": "OWNER", "body": "Documentation: http://datasette.readthedocs.io/en/latest/plugins.html#publish-subcommand-publish", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 314725342, "label": "Plugin support for datasette publish"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/349#issuecomment-407980716", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/349", "id": 407980716, "node_id": "MDEyOklzc3VlQ29tbWVudDQwNzk4MDcxNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-07-26T05:28:54Z", "updated_at": "2018-07-26T05:28:54Z", "author_association": "OWNER", "body": "Documentation here: http://datasette.readthedocs.io/en/latest/plugins.html#publish-subcommand-publish\r\n\r\nThe best way to write a new publish plugin is to check out how the Heroku and Now default plugins are implemented: https://github.com/simonw/datasette/tree/master/datasette/publish", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 344695978, "label": "publish_subcommand hook + default plugins mechanism, used for publish heroku/now"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/348#issuecomment-407983375", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/348", "id": 407983375, "node_id": "MDEyOklzc3VlQ29tbWVudDQwNzk4MzM3NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-07-26T05:46:01Z", "updated_at": "2018-07-26T05:46:01Z", "author_association": "OWNER", "body": "Oops, forgot to commit those unit tests.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 344656114, "label": "Unit tests for \"datasette publish\""}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/272#issuecomment-408093480", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/272", "id": 408093480, "node_id": "MDEyOklzc3VlQ29tbWVudDQwODA5MzQ4MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-07-26T13:15:55Z", "updated_at": "2018-07-26T13:46:40Z", "author_association": "OWNER", "body": "I'm now hacking around with an initial version of this in the [starlette branch](https://github.com/simonw/datasette/tree/starlette).\r\n\r\nHere's my work in progress, deployed using `datasette publish now fixtures.db -n datasette-starlette-demo --branch=starlette --extra-options=\"--asgi\"`\r\n\r\nhttps://datasette-starlette-demo.now.sh/\r\n\r\nLots more work to do - the CSS isn't being served correctly for example, it's showing this error when I hit `/-/static/app.css`:\r\n```\r\nINFO: 127.0.0.1 - \"GET /-/static/app.css HTTP/1.1\" 200\r\nERROR: Exception in ASGI application\r\nTraceback (most recent call last):\r\n  File \"/Users/simonw/Dropbox/Development/datasette/venv/lib/python3.6/site-packages/uvicorn/protocols/http/httptools_impl.py\", line 363, in run_asgi\r\n    result = await asgi(self.receive, self.send)\r\n  File \"/Users/simonw/Dropbox/Development/datasette/venv/lib/python3.6/site-packages/starlette/staticfiles.py\", line 91, in __call__\r\n    await response(receive, send)\r\n  File \"/Users/simonw/Dropbox/Development/datasette/venv/lib/python3.6/site-packages/starlette/response.py\", line 180, in __call__\r\n    {\"type\": \"http.response.body\", \"body\": chunk, \"more_body\": False}\r\n  File \"/Users/simonw/Dropbox/Development/datasette/venv/lib/python3.6/site-packages/uvicorn/protocols/http/httptools_impl.py\", line 483, in send\r\n    raise RuntimeError(\"Response content shorter than Content-Length\")\r\nRuntimeError: Response content shorter than Content-Length\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 324188953, "label": "Port Datasette to ASGI"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/272#issuecomment-408097719", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/272", "id": 408097719, "node_id": "MDEyOklzc3VlQ29tbWVudDQwODA5NzcxOQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-07-26T13:29:38Z", "updated_at": "2018-07-26T13:29:38Z", "author_association": "OWNER", "body": "It looks like that's a bug in Starlette - filed here: https://github.com/encode/starlette/issues/32", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 324188953, "label": "Port Datasette to ASGI"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/272#issuecomment-408105251", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/272", "id": 408105251, "node_id": "MDEyOklzc3VlQ29tbWVudDQwODEwNTI1MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-07-26T13:54:06Z", "updated_at": "2018-07-26T13:54:06Z", "author_association": "OWNER", "body": "Tom shipped my fix for that bug already, so https://datasette-starlette-demo.now.sh/ is now serving CSS!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 324188953, "label": "Port Datasette to ASGI"}, "performed_via_github_app": null}