{"html_url": "https://github.com/simonw/datasette/pull/595#issuecomment-541494080", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/595", "id": 541494080, "node_id": "MDEyOklzc3VlQ29tbWVudDU0MTQ5NDA4MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-10-14T03:43:11Z", "updated_at": "2019-10-14T03:43:11Z", "author_association": "OWNER", "body": "Ooh this is tricky... https://travis-ci.org/simonw/datasette/jobs/597216285 failed because it looks like `websockets-8.0.2` isn't compatible with Python 3.5\r\n\r\nThis is a problem. I need to keep Datasette working with 3.5 for compatibility with Glitch. But obviously I also want it to work with 3.8. \r\n\r\nI wonder if there's a smart solution here. @tomchristie any thoughts?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 506300941, "label": "bump uvicorn to 0.9.0 to be Python-3.8 friendly"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/592#issuecomment-541494347", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/592", "id": 541494347, "node_id": "MDEyOklzc3VlQ29tbWVudDU0MTQ5NDM0Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-10-14T03:45:29Z", "updated_at": "2019-10-14T03:45:29Z", "author_association": "OWNER", "body": "This is a really nice implementation. I particularly like how you have the button as hidden until JavaScript runs and makes it visible.\r\n\r\nhttps://github.com/simonw/datasette/pull/592/files#diff-0932659dded7aa3ce2d4c7badb187a9cR6-R8", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 505950145, "label": "Offer SQL formatting"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/590#issuecomment-541495034", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/590", "id": 541495034, "node_id": "MDEyOklzc3VlQ29tbWVudDU0MTQ5NTAzNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-10-14T03:51:32Z", "updated_at": "2019-10-14T03:51:32Z", "author_association": "OWNER", "body": "We need some unit tests for this.\r\n\r\nI'd be fine with us renaming `extra_database.db` to `extra database.py` in these existing fixtures:\r\n\r\nhttps://github.com/simonw/datasette/blob/af2e6a5cf186a7200d76cb67ac30fa59cc24d84e/tests/fixtures.py#L174-L185\r\n\r\nThen we could add an extra `test_database_name_with_spaces(...)` test in `test_api.py` which uses parametrize to exercise a bunch of URLs and check they all return a 200 - something a bit like this but covering a range of URL paths (one for database, table, row and table with filters):\r\n\r\nhttps://github.com/simonw/datasette/blob/90d4f497f9b3f6a5882937c91fddb496ac3e7368/tests/test_api.py#L746-L765", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 505818256, "label": "Handle spaces in DB names"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/591#issuecomment-541495108", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/591", "id": 541495108, "node_id": "MDEyOklzc3VlQ29tbWVudDU0MTQ5NTEwOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-10-14T03:52:09Z", "updated_at": "2019-10-14T03:52:09Z", "author_association": "OWNER", "body": "Neat solution.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 505837199, "label": "Sort databases on homepage by argument order"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/578#issuecomment-541495682", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/578", "id": 541495682, "node_id": "MDEyOklzc3VlQ29tbWVudDU0MTQ5NTY4Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-10-14T03:57:17Z", "updated_at": "2019-10-14T03:57:17Z", "author_association": "OWNER", "body": "So this is a new Docker feature from April 2019? https://engineering.docker.com/2019/04/multi-arch-images/\r\n\r\n> So why buildx?  Let\u2019s first start with the name.  The x stands for experimental.  In the future, when these new build features are stable and made generally available, we will drop the x and integrate these features directly into the existing docker build command.  Note that as buildx is experimental, features and flags are subject to change.\r\n\r\nIs there a strong use-case for supporting this while it's still experimental? Users who want Datasette to run on ARM can build their own image pretty easily, so I'm not sure if it's worth depending on an experimental feature for the core Datasette project.\r\n\r\nIs there any indication from the Docker team as to when this experimental feature might stop being marked as experimental?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 499954048, "label": "Added support for multi arch builds"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/595#issuecomment-541922637", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/595", "id": 541922637, "node_id": "MDEyOklzc3VlQ29tbWVudDU0MTkyMjYzNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-10-14T21:08:19Z", "updated_at": "2019-10-14T21:08:19Z", "author_association": "OWNER", "body": "There more discussion around this on the Glitch forums here: https://support.glitch.com/t/can-you-upgrade-python-to-latest-version/7980", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 506300941, "label": "bump uvicorn to 0.9.0 to be Python-3.8 friendly"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/595#issuecomment-541931047", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/595", "id": 541931047, "node_id": "MDEyOklzc3VlQ29tbWVudDU0MTkzMTA0Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-10-14T21:25:38Z", "updated_at": "2019-10-14T21:25:38Z", "author_association": "OWNER", "body": "I like the conditional dependency for the moment - maybe until 3.5 becomes officially unsupported.", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 506300941, "label": "bump uvicorn to 0.9.0 to be Python-3.8 friendly"}, "performed_via_github_app": null}