{"html_url": "https://github.com/simonw/datasette/pull/1529#issuecomment-977870699", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1529", "id": 977870699, "node_id": "IC_kwDOBm6k_c46SR9r", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2021-11-24T13:18:52Z", "updated_at": "2021-11-30T02:30:46Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1529?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\n> Merging [#1529](https://codecov.io/gh/simonw/datasette/pull/1529?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (2cb3dbb) into [main](https://codecov.io/gh/simonw/datasette/commit/48f11998b73350057b74fe6ab464d4ac3071637c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (48f1199) will **decrease** coverage by `0.06%`.\n> The diff coverage is `n/a`.\n\n> :exclamation: Current head 2cb3dbb differs from pull request most recent head 495b726. Consider uploading reports for the commit 495b726 to get more accurate results\n[![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1529/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1529?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n\n```diff\n@@            Coverage Diff             @@\n##             main    #1529      +/-   ##\n==========================================\n- Coverage   91.90%   91.83%   -0.07%     \n==========================================\n  Files          34       34              \n  Lines        4434     4434              \n==========================================\n- Hits         4075     4072       -3     \n- Misses        359      362       +3     \n```\n\n\n| [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1529?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage \u0394 | |\n|---|---|---|\n| [datasette/views/index.py](https://codecov.io/gh/simonw/datasette/pull/1529/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL2luZGV4LnB5) | `96.42% <0.00%> (-1.79%)` | :arrow_down: |\n| [datasette/database.py](https://codecov.io/gh/simonw/datasette/pull/1529/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2RhdGFiYXNlLnB5) | `92.93% <0.00%> (-0.75%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1529?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n> `\u0394 = absolute <relative> (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1529?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [1beb7d9...495b726](https://codecov.io/gh/simonw/datasette/pull/1529?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1062414013, "label": "Update janus requirement from <0.7,>=0.6.2 to >=0.6.2,<0.8"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1527#issuecomment-982235541", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1527", "id": 982235541, "node_id": "IC_kwDOBm6k_c46i7mV", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-11-30T02:57:34Z", "updated_at": "2021-11-30T02:58:44Z", "author_association": "OWNER", "body": "I started fiddling with a test for this which extracts the `<select>` options and ALL of the `<input>` fields, but I probably won't use it:\r\n```python\r\ndef test_exact_parameter_results_in_correct_hidden_fields(app_client):\r\n    # https://github.com/simonw/datasette/issues/1527\r\n    response = app_client.get(\r\n        \"/fixtures/facetable?_facet=_neighborhood&_neighborhood__exact=Downtown\"\r\n    )\r\n    # In this case we should NOT have a hidden _neighborhood__exact=Downtown field\r\n    form = Soup(response.body, \"html.parser\").find(\"form\")\r\n    selects = [\r\n        {\r\n            \"name\": select[\"name\"],\r\n            \"value\": select.select(\"option[selected]\")[0].text\r\n            if select.select(\"option[selected]\")\r\n            else \"\",\r\n        }\r\n        for select in form.findAll(\"select\")\r\n    ]\r\n    inputs = [input.attrs for input in form.findAll(\"input\")]\r\n    # Turn those both into a {name: (value, type)} array\r\n    form_inputs = {}\r\n    form_inputs.update(\r\n        {select[\"name\"]: (select[\"value\"], \"select\") for select in selects}\r\n    )\r\n    form_inputs.update(\r\n        {\r\n            input[\"name\"]: (input.get(\"value\"), input[\"type\"])\r\n            for input in inputs\r\n            if input.get(\"name\")\r\n        }\r\n    )\r\n    assert form_inputs == {\r\n        \"_filter_column_1\": (\"_neighborhood\", \"select\"),\r\n        \"_filter_op_1\": (\"=\", \"select\"),\r\n        \"_filter_value_1\": (\"Downtown\", \"text\"),\r\n        \"_filter_column\": (\"\", \"select\"),\r\n        \"_filter_op\": (\"\", \"select\"),\r\n        \"_filter_value\": (None, \"text\"),\r\n        \"_sort\": (\"Sort by pk\", \"select\"),\r\n        \"_sort_by_desc\": (None, \"checkbox\"),\r\n        \"_facet\": (\"_neighborhood\", \"hidden\"),\r\n        \"_neighborhood__exact\": (\"Downtown\", \"hidden\"),\r\n    }\r\n```\r\nThe problem is that last hidden field, `_neighborhood__exact=Downtown` - which should not be there.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1059555791, "label": "Columns starting with an underscore behave poorly in filters"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1527#issuecomment-982318745", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1527", "id": 982318745, "node_id": "IC_kwDOBm6k_c46jP6Z", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-11-30T06:11:21Z", "updated_at": "2021-11-30T06:11:21Z", "author_association": "OWNER", "body": "Manually tested this too, looks like that fixed it.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1059555791, "label": "Columns starting with an underscore behave poorly in filters"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1532#issuecomment-982319210", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1532", "id": 982319210, "node_id": "IC_kwDOBm6k_c46jQBq", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-11-30T06:12:19Z", "updated_at": "2021-11-30T06:12:19Z", "author_association": "OWNER", "body": "That's really cool to hear - I've not seen many people actively building on top of the JSON API.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1065429936, "label": "Use datasette-table Web Component to guide the design of the JSON API for 1.0"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1525#issuecomment-982331602", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1525", "id": 982331602, "node_id": "IC_kwDOBm6k_c46jTDS", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-11-30T06:39:00Z", "updated_at": "2021-11-30T06:39:00Z", "author_association": "OWNER", "body": "These two pages now help demonstrate the fix:\r\n\r\n- https://latest.datasette.io/fixtures/facet_cities/1\r\n- https://latest.datasette.io/fixtures/attraction_characteristic/2\r\n\r\nI added a new test for these here:\r\n\r\nhttps://github.com/simonw/datasette/blob/35b12746ba2bf9f254791bddac03d25b19be9b77/tests/test_html.py#L823-L848\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1059509927, "label": "\"Links from other tables\" broken for columns starting with underscore"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1532#issuecomment-982745406", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1532", "id": 982745406, "node_id": "IC_kwDOBm6k_c46k4E-", "user": {"value": 30934, "label": "20after4"}, "created_at": "2021-11-30T15:28:57Z", "updated_at": "2021-11-30T15:28:57Z", "author_association": "NONE", "body": "It's a really great API and the documentation is really great too. Honestly, in more than 20 years of professional experience,  I haven't worked with any software API that was more of a joy to use. ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1065429936, "label": "Use datasette-table Web Component to guide the design of the JSON API for 1.0"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/348#issuecomment-983120066", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/348", "id": 983120066, "node_id": "IC_kwDOCGYnMM46mTjC", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-11-30T23:25:52Z", "updated_at": "2021-11-30T23:26:11Z", "author_association": "OWNER", "body": "Maybe this:\r\n\r\n    sqlite-utils create-database my.db\r\n\r\nWith options that include `--enable-wal` (actually that's the only option I can think of).\r\n\r\nThis is consistent with the existing `create-table` and `create-view` commands.\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1067771698, "label": "Command for creating an empty database"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/348#issuecomment-983122733", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/348", "id": 983122733, "node_id": "IC_kwDOCGYnMM46mUMt", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-11-30T23:31:17Z", "updated_at": "2021-11-30T23:31:17Z", "author_association": "OWNER", "body": "Potential other options could include:\r\n\r\n- `--page-size` https://www.sqlite.org/pragma.html#pragma_page_size", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1067771698, "label": "Command for creating an empty database"}, "performed_via_github_app": null}