{"html_url": "https://github.com/simonw/datasette/issues/1191#issuecomment-761104933", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1191", "id": 761104933, "node_id": "MDEyOklzc3VlQ29tbWVudDc2MTEwNDkzMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-15T18:21:26Z", "updated_at": "2021-12-17T07:03:02Z", "author_association": "OWNER", "body": "Also related: #857 (comprehensive documentation of variables available to templates) - since then the plugin hook could be fed the full template context and use that to do its thing.\r\n\r\nOr maybe the plugin hooks gets to return the name of a template that should be `{% include %}` into the page at that point? But the plugin may want to add extra context that is available to that template include.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 787098345, "label": "Ability for plugins to collaborate when adding extra HTML to blocks in default templates"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1518#issuecomment-981153060", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1518", "id": 981153060, "node_id": "IC_kwDOBm6k_c46ezUk", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-11-28T21:13:09Z", "updated_at": "2021-12-17T23:37:08Z", "author_association": "OWNER", "body": "Two new requirements inspired by work on the `datasette-table` (and `datasette-notebook`) projects:\r\n\r\n- #1533\r\n- #1534", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1058072543, "label": "Complete refactor of TableView and table.html template"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1518#issuecomment-996286104", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1518", "id": 996286104, "node_id": "IC_kwDOBm6k_c47Yh6Y", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T00:00:07Z", "updated_at": "2021-12-17T00:00:07Z", "author_association": "OWNER", "body": "Documentation of the new hook in the PR: https://github.com/simonw/datasette/blob/54e9b3972f277431a001e685f78e5dd6403a6d8d/docs/plugin_hooks.rst#filters_from_requestrequest-database-table-datasette", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1058072543, "label": "Complete refactor of TableView and table.html template"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/473#issuecomment-996286199", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/473", "id": 996286199, "node_id": "IC_kwDOBm6k_c47Yh73", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T00:00:22Z", "updated_at": "2021-12-17T00:00:22Z", "author_association": "OWNER", "body": "Documentation for that hook in the PR branch: https://github.com/simonw/datasette/blob/54e9b3972f277431a001e685f78e5dd6403a6d8d/docs/plugin_hooks.rst#filters_from_requestrequest-database-table-datasette", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 445850934, "label": "Plugin hook: filters_from_request"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1559#issuecomment-996286808", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1559", "id": 996286808, "node_id": "IC_kwDOBm6k_c47YiFY", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T00:01:43Z", "updated_at": "2021-12-17T00:01:43Z", "author_association": "OWNER", "body": "This already has tests and documentation, and I've used it to refactor out the logic for `?_where=` and `?_search=` and `?_through=`.\r\n\r\nDo I like this enough to land it on `main`?\r\n\r\nAlso, I think I can still use it to refactor out the `Filters` code that implements `?col=x` and `?col__lt=5` and suchlike.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1082743068, "label": "filters_from_request plugin hook, now used in TableView"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1559#issuecomment-996289541", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1559", "id": 996289541, "node_id": "IC_kwDOBm6k_c47YiwF", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2021-12-17T00:07:42Z", "updated_at": "2021-12-17T17:28:54Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1559?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\n> Merging [#1559](https://codecov.io/gh/simonw/datasette/pull/1559?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (71af58d) into [main](https://codecov.io/gh/simonw/datasette/commit/0663d5525cc41e9260ac7d1f6386d3a6eb5ad2a9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (0663d55) will **increase** coverage by `0.09%`.\n> The diff coverage is `97.97%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1559/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n\n```diff\n@@ Coverage Diff @@\n## main #1559 +/- ##\n==========================================\n+ Coverage 91.96% 92.05% +0.09% \n==========================================\n Files 34 34 \n Lines 4442 4493 +51 \n==========================================\n+ Hits 4085 4136 +51 \n Misses 357 357 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1559?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage \u0394 | |\n|---|---|---|\n| [datasette/plugins.py](https://codecov.io/gh/simonw/datasette/pull/1559/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3BsdWdpbnMucHk=) | `82.35% <\u00f8> (\u00f8)` | |\n| [datasette/filters.py](https://codecov.io/gh/simonw/datasette/pull/1559/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2ZpbHRlcnMucHk=) | `95.69% <97.67%> (+1.33%)` | :arrow_up: |\n| [datasette/hookspecs.py](https://codecov.io/gh/simonw/datasette/pull/1559/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2hvb2tzcGVjcy5weQ==) | `100.00% <100.00%> (\u00f8)` | |\n| [datasette/views/table.py](https://codecov.io/gh/simonw/datasette/pull/1559/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL3RhYmxlLnB5) | `96.21% <100.00%> (+0.13%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1559?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n> `\u0394 = absolute (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1559?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [0663d55...71af58d](https://codecov.io/gh/simonw/datasette/pull/1559?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1082743068, "label": "filters_from_request plugin hook, now used in TableView"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/473#issuecomment-996345233", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/473", "id": 996345233, "node_id": "IC_kwDOBm6k_c47YwWR", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T01:20:31Z", "updated_at": "2021-12-17T18:13:01Z", "author_association": "OWNER", "body": "I could use this hook to add table filtering on a map to the existing `datasette-leaflet-freedraw` plugin.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 445850934, "label": "Plugin hook: filters_from_request"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/sqlite-utils/issues/358#issuecomment-996482595", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/358", "id": 996482595, "node_id": "IC_kwDOCGYnMM47ZR4j", "user": {"value": 11597658, "label": "luxint"}, "created_at": "2021-12-17T06:57:51Z", "updated_at": "2021-12-17T23:24:16Z", "author_association": "NONE", "body": "> This goes beyond the `transform()` method - the curious methods that create new SQL tables could benefit from the ability to add `CHECK` constraints too.\r\n> \r\n> I haven't used these myself, do you have any `CREATE TABLE` examples that use them that you can share?\r\n\r\nI'm using them myself for the first time as well, this is a tutorial of how to use (and change) them in sqlite: https://www.sqlitetutorial.net/sqlite-check-constraint/", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1082651698, "label": "Support for CHECK constraints"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/473#issuecomment-996484551", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/473", "id": 996484551, "node_id": "IC_kwDOBm6k_c47ZSXH", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T07:02:21Z", "updated_at": "2021-12-17T07:04:23Z", "author_association": "OWNER", "body": "The one slightly weird thing about this hook is how it adds `extra_context` without an obvious way for plugins to add extra HTML to the templates based on that context.\r\n\r\nMaybe I need the proposed mechanism from\r\n- #1191\r\n\r\nWhich has an in-progress PR:\r\n- #1204", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 445850934, "label": "Plugin hook: filters_from_request"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1204#issuecomment-996488925", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1204", "id": 996488925, "node_id": "IC_kwDOBm6k_c47ZTbd", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T07:10:48Z", "updated_at": "2021-12-17T07:10:48Z", "author_association": "OWNER", "body": "I think this is missing the `_macro.html` template file but I have that in my Dropbox.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 793002853, "label": "WIP: Plugin includes"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1562#issuecomment-996716158", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1562", "id": 996716158, "node_id": "IC_kwDOBm6k_c47aK5-", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2021-12-17T13:18:49Z", "updated_at": "2021-12-17T13:18:49Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1562?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\n> Merging [#1562](https://codecov.io/gh/simonw/datasette/pull/1562?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (2f008e8) into [main](https://codecov.io/gh/simonw/datasette/commit/0663d5525cc41e9260ac7d1f6386d3a6eb5ad2a9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (0663d55) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1562/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1562?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n\n```diff\n@@ Coverage Diff @@\n## main #1562 +/- ##\n=======================================\n Coverage 91.96% 91.96% \n=======================================\n Files 34 34 \n Lines 4442 4442 \n=======================================\n Hits 4085 4085 \n Misses 357 357 \n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1562?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n> `\u0394 = absolute (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1562?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [0663d55...2f008e8](https://codecov.io/gh/simonw/datasette/pull/1562?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1083246400, "label": "Update janus requirement from <0.8,>=0.6.2 to >=0.6.2,<1.1"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1559#issuecomment-996895423", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1559", "id": 996895423, "node_id": "IC_kwDOBm6k_c47a2q_", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T17:28:44Z", "updated_at": "2021-12-17T17:28:44Z", "author_association": "OWNER", "body": "Before I land this I'm going to build one prototype plugin against it to confirm that the new hook is useful in its current shape.\r\n\r\nI'll add support for filtering a table by drawing on a map to https://datasette.io/plugins/datasette-leaflet-freedraw", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1082743068, "label": "filters_from_request plugin hook, now used in TableView"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/473#issuecomment-996958442", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/473", "id": 996958442, "node_id": "IC_kwDOBm6k_c47bGDq", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T18:59:27Z", "updated_at": "2021-12-17T18:59:27Z", "author_association": "OWNER", "body": "I'm happy with how the prototype that used this plugin in `datasette-leaflet-freedraw` turned out: https://github.com/simonw/datasette-leaflet-freedraw/blob/e8a16a0fe90656b8d655c02881d23a2b9833281d/datasette_leaflet_freedraw/__init__.py", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 445850934, "label": "Plugin hook: filters_from_request"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1559#issuecomment-996959325", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1559", "id": 996959325, "node_id": "IC_kwDOBm6k_c47bGRd", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T18:59:54Z", "updated_at": "2021-12-17T18:59:54Z", "author_association": "OWNER", "body": "I've convinced myself that this plugin hook design is good through this `datasette-leaflet-freedraw` prototype: https://github.com/simonw/datasette-leaflet-freedraw/blob/e8a16a0fe90656b8d655c02881d23a2b9833281d/datasette_leaflet_freedraw/__init__.py", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1082743068, "label": "filters_from_request plugin hook, now used in TableView"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1559#issuecomment-996961196", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1559", "id": 996961196, "node_id": "IC_kwDOBm6k_c47bGus", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T19:00:53Z", "updated_at": "2021-12-17T19:00:53Z", "author_association": "OWNER", "body": "I'm going to merge this to `main` now. I can continue the refactoring there, but having it in `main` means I can put out an alpha release with the new hook which will unblock me from running tests against it in this repo: https://github.com/simonw/datasette-leaflet-freedraw/pull/8", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1082743068, "label": "filters_from_request plugin hook, now used in TableView"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1565#issuecomment-997069128", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1565", "id": 997069128, "node_id": "IC_kwDOBm6k_c47bhFI", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T22:31:18Z", "updated_at": "2021-12-17T22:31:18Z", "author_association": "OWNER", "body": "This should aim to be as consistent as possible with the various arguments to hooks on https://docs.datasette.io/en/stable/plugin_hooks.html", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1083657868, "label": "Documented JavaScript variables on different templates made available for plugins"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1565#issuecomment-997077410", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1565", "id": 997077410, "node_id": "IC_kwDOBm6k_c47bjGi", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T22:54:45Z", "updated_at": "2021-12-17T22:54:45Z", "author_association": "OWNER", "body": "The table page should expose the query both with and without the `limit` clause. The above gave me back:\r\n\r\n```sql\r\nselect id, ACCESS_TYP, UNIT_ID, UNIT_NAME, SUID_NMA, AGNCY_ID, AGNCY_NAME, AGNCY_LEV,\r\n AGNCY_TYP, AGNCY_WEB, LAYER, MNG_AG_ID, MNG_AGENCY, MNG_AG_LEV, MNG_AG_TYP,\r\n PARK_URL, COUNTY, ACRES, LABEL_NAME, YR_EST, DES_TP, GAP_STS, geometry\r\nfrom CPAD_2020a_Units where \"AGNCY_LEV\" = :p0 order by id limit 101\r\n```\r\nBut I actually wanted to run a `fetch()` against a version of that without the `order by id limit 101` bit (I wanted to figure out the `Extent()` of the `geometry` column) - so I need something like `datasette.table_sql_no_order_no_limit`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1083657868, "label": "Documented JavaScript variables on different templates made available for plugins"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1566#issuecomment-997078812", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1566", "id": 997078812, "node_id": "IC_kwDOBm6k_c47bjcc", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T22:58:55Z", "updated_at": "2021-12-17T22:58:55Z", "author_association": "OWNER", "body": "The release notes for the 0.60a0 alpha will be useful here: https://github.com/simonw/datasette/releases/tag/0.60a0", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1083669410, "label": "Release Datasette 0.60"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1562#issuecomment-997080352", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1562", "id": 997080352, "node_id": "IC_kwDOBm6k_c47bj0g", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T23:03:08Z", "updated_at": "2021-12-17T23:03:08Z", "author_association": "OWNER", "body": "They say they've dropped 3.6 support, but Datasette's tests against 3.6 are still passing.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1083246400, "label": "Update janus requirement from <0.8,>=0.6.2 to >=0.6.2,<1.1"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1562#issuecomment-997081673", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1562", "id": 997081673, "node_id": "IC_kwDOBm6k_c47bkJJ", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T23:06:38Z", "updated_at": "2021-12-17T23:06:38Z", "author_association": "OWNER", "body": "From this diff between `0.7.0` and `1.0`: https://github.com/aio-libs/janus/compare/v0.7.0...v1.0.0\r\n\r\nIt looks like the only change relevant to compatibility is `loop = asyncio.get_running_loop()` directly instead of falling back to `asyncio.get_event_loop()` if `get_running_loop` isn't available.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1083246400, "label": "Update janus requirement from <0.8,>=0.6.2 to >=0.6.2,<1.1"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1562#issuecomment-997082189", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1562", "id": 997082189, "node_id": "IC_kwDOBm6k_c47bkRN", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T23:08:14Z", "updated_at": "2021-12-17T23:08:14Z", "author_association": "OWNER", "body": "Oh that makes sense: In Python 3.6 this happens:\r\n```\r\nCollecting janus<1.1,>=0.6.2\r\n Using cached janus-0.7.0-py3-none-any.whl (6.9 kB)\r\n```\r\nWhile in Python 3.7 or higher this happens:\r\n```\r\nCollecting janus<1.1,>=0.6.2\r\n Downloading janus-1.0.0-py3-none-any.whl (6.9 kB)\r\n```\r\nSo this is safe to apply because `pip` is smart enough to pick the version of Janus that works for that Python version.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1083246400, "label": "Update janus requirement from <0.8,>=0.6.2 to >=0.6.2,<1.1"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1559#issuecomment-997082676", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1559", "id": 997082676, "node_id": "IC_kwDOBm6k_c47bkY0", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T23:09:41Z", "updated_at": "2021-12-17T23:09:41Z", "author_association": "OWNER", "body": "This is now available to try out in Datasette 0.60a0: https://github.com/simonw/datasette/releases/tag/0.60a0", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1082743068, "label": "filters_from_request plugin hook, now used in TableView"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1518#issuecomment-997082845", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1518", "id": 997082845, "node_id": "IC_kwDOBm6k_c47bkbd", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-17T23:10:09Z", "updated_at": "2021-12-17T23:10:17Z", "author_association": "OWNER", "body": "These changes so far are now in the 0.60a0 alpha: https://github.com/simonw/datasette/releases/tag/0.60a0", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1058072543, "label": "Complete refactor of TableView and table.html template"}, "performed_via_github_app": null}