{"html_url": "https://github.com/simonw/datasette/issues/2059#issuecomment-1506174353", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2059", "id": 1506174353, "node_id": "IC_kwDOBm6k_c5ZxmWR", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-04-13T01:13:00Z", "updated_at": "2023-04-13T01:13:00Z", "author_association": "OWNER", "body": "Can you provide a URL to an example, and/or a screenshot of this? Is it a browser warning or is it a warning from Heroku itself?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1665053646, "label": "\"Deceptive site ahead\" alert on Heroku deployment"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/2056#issuecomment-1506175208", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2056", "id": 1506175208, "node_id": "IC_kwDOBm6k_c5Zxmjo", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-04-13T01:14:13Z", "updated_at": "2023-04-13T01:14:13Z", "author_association": "OWNER", "body": "https://github.com/simonw/datasette/actions/runs/4664796647/jobs/8300596121?pr=2056 it's pretty fast - that finished in 9s.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1661860507, "label": "GitHub Action to lint Python code with ruff"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/2056#issuecomment-1506177115", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2056", "id": 1506177115, "node_id": "IC_kwDOBm6k_c5ZxnBb", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-04-13T01:17:16Z", "updated_at": "2023-04-13T01:17:16Z", "author_association": "OWNER", "body": "Here are the failures: https://github.com/simonw/datasette/actions/runs/4684460653/jobs/8300630794?pr=2056\r\n\r\n\"CleanShot\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1661860507, "label": "GitHub Action to lint Python code with ruff"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/2056#issuecomment-1506177857", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2056", "id": 1506177857, "node_id": "IC_kwDOBm6k_c5ZxnNB", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-04-13T01:18:18Z", "updated_at": "2023-04-13T01:18:18Z", "author_association": "OWNER", "body": "Cool - and now https://github.com/simonw/datasette/pull/2056/files is showing me those inline annotations:\r\n\r\n\"image\"\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1661860507, "label": "GitHub Action to lint Python code with ruff"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/2056#issuecomment-1506179555", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2056", "id": 1506179555, "node_id": "IC_kwDOBm6k_c5Zxnnj", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-04-13T01:21:05Z", "updated_at": "2023-04-13T01:22:08Z", "author_association": "OWNER", "body": "OK, I'm sold - this is a really neat improvement.\r\n\r\nOne thing to change in the PR: right now it runs `pip install --user ruff` on every commit, which hits PyPI to install the package.\r\n\r\nI prefer to avoid hitting PyPI every time, so I like to use the GitHub Actions cache. My usual pattern for that looks like this:\r\n\r\nhttps://github.com/simonw/datasette/blob/5890a20c374fb0812d88c9b0ef26a838bfa06c76/.github/workflows/test-pyodide.yml#L16-L20\r\n\r\nThen a separate command that runs `pip install ...` will benefit from that cache.\r\n\r\nAre you OK to make that change?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1661860507, "label": "GitHub Action to lint Python code with ruff"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/sqlite-utils/issues/527#issuecomment-1506223848", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/527", "id": 1506223848, "node_id": "IC_kwDOCGYnMM5Zxybo", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-04-13T02:08:16Z", "updated_at": "2023-04-13T02:08:16Z", "author_association": "OWNER", "body": "I agree, this is a design flaw.\r\n\r\nIt's technically a breaking change. As such, I would need to bump to v4 to responsibly release this.\r\n\r\nI'd rather bundle in a few more breaking changes before shipping that version.\r\n\r\nOne thing we could do here is add an extra argument to `.convert()` - something like this:\r\n\r\n```python\r\ntable.convert(col, lambda x: x+1, skip_false=False)\r\n```\r\n\r\nThis would trigger the new, improved behaviour without breaking existing code that depends on how it works at the moment.\r\n\r\nThen in `sqlite-utils` 4 we can change the default of that option.\r\n\r\nWhat do you think?\r\n\r\n(I'm open to suggestions for better names for this parameter too)", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1578790070, "label": "`Table.convert()` skips falsey values"}, "performed_via_github_app": null}