{"html_url": "https://github.com/simonw/datasette/issues/1054#issuecomment-717050585", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1054", "id": 717050585, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNzA1MDU4NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-27T07:38:50Z", "updated_at": "2020-10-27T07:38:50Z", "author_association": "OWNER", "body": "Maybe imitate how Django does this, e.g. https://github.com/django/django/commit/6b9b2af7352908d40ca4d31bdb1b80c013cab29a", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 730199464, "label": "Switch from versioneer to concrete version in setup.py"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1054#issuecomment-717051707", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1054", "id": 717051707, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNzA1MTcwNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-27T07:41:21Z", "updated_at": "2020-10-27T07:41:21Z", "author_association": "OWNER", "body": "Essentially it's this problem: https://github.com/python-versioneer/python-versioneer/issues/140", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 730199464, "label": "Switch from versioneer to concrete version in setup.py"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/sqlite-utils/pull/189#issuecomment-717359145", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/189", "id": 717359145, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNzM1OTE0NQ==", "user": {"value": 35681, "label": "adamwolf"}, "created_at": "2020-10-27T16:20:32Z", "updated_at": "2020-10-27T16:20:32Z", "author_association": "CONTRIBUTOR", "body": "No problem. I added a test. Let me know if it looks sufficient or if you want me to to tweak something!\r\n\r\nIf you don't mind, would you tag this PR as \"hacktoberfest-accepted\"? If you do mind, no problem and I'm sorry for asking :) My kiddos like the shirts.", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 729818242, "label": "Allow iterables other than Lists in m2m records"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/sqlite-utils/pull/189#issuecomment-717361487", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/189", "id": 717361487, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNzM2MTQ4Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-27T16:24:04Z", "updated_at": "2020-10-27T16:24:04Z", "author_association": "OWNER", "body": "This is great, thank you very much.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 729818242, "label": "Allow iterables other than Lists in m2m records"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1056#issuecomment-717489501", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1056", "id": 717489501, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNzQ4OTUwMQ==", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2020-10-27T19:39:41Z", "updated_at": "2020-10-27T19:39:41Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1056?src=pr&el=h1) Report\n> Merging [#1056](https://codecov.io/gh/simonw/datasette/pull/1056?src=pr&el=desc) into [main](https://codecov.io/gh/simonw/datasette/commit/26bb4a268127da2c38f4241abe45444b2a6f7874?el=desc) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1056/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1)](https://codecov.io/gh/simonw/datasette/pull/1056?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## main #1056 +/- ##\n=======================================\n Coverage 84.70% 84.70% \n=======================================\n Files 28 28 \n Lines 3955 3955 \n=======================================\n Hits 3350 3350 \n Misses 605 605 \n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1056?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `\u0394 = absolute (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1056?src=pr&el=footer). Last update [26bb4a2...a7b2aab](https://codecov.io/gh/simonw/datasette/pull/1056?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 730752399, "label": "Radical new colour scheme and base styles, courtesy of @natbat"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1058#issuecomment-717527606", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1058", "id": 717527606, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNzUyNzYwNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-27T20:44:06Z", "updated_at": "2020-10-27T20:44:06Z", "author_association": "OWNER", "body": "Example: https://github.com/simonw/datasette/blob/5a1519796037105bc20bcf2f91a76e022926c204/datasette/views/database.py#L26-L32", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 730802994, "label": "Database download should implement cascading permissions"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1057#issuecomment-717531272", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1057", "id": 717531272, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNzUzMTI3Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-27T20:51:09Z", "updated_at": "2020-10-27T20:51:09Z", "author_association": "OWNER", "body": "That works!\r\n\r\n\"Banners_and_Alerts_and_SQLite___Mike_Bostock___Observable\"\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 730797787, "label": "--cors should enable /fixtures.db CORS access"}, "performed_via_github_app": null}