{"html_url": "https://github.com/simonw/datasette/issues/1715#issuecomment-1108875068", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1715", "id": 1108875068, "node_id": "IC_kwDOBm6k_c5CGBc8", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-04-25T18:03:13Z", "updated_at": "2022-04-25T18:06:33Z", "author_association": "OWNER", "body": "The `RowTableShared` class is making this a whole lot more complicated.\r\n\r\nI'm going to split the `RowView` view out into an entirely separate `views/row.py` module.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1212823665, "label": "Refactor TableView to use asyncinject"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1715#issuecomment-1108877454", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1715", "id": 1108877454, "node_id": "IC_kwDOBm6k_c5CGCCO", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-04-25T18:04:27Z", "updated_at": "2022-04-25T18:04:27Z", "author_association": "OWNER", "body": "Pushed my WIP on this to the `api-extras` branch: 5053f1ea83194ecb0a5693ad5dada5b25bf0f7e6", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1212823665, "label": "Refactor TableView to use asyncinject"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1719#issuecomment-1108884171", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1719", "id": 1108884171, "node_id": "IC_kwDOBm6k_c5CGDrL", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-04-25T18:10:46Z", "updated_at": "2022-04-25T18:12:45Z", "author_association": "OWNER", "body": "It looks like the only class method from that shared class needed  by `RowView` is `self.display_columns_and_rows()`.\r\n\r\nWhich I've been wanting to refactor to provide to `QueryView` too:\r\n\r\n- #715", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1214859703, "label": "Refactor `RowView` and remove `RowTableShared`"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1719#issuecomment-1108888494", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1719", "id": 1108888494, "node_id": "IC_kwDOBm6k_c5CGEuu", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-04-25T18:15:42Z", "updated_at": "2022-04-25T18:15:42Z", "author_association": "OWNER", "body": "Here's an undocumented feature I forgot existed: https://latest.datasette.io/fixtures/simple_primary_key/1.json?_extras=foreign_key_tables\r\n\r\n`?_extras=foreign_key_tables`\r\n\r\nhttps://github.com/simonw/datasette/blob/0bc5186b7bb4fc82392df08f99a9132f84dcb331/datasette/views/table.py#L1021-L1024\r\n\r\nIt's even covered by the tests:\r\n\r\nhttps://github.com/simonw/datasette/blob/b9c2b1cfc8692b9700416db98721fa3ec982f6be/tests/test_api.py#L691-L703", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1214859703, "label": "Refactor `RowView` and remove `RowTableShared`"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/262#issuecomment-1108890170", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/262", "id": 1108890170, "node_id": "IC_kwDOBm6k_c5CGFI6", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-04-25T18:17:09Z", "updated_at": "2022-04-25T18:18:39Z", "author_association": "OWNER", "body": "I spotted in https://github.com/simonw/datasette/issues/1719#issuecomment-1108888494 that there's actually already an undocumented implementation of `?_extras=foreign_key_tables` - https://latest.datasette.io/fixtures/simple_primary_key/1.json?_extras=foreign_key_tables\r\n\r\nI added that feature all the way back in November 2017! https://github.com/simonw/datasette/commit/a30c5b220c15360d575e94b0e67f3255e120b916", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 323658641, "label": "Add ?_extra= mechanism for requesting extra properties in JSON"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1719#issuecomment-1108907238", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1719", "id": 1108907238, "node_id": "IC_kwDOBm6k_c5CGJTm", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-04-25T18:34:21Z", "updated_at": "2022-04-25T18:34:21Z", "author_association": "OWNER", "body": "Well this refactor turned out to be pretty quick and really does greatly simplify both the `RowView` and `TableView` classes. Very happy with this.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1214859703, "label": "Refactor `RowView` and remove `RowTableShared`"}, "performed_via_github_app": null}