{"html_url": "https://github.com/simonw/sqlite-utils/issues/343#issuecomment-1055991226", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/343", "id": 1055991226, "node_id": "IC_kwDOCGYnMM4-8SW6", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-02T00:03:47Z", "updated_at": "2022-03-02T00:03:47Z", "author_association": "OWNER", "body": "Oops, broke mypy:\r\n\r\n```\r\nsqlite_utils/db.py:2600: error: Incompatible default for argument \"hash_id_columns\" (default has type \"Default\", argument has type \"Optional[Iterable[str]]\")\r\nFound 1 error in 1 file (checked 49 source files)\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1063388037, "label": "Provide function to generate hash_id from specified columns"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/343#issuecomment-1055992544", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/343", "id": 1055992544, "node_id": "IC_kwDOCGYnMM4-8Srg", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-02T00:06:10Z", "updated_at": "2022-03-02T00:06:10Z", "author_association": "OWNER", "body": "Updated documentation: https://sqlite-utils.datasette.io/en/latest/python-api.html#setting-an-id-based-on-the-hash-of-the-row-contents\r\n\r\nDocumentation for the renamed `utils.hash_record()` function: https://sqlite-utils.datasette.io/en/latest/reference.html#sqlite-utils-utils-hash-record", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1063388037, "label": "Provide function to generate hash_id from specified columns"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/408#issuecomment-1055993700", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/408", "id": 1055993700, "node_id": "IC_kwDOCGYnMM4-8S9k", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-02T00:08:10Z", "updated_at": "2022-03-02T00:08:10Z", "author_association": "OWNER", "body": "I thought I'd made it so `deterministic=True` would be silently ignored in environments that don't support it, but clearly I missed a case here!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1145882578, "label": "`deterministic=True` fails on versions of SQLite prior to 3.8.3"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/408#issuecomment-1055995100", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/408", "id": 1055995100, "node_id": "IC_kwDOCGYnMM4-8TTc", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-02T00:10:41Z", "updated_at": "2022-03-02T00:10:41Z", "author_association": "OWNER", "body": "Here's the code in question:\r\n\r\nhttps://github.com/simonw/sqlite-utils/blob/521921b849003ed3742338f76f9d47ff3d95eaf3/sqlite_utils/db.py#L384-L394\r\n\r\nIt's checking for Python 3.8, because that's the version of Python that added the `deterministic=True` option: https://docs.python.org/3/library/sqlite3.html#sqlite3.Connection.create_function\r\n\r\nBut from your error message it looks like it should be checking the SQLite version too.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1145882578, "label": "`deterministic=True` fails on versions of SQLite prior to 3.8.3"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/408#issuecomment-1055996626", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/408", "id": 1055996626, "node_id": "IC_kwDOCGYnMM4-8TrS", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-02T00:12:21Z", "updated_at": "2022-03-02T00:12:21Z", "author_association": "OWNER", "body": "Here's the SQLite changelog mentioning that it was added in 3.8.3: https://www.sqlite.org/changes.html#version_3_8_3", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1145882578, "label": "`deterministic=True` fails on versions of SQLite prior to 3.8.3"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/408#issuecomment-1056001414", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/408", "id": 1056001414, "node_id": "IC_kwDOCGYnMM4-8U2G", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-03-02T00:20:26Z", "updated_at": "2022-03-02T00:20:26Z", "author_association": "OWNER", "body": "I need a `db.sqlite_version` property to implement this check.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1145882578, "label": "`deterministic=True` fails on versions of SQLite prior to 3.8.3"}, "performed_via_github_app": null}