{"html_url": "https://github.com/simonw/datasette/issues/1980#issuecomment-1375061747", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1980", "id": 1375061747, "node_id": "IC_kwDOBm6k_c5R9cbz", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-01-09T03:22:36Z", "updated_at": "2023-01-09T03:22:36Z", "author_association": "OWNER", "body": "The problem here is that the HTML ended up with this HTML in it:\r\n```html\r\n                <select name=\"_sort\" id=\"sort_by\">\r\n                    <option value=\"\">Sort...</option>\r\n                            <option value=\"id\" selected>Sort by id</option>\r\n```\r\nBut `id` is not a valid sort option any more.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1524867951, "label": "\"Cannot sort table by id\" when sortable_columns is used"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1980#issuecomment-1375062405", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1980", "id": 1375062405, "node_id": "IC_kwDOBm6k_c5R9cmF", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-01-09T03:23:53Z", "updated_at": "2023-01-09T03:23:53Z", "author_association": "OWNER", "body": "Some potential solutions:\r\n- Make it so the primary key is _always_ sortable - not a bad idea, the `sortable_columns` thing was designed to protect against sorting GIANT tables by a non-indexed column, and the primary key always has an index\r\n- Make sure that `<select>` menu never includes keys that cannot be sorted - this would be a good fix anyway.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1524867951, "label": "\"Cannot sort table by id\" when sortable_columns is used"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1981#issuecomment-1375142205", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1981", "id": 1375142205, "node_id": "IC_kwDOBm6k_c5R9wE9", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-01-09T06:05:44Z", "updated_at": "2023-01-09T06:05:44Z", "author_association": "OWNER", "body": "I want the labels to take as much space as they need, but line up with each other.\r\n\r\nIf they are more than half the width of the page then the form fields should break to another line.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1524983536, "label": "Canned query field labels truncated"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1977#issuecomment-1375596856", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1977", "id": 1375596856, "node_id": "IC_kwDOBm6k_c5R_fE4", "user": {"value": 49699333, "label": "dependabot[bot]"}, "created_at": "2023-01-09T13:06:14Z", "updated_at": "2023-01-09T13:06:14Z", "author_association": "CONTRIBUTOR", "body": "Superseded by #1982.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1522552817, "label": "Bump sphinx from 5.3.0 to 6.1.1"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1978#issuecomment-1375708725", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1978", "id": 1375708725, "node_id": "IC_kwDOBm6k_c5R_6Y1", "user": {"value": 25778, "label": "eyeseast"}, "created_at": "2023-01-09T14:30:00Z", "updated_at": "2023-01-09T14:30:00Z", "author_association": "CONTRIBUTOR", "body": "Totally missed that issue. I can close this as a duplicate.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1522778923, "label": "Document datasette.urls.row and row_blob"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1983#issuecomment-1375795441", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1983", "id": 1375795441, "node_id": "IC_kwDOBm6k_c5SAPjx", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-01-09T15:27:53Z", "updated_at": "2023-01-09T15:27:53Z", "author_association": "OWNER", "body": "https://github.com/simonw/datasette/blob/7b48664d751e59222c01c97a2739d53d6363bdda/datasette/utils/__init__.py#L163-L178", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1525815985, "label": "Make CustomJSONEncoder a documented public API"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1983#issuecomment-1375797856", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1983", "id": 1375797856, "node_id": "IC_kwDOBm6k_c5SAQJg", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-01-09T15:29:34Z", "updated_at": "2023-01-09T15:29:34Z", "author_association": "OWNER", "body": "I had forgotten this had special handling for cursors!\r\n\r\nThe default representation of a row as a tuple rather than a dictionary might not be the right thing to do based on:\r\n- #782 ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1525815985, "label": "Make CustomJSONEncoder a documented public API"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1558#issuecomment-1375800361", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1558", "id": 1375800361, "node_id": "IC_kwDOBm6k_c5SAQwp", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-01-09T15:31:17Z", "updated_at": "2023-01-09T15:31:17Z", "author_association": "OWNER", "body": "Related:\r\n- #782 ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1082584499, "label": "Redesign `facet_results` JSON structure prior to Datasette 1.0"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/979#issuecomment-1375801928", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/979", "id": 1375801928, "node_id": "IC_kwDOBm6k_c5SARJI", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-01-09T15:32:22Z", "updated_at": "2023-01-09T15:32:22Z", "author_association": "OWNER", "body": "This will not be part of the new default JSON design. It will be handled by an ?_extra instead.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 710650633, "label": "Default table view JSON should include CREATE TABLE"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1983#issuecomment-1375810027", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1983", "id": 1375810027, "node_id": "IC_kwDOBm6k_c5SATHr", "user": {"value": 25778, "label": "eyeseast"}, "created_at": "2023-01-09T15:35:58Z", "updated_at": "2023-01-09T15:35:58Z", "author_association": "CONTRIBUTOR", "body": "Yes please, and thank you. I realized I was maybe getting myself in trouble using that, but I think it's a good way to standardize JSON handling.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1525815985, "label": "Make CustomJSONEncoder a documented public API"}, "performed_via_github_app": null}