{"html_url": "https://github.com/simonw/datasette/pull/1999#issuecomment-1463021383", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1999", "id": 1463021383, "node_id": "IC_kwDOBm6k_c5XM-9H", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-03-10T00:12:50Z", "updated_at": "2023-03-10T00:12:50Z", "author_association": "OWNER", "body": "Now at 34 failed, 34 passed.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1551694938, "label": "?_extra= support (draft)"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1999#issuecomment-1463022397", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1999", "id": 1463022397, "node_id": "IC_kwDOBm6k_c5XM_M9", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-03-10T00:14:21Z", "updated_at": "2023-03-10T00:14:21Z", "author_association": "OWNER", "body": "Ironically the thing I most need right now is comprehensive documentation of what variables are being passed to the templates!\r\n\r\nOne big challenge is that I need to untangle the template context that happens in `BaseView` - I'm hacking that together at the moment, but I need a real answer for how that should work in a world in which view functions aren't using that base class.\r\n\r\nhttps://github.com/simonw/datasette/blob/56b0758a5fbf85d01ff80a40c9b028469d7bb65f/datasette/views/base.py#L110-L145", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1551694938, "label": "?_extra= support (draft)"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1999#issuecomment-1463023674", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1999", "id": 1463023674, "node_id": "IC_kwDOBm6k_c5XM_g6", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-03-10T00:16:03Z", "updated_at": "2023-03-10T00:16:03Z", "author_association": "OWNER", "body": "I also need to figure out the `renderers` stuff, so I can link to the right URLs for CSV and JSON and other formats:\r\n\r\nhttps://github.com/simonw/datasette/blob/6d07a7da1531cd749844fc6827d9a1e57009b2ea/datasette/views/base.py#L474-L518", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1551694938, "label": "?_extra= support (draft)"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1999#issuecomment-1463024951", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1999", "id": 1463024951, "node_id": "IC_kwDOBm6k_c5XM_03", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-03-10T00:17:58Z", "updated_at": "2023-03-10T00:17:58Z", "author_association": "OWNER", "body": "Renderers have an impact on three different pages: query results, table page and row page.\r\n\r\nThe row page feature is incomplete though:\r\n\r\nhttps://congress-legislators.datasettes.com/legislators/social_media/A000055\r\n\r\n\"image\"\r\n\r\nWhy is there no `.csv` link there?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1551694938, "label": "?_extra= support (draft)"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/2038#issuecomment-1463110978", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2038", "id": 1463110978, "node_id": "IC_kwDOBm6k_c5XNU1C", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-03-10T02:09:41Z", "updated_at": "2023-03-10T02:09:41Z", "author_association": "OWNER", "body": "I'm torn on this. It's useful for me right now for refactoring, but I feel like it should be a permanent thing, not a setting - or it should default to on and people should turn it off, but who would ever do that?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1618249044, "label": "Consider a `strict_templates` setting"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/2038#issuecomment-1463112173", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2038", "id": 1463112173, "node_id": "IC_kwDOBm6k_c5XNVHt", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-03-10T02:11:06Z", "updated_at": "2023-03-10T02:11:06Z", "author_association": "OWNER", "body": "Here's an example of something that would break:\r\n\r\nhttps://github.com/simonw/datasette/blob/56b0758a5fbf85d01ff80a40c9b028469d7bb65f/datasette/templates/database.html#L12-L15\r\n\r\nBecause `metadata` is an empty dictionary sometimes, so `{{ metadata.title or database }}` would raise an error and need to be replaced by `{{ metadata.get(\"title\") or database }}`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1618249044, "label": "Consider a `strict_templates` setting"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1999#issuecomment-1463113856", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1999", "id": 1463113856, "node_id": "IC_kwDOBm6k_c5XNViA", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-03-10T02:13:15Z", "updated_at": "2023-03-10T02:13:15Z", "author_association": "OWNER", "body": "Idea for if this change ends up making a bunch of breaking changes to the templates (which I think it should) - I can generate a GitHub diff link between the old and new templates and include that link in the 1.0 upgrade documentation to help people who wrote custom templates see what they might need to change - with minimal effort from myself to document those changes.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1551694938, "label": "?_extra= support (draft)"}, "performed_via_github_app": null}