{"html_url": "https://github.com/dogsheep/github-to-sqlite/issues/79#issuecomment-1498167714", "issue_url": "https://api.github.com/repos/dogsheep/github-to-sqlite/issues/79", "id": 1498167714, "node_id": "IC_kwDODFdgUs5ZTDmi", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-04-05T21:12:55Z", "updated_at": "2023-04-05T21:12:55Z", "author_association": "MEMBER", "body": "It's a rate limiting problem: https://github.com/dogsheep/github-to-sqlite/actions/runs/4622674009/jobs/8175633155\r\n\r\n```\r\n  File \"/home/runner/work/github-to-sqlite/github-to-sqlite/github_to_sqlite/cli.py\", line 407, in commits\r\n    utils.save_commits(db, commits, repo_full[\"id\"])\r\n  File \"/home/runner/work/github-to-sqlite/github-to-sqlite/github_to_sqlite/utils.py\", line 635, in save_commits\r\n    for commit in commits:\r\n  File \"/home/runner/work/github-to-sqlite/github-to-sqlite/github_to_sqlite/utils.py\", line 417, in fetch_commits\r\n    for commits in paginate(url, headers):\r\n  File \"/home/runner/work/github-to-sqlite/github-to-sqlite/github_to_sqlite/utils.py\", line 478, in paginate\r\n    raise GitHubError.from_response(response)\r\ngithub_to_sqlite.utils.GitHubError: ('API rate limit exceeded for user ID 9599.', 403)\r\nError: Process completed with exit code 1.\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1570375808, "label": "Deploy demo job is failing due to rate limit"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/2049#issuecomment-1498275621", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2049", "id": 1498275621, "node_id": "IC_kwDOBm6k_c5ZTd8l", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-04-05T23:23:01Z", "updated_at": "2023-04-05T23:23:01Z", "author_association": "OWNER", "body": "The default representation here can be even smaller.\r\n\r\nFor rows it's this:\r\n\r\n```json\r\n{\r\n  \"ok\": true,\r\n  \"next\": \"d,v\",\r\n  \"rows\": [...]\r\n}\r\n```\r\nFor SQL queries I'm considering this:\r\n```json\r\n{\r\n  \"ok\": true,\r\n  \"rows\": [...]\r\n}\r\n```\r\nI considered adding `\"sql\"` and `\"params\"` too, but on further thought those would be entirely a waste of bytes the majority of the time. If a user wants those they can request them with an `?_extra=query` as seen here:\r\n\r\nhttp://localhost:8001/content/releases.json?_size=0&_extra=query\r\n\r\n```json\r\n{\r\n  \"ok\": true,\r\n  \"next\": null,\r\n  \"query\": {\r\n    \"sql\": \"select html_url, id, author, node_id, tag_name, target_commitish, name, draft, prerelease, created_at, published_at, body, repo, reactions, mentions_count from releases order by id limit 1\",\r\n    \"params\": {}\r\n  },\r\n  \"rows\": []\r\n}\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1646734246, "label": "Custom SQL queries should use new JSON ?_extra= format"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/2053#issuecomment-1498279469", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2053", "id": 1498279469, "node_id": "IC_kwDOBm6k_c5ZTe4t", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-04-05T23:28:53Z", "updated_at": "2023-04-05T23:28:53Z", "author_association": "OWNER", "body": "Table errors page currently does this:\r\n```json\r\n{\r\n  \"ok\": false,\r\n  \"error\": \"no such column: blah\",\r\n  \"status\": 400,\r\n  \"title\": \"Invalid SQL\"\r\n}\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1656432059, "label": "WIP new JSON for queries"}, "performed_via_github_app": null}