{"html_url": "https://github.com/simonw/datasette/issues/332#issuecomment-405968983", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/332", "id": 405968983, "node_id": "MDEyOklzc3VlQ29tbWVudDQwNTk2ODk4Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-07-18T15:18:57Z", "updated_at": "2018-07-18T15:18:57Z", "author_association": "OWNER", "body": "Maybe argument should be `?_json_nan=1` since that makes it more explicitly obvious what is going on here.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 337141108, "label": "Sanely handle Infinity/-Infinity values in JSON using ?_json_infinity=1"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/308#issuecomment-405971920", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/308", "id": 405971920, "node_id": "MDEyOklzc3VlQ29tbWVudDQwNTk3MTkyMA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-07-18T15:27:12Z", "updated_at": "2018-07-18T15:27:12Z", "author_association": "OWNER", "body": "It looks like there are a few extra options we should support:\r\n\r\nhttps://devcenter.heroku.com/articles/heroku-cli-commands\r\n\r\n```\r\n  -t, --team=team            team to use\r\n  --region=region            specify region for the app to run in\r\n  --space=space              the private space to create the app in\r\n```\r\n\r\nSince these differ from the options for Zeit Now I think this means splitting up `datasette publish now` and `datasette publish Heroku` into separate subcommands.", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 330826972, "label": "Support extra Heroku apps:create options - region, space, team"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/333#issuecomment-405975025", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/333", "id": 405975025, "node_id": "MDEyOklzc3VlQ29tbWVudDQwNTk3NTAyNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-07-18T15:36:11Z", "updated_at": "2018-07-18T15:40:04Z", "author_association": "OWNER", "body": "A `force_https_api_urls` config option would work here - if set, Datasette will ignore the incoming protocol and always use https. The `datasette deploy now` command could then add that as an option passed to `datasette serve`.\r\n\r\nThis is the pattern which is producing incorrect URLs on Zeit Now, because the Sanic `request.url` property is not being correctly set.\r\n\r\nhttps://github.com/simonw/datasette/blob/6e37f091edec35e2706197489f54fff5d890c63c/datasette/views/table.py#L653-L655\r\n\r\nSuggested help text:\r\n\r\n> Always use https:// for URLs output as part of Datasette API responses", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 338768551, "label": "Datasette on Zeit Now returns http URLs for facet and next links"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/333#issuecomment-405988035", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/333", "id": 405988035, "node_id": "MDEyOklzc3VlQ29tbWVudDQwNTk4ODAzNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-07-18T16:12:35Z", "updated_at": "2018-07-18T16:12:35Z", "author_association": "OWNER", "body": "I'll add a `absolute_url(request, path)` method on the base view class which knows to check the new config option.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 338768551, "label": "Datasette on Zeit Now returns http URLs for facet and next links"}, "performed_via_github_app": null}