{"html_url": "https://github.com/simonw/datasette/issues/620#issuecomment-554869243", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/620", "id": 554869243, "node_id": "MDEyOklzc3VlQ29tbWVudDU1NDg2OTI0Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-18T06:16:17Z", "updated_at": "2019-11-18T06:16:51Z", "author_association": "OWNER", "body": "I think I should move the `ds.expand_foreign_keys()` method somewhere else:\r\n\r\nhttps://github.com/simonw/datasette/blob/c2779e5af0d056ef1637f9f0e191dca421259a5e/datasette/app.py#L355-L390\r\n\r\nMoving it to `Database` makes sense to me. The question we then ask it is:\r\n\r\n\"Given this column containing these values, give me back a dictionary mapping each column and value to a label - `(column, value) -> label`\"\r\n\r\nPassing in the foreign keys we have calculated as an argument makes sense.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 520667773, "label": "Mechanism for indicating foreign key relationships in the table and query page URLs"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/617#issuecomment-555111571", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/617", "id": 555111571, "node_id": "MDEyOklzc3VlQ29tbWVudDU1NTExMTU3MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-18T17:04:56Z", "updated_at": "2019-11-18T17:04:56Z", "author_association": "OWNER", "body": "I made some comments on an annotated version of this method a few days ago: https://gist.github.com/simonw/66aca058195d77bae5f614ef73352eb5", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 519613116, "label": "Refactor TableView.data() method"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/546#issuecomment-555263426", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/546", "id": 555263426, "node_id": "MDEyOklzc3VlQ29tbWVudDU1NTI2MzQyNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-18T23:45:23Z", "updated_at": "2019-11-18T23:45:23Z", "author_association": "OWNER", "body": "Still needs tests and documentation.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 464987783, "label": "Facet by delimiter"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/546#issuecomment-555263597", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/546", "id": 555263597, "node_id": "MDEyOklzc3VlQ29tbWVudDU1NTI2MzU5Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-11-18T23:46:01Z", "updated_at": "2019-11-18T23:46:01Z", "author_association": "OWNER", "body": "Also maybe this should be added as a suggested facet if a column clearly contains commas that, when split upon, would result in a array recommendation?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 464987783, "label": "Facet by delimiter"}, "performed_via_github_app": null}