{"html_url": "https://github.com/simonw/datasette/issues/1010#issuecomment-706450418", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1010", "id": 706450418, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNjQ1MDQxOA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-10T00:08:27Z", "updated_at": "2020-10-10T00:09:13Z", "author_association": "OWNER", "body": "This commit broke it: https://github.com/simonw/datasette/commit/8f97b9b58e77f82fef1f10e9c9f6754b993544b6#diff-ed4bb3a97b7efa4d45be6a6ea6f4636cL114-R165\r\n\r\n<img width=\"1106\" alt=\"Banners_and_Alerts_and_datasette_client_internal_requests_mechanism_\u00b7_simonw_datasette_8f97b9b\" src=\"https://user-images.githubusercontent.com/9599/95640559-25a37f00-0a52-11eb-838e-9f771ab5a413.png\">\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 718484082, "label": "json / CSV links are broken in Datasette 0.50"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1010#issuecomment-706455202", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1010", "id": 706455202, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNjQ1NTIwMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-10T00:33:46Z", "updated_at": "2020-10-10T00:33:46Z", "author_association": "OWNER", "body": "Since this is an urgent fix that needs to go out I've marked the `base_url` tests as `xfail`. I need to solve those separately, see #900 and various other bug reports.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 718484082, "label": "json / CSV links are broken in Datasette 0.50"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1010#issuecomment-706455505", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1010", "id": 706455505, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNjQ1NTUwNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-10T00:35:41Z", "updated_at": "2020-10-10T00:35:41Z", "author_association": "OWNER", "body": "I missed the links on the query page: https://latest.datasette.io/fixtures?sql=select+pk1%2C+pk2%2C+pk3%2C+content+from+compound_three_primary_keys+order+by+pk1%2C+pk2%2C+pk3+limit+101", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 718484082, "label": "json / CSV links are broken in Datasette 0.50"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1005#issuecomment-706473306", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1005", "id": 706473306, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNjQ3MzMwNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-10T02:45:46Z", "updated_at": "2020-10-10T02:45:46Z", "author_association": "OWNER", "body": "https://github.com/simonw/datasette/blob/9f6dd985bc0eff70f8a9ce65c6578bc43d2e172b/tests/test_html.py#L145-L149\r\n\r\nhttps://github.com/simonw/datasette/blob/9f6dd985bc0eff70f8a9ce65c6578bc43d2e172b/tests/test_html.py#L539-L564\r\n\r\nhttps://github.com/simonw/datasette/blob/8f97b9b58e77f82fef1f10e9c9f6754b993544b6/tests/test_api.py#L1190-L1194\r\n\r\nhttps://github.com/simonw/datasette/blob/8f97b9b58e77f82fef1f10e9c9f6754b993544b6/tests/test_api.py#L742-L746", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 718259202, "label": "Remove xfail tests when new httpx is released"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1011#issuecomment-706480763", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1011", "id": 706480763, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNjQ4MDc2Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-10T03:42:58Z", "updated_at": "2020-10-10T03:42:58Z", "author_association": "OWNER", "body": "Oh no! It's the same bug as #1010. Thanks for the report, I shall push out 0.50.2 as quickly as possible.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 718521469, "label": "column name links broken in 0.50.1"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1011#issuecomment-706480791", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1011", "id": 706480791, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNjQ4MDc5MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-10T03:43:13Z", "updated_at": "2020-10-10T03:43:13Z", "author_association": "OWNER", "body": "Demo: click column headers on https://latest.datasette.io/fixtures/compound_three_primary_keys", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 718521469, "label": "column name links broken in 0.50.1"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1011#issuecomment-706482542", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1011", "id": 706482542, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNjQ4MjU0Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-10T03:58:58Z", "updated_at": "2020-10-10T03:58:58Z", "author_association": "OWNER", "body": "The fix is live on the demo: https://latest.datasette.io/fixtures/compound_three_primary_keys?_sort_desc=pk2", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 718521469, "label": "column name links broken in 0.50.1"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1011#issuecomment-706483680", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1011", "id": 706483680, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNjQ4MzY4MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-10T04:09:32Z", "updated_at": "2020-10-10T04:09:32Z", "author_association": "OWNER", "body": "OK, Datasette 0.50.2 is live on PyPI now.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 718521469, "label": "column name links broken in 0.50.1"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1014#issuecomment-706626796", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1014", "id": 706626796, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNjYyNjc5Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-10T23:47:23Z", "updated_at": "2020-10-10T23:48:26Z", "author_association": "OWNER", "body": "The GitHub API has these:\r\n\r\n`link: <https://api.github.com/repositories/107914493/commits?page=2>; rel=\"next\", <https://api.github.com/repositories/107914493/commits?page=46>; rel=\"last\"`\r\n\r\nWordPress API: https://css-tricks.com/wp-json/wp/v2/posts\r\n\r\n`link: <https://css-tricks.com/wp-json/wp/v2/posts?page=2>; rel=\"next\"`\r\n\r\nIt also has these:\r\n\r\n```\r\nx-wp-total: 5162\r\nx-wp-totalpages: 517\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 718723543, "label": "Add Link: pagination HTTP headers"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1014#issuecomment-706626913", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1014", "id": 706626913, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNjYyNjkxMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-10T23:49:08Z", "updated_at": "2020-10-10T23:49:08Z", "author_association": "OWNER", "body": "This should be documented on https://docs.datasette.io/en/stable/json_api.html", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 718723543, "label": "Add Link: pagination HTTP headers"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1014#issuecomment-706626934", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1014", "id": 706626934, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNjYyNjkzNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-10T23:49:25Z", "updated_at": "2020-10-10T23:49:25Z", "author_association": "OWNER", "body": "I'm just going to implement the 'next' one.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 718723543, "label": "Add Link: pagination HTTP headers"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1014#issuecomment-706626971", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1014", "id": 706626971, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNjYyNjk3MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-10T23:49:57Z", "updated_at": "2020-10-10T23:49:57Z", "author_association": "OWNER", "body": "I won't offer a total-number header. That's expensive to calculate - no need to calculate it unless it's explicitly asked for.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 718723543, "label": "Add Link: pagination HTTP headers"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1014#issuecomment-706627035", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1014", "id": 706627035, "node_id": "MDEyOklzc3VlQ29tbWVudDcwNjYyNzAzNQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-10T23:50:40Z", "updated_at": "2020-10-10T23:50:40Z", "author_association": "OWNER", "body": "First example page to add this to: `?_shape=array`, e.g. https://latest.datasette.io/fixtures/compound_three_primary_keys.json?_shape=array", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 718723543, "label": "Add Link: pagination HTTP headers"}, "performed_via_github_app": null}