{"html_url": "https://github.com/simonw/datasette/issues/1183#issuecomment-758356097", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1183", "id": 758356097, "node_id": "MDEyOklzc3VlQ29tbWVudDc1ODM1NjA5Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-12T02:40:30Z", "updated_at": "2021-01-12T02:40:30Z", "author_association": "OWNER", "body": "So how would this work?\r\n\r\nI think I'm going to automatically use these values if the `_counts` table exists, unless a `ignore_counts_table` boolean setting has been set. I won't bother looking to see if the triggers have been created.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 782708469, "label": "Take advantage of sqlite-utils cached table counts, if available"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1183#issuecomment-758356640", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1183", "id": 758356640, "node_id": "MDEyOklzc3VlQ29tbWVudDc1ODM1NjY0MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-12T02:42:08Z", "updated_at": "2021-01-12T02:42:08Z", "author_association": "OWNER", "body": "Should Datasette have subcommands for this? `datasette enable-counts data.db` and `datasette disable-counts data.db` and `datasette reset-counts data.db` commands?\r\n\r\nMaybe. The `sqlite-utils` CLI tool could be used here instead, but that won't be easily available if Datasette was installed as a standalone binary or using `brew install datasette` or `pipx install datasette`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 782708469, "label": "Take advantage of sqlite-utils cached table counts, if available"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1091#issuecomment-758448525", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1091", "id": 758448525, "node_id": "MDEyOklzc3VlQ29tbWVudDc1ODQ0ODUyNQ==", "user": {"value": 19328961, "label": "henry501"}, "created_at": "2021-01-12T06:55:08Z", "updated_at": "2021-01-12T06:55:08Z", "author_association": "NONE", "body": "Great, really happy I could help! Reverse proxies get tricky.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 742011049, "label": ".json and .csv exports fail to apply base_url"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1091#issuecomment-758668359", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1091", "id": 758668359, "node_id": "MDEyOklzc3VlQ29tbWVudDc1ODY2ODM1OQ==", "user": {"value": 6739646, "label": "tballison"}, "created_at": "2021-01-12T13:52:29Z", "updated_at": "2021-01-12T13:52:29Z", "author_association": "NONE", "body": "Y, thank you to both of you!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 742011049, "label": ".json and .csv exports fail to apply base_url"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1185#issuecomment-759066777", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1185", "id": 759066777, "node_id": "MDEyOklzc3VlQ29tbWVudDc1OTA2Njc3Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-12T22:07:58Z", "updated_at": "2021-01-12T22:07:58Z", "author_association": "OWNER", "body": "https://docs.datasette.io/en/stable/sql_queries.html?highlight=pragma#named-parameters documentation is out-of-date as well:\r\n\r\n> Datasette disallows custom SQL containing the string PRAGMA, as SQLite pragma statements can be used to change database settings at runtime. If you need to include the string \"pragma\" in a query you can do so safely using a named parameter.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 784628163, "label": "\"Statement may not contain PRAGMA\" error is not strictly true"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1185#issuecomment-759067427", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1185", "id": 759067427, "node_id": "MDEyOklzc3VlQ29tbWVudDc1OTA2NzQyNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-12T22:09:21Z", "updated_at": "2021-01-12T22:09:21Z", "author_association": "OWNER", "body": "That allow-list was added in #761 but is not currently documented. It's here in the code:\r\n\r\nhttps://github.com/simonw/datasette/blob/8e8fc5cee5c78da8334495c6d6257d5612c40792/datasette/utils/__init__.py#L173-L186", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 784628163, "label": "\"Statement may not contain PRAGMA\" error is not strictly true"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1185#issuecomment-759069342", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1185", "id": 759069342, "node_id": "MDEyOklzc3VlQ29tbWVudDc1OTA2OTM0Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-12T22:13:18Z", "updated_at": "2021-01-12T22:13:18Z", "author_association": "OWNER", "body": "I'm going to change the error message to list the allowed pragmas.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 784628163, "label": "\"Statement may not contain PRAGMA\" error is not strictly true"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/220#issuecomment-759098964", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/220", "id": 759098964, "node_id": "MDEyOklzc3VlQ29tbWVudDc1OTA5ODk2NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-01-12T23:19:55Z", "updated_at": "2021-01-12T23:19:55Z", "author_association": "OWNER", "body": "I don't think it makes sense to call `.enable_fts()` on a view does it? When I'm working with views and FTS I tend to write my queries against a FTS table for one of the tables that is used by the view - https://docs.datasette.io/en/stable/full_text_search.html#configuring-full-text-search-for-a-table-or-view describes how I do that in Datasette for example.\r\n\r\nCan you expand on your use-case for FTS and views? I'm ready to be convinced otherwise, but I don't see how it would work right now.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 783778672, "label": "Better error message for *_fts methods against views"}, "performed_via_github_app": null}