{"html_url": "https://github.com/simonw/sqlite-utils/issues/271#issuecomment-860142489", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/271", "id": 860142489, "node_id": "MDEyOklzc3VlQ29tbWVudDg2MDE0MjQ4OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-06-13T02:53:06Z", "updated_at": "2021-06-13T02:53:06Z", "author_association": "OWNER", "body": "Looks like this is the problem: https://github.com/simonw/sqlite-utils/blob/b0f9d1e494c9891ce407e27b0f5c6deeea361d30/sqlite_utils/db.py#L1724-L1742\r\n\r\nNote how `set_cols = [col for col in all_columns if col not in pks] ` can potentially return an empty list if ALL of the columns are primary keys - but the next line of code that assigns `sql2` continues regardless, when it should instead be skipped if there are no columns in `set_cols`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 919702451, "label": "table.upsert_all() fails if input has a single column that should be a primary key"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1376#issuecomment-860229226", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1376", "id": 860229226, "node_id": "MDEyOklzc3VlQ29tbWVudDg2MDIyOTIyNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-06-13T15:29:45Z", "updated_at": "2021-06-13T15:29:45Z", "author_association": "OWNER", "body": "Oh good catch - this is a SQLite version issue.\r\n\r\nThe `fixtures.db` file used on https://latest.datasette.io/ includes a generated column (for testing purposes) which is a feature added in SQLite 3.31.0 on 2020-01-22.\r\n\r\nhttps://latest.datasette.io/-/versions\r\n\r\nBut... it looks like the packaged Datasette Docker container doesn't have that SQLite version!\r\n\r\nI should fix that. I'm renaming this issue.\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 919822817, "label": "Official Datasette Docker image should use SQLite >= 3.31.0 (for generated columns)"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1376#issuecomment-860229397", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1376", "id": 860229397, "node_id": "MDEyOklzc3VlQ29tbWVudDg2MDIyOTM5Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-06-13T15:31:02Z", "updated_at": "2021-06-13T15:31:02Z", "author_association": "OWNER", "body": "Alternative fix would be to update that section of the documentation - if the container upgrade proves tricky I can fall back on that.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 919822817, "label": "Official Datasette Docker image should use SQLite >= 3.31.0 (for generated columns)"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1375#issuecomment-860230385", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1375", "id": 860230385, "node_id": "MDEyOklzc3VlQ29tbWVudDg2MDIzMDM4NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-06-13T15:37:49Z", "updated_at": "2021-06-13T15:37:49Z", "author_association": "OWNER", "body": "There is a feature for this at the moment, but it's a little bit hidden: you can use `?_json=col` to tell\r\nDatasette that you would like a specific column to be exported as nested JSON: https://docs.datasette.io/en/stable/json_api.html#special-json-arguments\r\n\r\nI considered trying to make this automatic - so it detects columns that appear to contain valid JSON and outputs them as nested objects - but the problem with that is that it can lead to inconsistent results - you might hit the API and find that not every column contains valid JSON (compared to the previous day) resulting in the API retuning  string instead of the expected dictionary and breaking your code.", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 919508498, "label": "JSON export dumps JSON fields as TEXT"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1376#issuecomment-860230663", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1376", "id": 860230663, "node_id": "MDEyOklzc3VlQ29tbWVudDg2MDIzMDY2Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-06-13T15:39:37Z", "updated_at": "2021-06-13T15:39:37Z", "author_association": "OWNER", "body": "Actually it looks like there is a PR open already that addresses this: #1296 ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 919822817, "label": "Official Datasette Docker image should use SQLite >= 3.31.0 (for generated columns)"}, "performed_via_github_app": null}