{"html_url": "https://github.com/simonw/datasette/pull/1543#issuecomment-986768401", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1543", "id": 986768401, "node_id": "IC_kwDOBm6k_c460OQR", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2021-12-06T13:18:48Z", "updated_at": "2021-12-06T13:18:48Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1543?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\n> Merging [#1543](https://codecov.io/gh/simonw/datasette/pull/1543?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (353a851) into [main](https://codecov.io/gh/simonw/datasette/commit/7c02be2ee94cc64b120cc58b7a72cd387031f287?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (7c02be2) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1543/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1543?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n\n```diff\n@@           Coverage Diff           @@\n##             main    #1543   +/-   ##\n=======================================\n  Coverage   91.84%   91.84%           \n=======================================\n  Files          34       34           \n  Lines        4438     4438           \n=======================================\n  Hits         4076     4076           \n  Misses        362      362           \n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1543?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n> `\u0394 = absolute <relative> (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1543?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [7c02be2...353a851](https://codecov.io/gh/simonw/datasette/pull/1543?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1072135269, "label": "Bump black from 21.11b1 to 21.12b0"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/350#issuecomment-987015063", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/350", "id": 987015063, "node_id": "IC_kwDOCGYnMM461KeX", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-06T17:55:42Z", "updated_at": "2021-12-06T17:55:42Z", "author_association": "OWNER", "body": "API could be this:\r\n```python\r\nid = db[\"columns\"].lookup(\r\n    {\"namespace\": namespace_id, \"name\": column},\r\n    cache=True\r\n)\r\n```\r\nThis could default to a 100 item LRU cache. You could perhaps modify that with `cache_size=500` or with `cache_size=None` to disable the size limit on that cache.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1072435124, "label": "Optional caching mechanism for table.lookup()"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/350#issuecomment-987015327", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/350", "id": 987015327, "node_id": "IC_kwDOCGYnMM461Kif", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-06T17:56:05Z", "updated_at": "2021-12-06T17:56:05Z", "author_association": "OWNER", "body": "Should I implement this remember to apply the optimization in `git-history`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1072435124, "label": "Optional caching mechanism for table.lookup()"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/350#issuecomment-987016019", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/350", "id": 987016019, "node_id": "IC_kwDOCGYnMM461KtT", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-06T17:56:57Z", "updated_at": "2021-12-06T17:56:57Z", "author_association": "OWNER", "body": "Would be interesting to micro-benchmark this to get an idea for how much of a performance boost it is, since the indexed SQLite lookups used by `table.lookup()` should be really fast already.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1072435124, "label": "Optional caching mechanism for table.lookup()"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/349#issuecomment-987349633", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/349", "id": 987349633, "node_id": "IC_kwDOCGYnMM462cKB", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-12-06T23:19:28Z", "updated_at": "2021-12-06T23:19:28Z", "author_association": "OWNER", "body": "(I ended up not needing this here since `.lookup()` already creates a unique index on `_item_id` for you. Still could be a useful feature though.)", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1071531082, "label": "A way of creating indexes on newly created tables"}, "performed_via_github_app": null}