{"html_url": "https://github.com/simonw/datasette/pull/258#issuecomment-390577711", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/258", "id": 390577711, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MDU3NzcxMQ==", "user": {"value": 247131, "label": "philroche"}, "created_at": "2018-05-21T07:38:15Z", "updated_at": "2018-05-21T07:38:15Z", "author_association": "NONE", "body": "Excellent, I was not aware of the auto redirect to the new hash. My bad\r\n\r\nThis solves my use case.\r\n\r\nI do agree that your suggested --no-url-hash approach is much neater. I will investigate ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 322741659, "label": "Add new metadata key persistent_urls which removes the hash from all database urls"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/247#issuecomment-390689406", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/247", "id": 390689406, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MDY4OTQwNg==", "user": {"value": 11912854, "label": "jsancho-gpl"}, "created_at": "2018-05-21T15:29:31Z", "updated_at": "2018-05-21T15:29:31Z", "author_association": "NONE", "body": "I've changed my mind about the way to support external connectors aside of SQLite and I'm working in a more simple style that respects the original Datasette, i.e. less refactoring. I present you [a version of Datasette wich supports other database connectors](https://github.com/jsancho-gpl/datasette/tree/external-connectors) and [a Datasette connector for HDF5/PyTables files](https://github.com/jsancho-gpl/datasette-pytables).", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 319449852, "label": "SQLite code decoupled from Datasette"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/277#issuecomment-390707183", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/277", "id": 390707183, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MDcwNzE4Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-21T16:28:39Z", "updated_at": "2018-05-21T16:28:39Z", "author_association": "OWNER", "body": "This is definitely a big improvement.\r\n\r\nI'd like to refactor the unit tests that cover .inspect() too - currently they are a huge ugly blob at the top of test_api.py", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 324836533, "label": "Refactor inspect logic"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/276#issuecomment-390707760", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/276", "id": 390707760, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MDcwNzc2MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-21T16:30:35Z", "updated_at": "2018-05-21T16:30:35Z", "author_association": "OWNER", "body": "This probably needs to be in a plugin simply because getting Spatialite compiled and installed is a bit of a pain.\r\n\r\nIt's a great opportunity to expand the plugin hooks in useful ways though.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 324835838, "label": "Handle spatialite geometry columns better"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/276#issuecomment-390795067", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/276", "id": 390795067, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MDc5NTA2Nw==", "user": {"value": 45057, "label": "russss"}, "created_at": "2018-05-21T21:55:57Z", "updated_at": "2018-05-21T21:55:57Z", "author_association": "CONTRIBUTOR", "body": "Well, we do have the capability to detect spatialite so my intention certainly wasn't to require it. \r\n\r\nI can see the advantage of having it as a plugin but it does touch a number of points in the code. I think I'm going to attack this by refactoring the necessary bits and seeing where that leads (which was my plan anyway).\r\n\r\nI think my main concern is - if I add certain plugin hooks for this, is anything else ever going to use them? I'm not sure I have an answer to that question yet, either way.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 324835838, "label": "Handle spatialite geometry columns better"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/277#issuecomment-390804333", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/277", "id": 390804333, "node_id": "MDEyOklzc3VlQ29tbWVudDM5MDgwNDMzMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2018-05-21T22:40:16Z", "updated_at": "2018-05-21T22:43:50Z", "author_association": "OWNER", "body": "We should merge this before refactoring the tests though, because that way we don't couple the new tests to the verification of this change.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 324836533, "label": "Refactor inspect logic"}, "performed_via_github_app": null}