{"html_url": "https://github.com/simonw/datasette/issues/420#issuecomment-480552387", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/420", "id": 480552387, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4MDU1MjM4Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-04-07T02:06:20Z", "updated_at": "2019-04-07T02:06:20Z", "author_association": "OWNER", "body": "`expand_foreign_keys()` relies on the `.inspect()` command having automatically derived the `label_column` for a table, which it does using this code:\r\n\r\nhttps://github.com/simonw/datasette/blob/97331f3435ba1583a0f9dbcaffc25de8894cf1f8/datasette/inspect.py#L34-L42\r\n\r\nThis needs access to the column names for the table. I think we can drop this entirely in favour of a new utility function - and that function can incorporate the metadata check as well.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 421971339, "label": "Fix all the places that currently use .inspect() data"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/420#issuecomment-480556166", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/420", "id": 480556166, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4MDU1NjE2Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-04-07T03:35:59Z", "updated_at": "2019-04-07T03:48:14Z", "author_association": "OWNER", "body": "Still need to solve: `TableView.data()` - but this is the one with a row count in hence the need to solve #422 ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 421971339, "label": "Fix all the places that currently use .inspect() data"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/425#issuecomment-480558501", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/425", "id": 480558501, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4MDU1ODUwMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-04-07T04:32:28Z", "updated_at": "2019-04-07T04:32:28Z", "author_association": "OWNER", "body": "Here's the problem:\r\n\r\nhttps://github.com/simonw/datasette/blob/6f6d0ff2b41f1cacaf42287b1b230b646bcba9ee/datasette/templates/query.html#L30-L36\r\n\r\nNeed an else block here that adds the SQL as a hidden form field.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 430103450, "label": "Submitting SQL on hide page is broken"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/18#issuecomment-480621924", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/18", "id": 480621924, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4MDYyMTkyNA==", "user": {"value": 82988, "label": "psychemedia"}, "created_at": "2019-04-07T19:31:42Z", "updated_at": "2019-04-07T19:31:42Z", "author_association": "NONE", "body": "I've just noticed that SQLite lets you IGNORE inserts that collide with a pre-existing key. This can be quite handy if you have a dataset that keeps changing in part, and you don't want to upsert and replace pre-existing PK rows but you do want to ignore collisions to existing PK rows.\r\n\r\nDo `sqlite_utils` support such (cavalier!) behaviour?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 413871266, "label": ".insert/.upsert/.insert_all/.upsert_all should add missing columns"}, "performed_via_github_app": null}