{"html_url": "https://github.com/simonw/datasette/pull/1043#issuecomment-716237524", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1043", "id": 716237524, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNjIzNzUyNA==", "user": {"value": 45380, "label": "bollwyvl"}, "created_at": "2020-10-26T00:14:57Z", "updated_at": "2020-10-26T00:14:57Z", "author_association": "CONTRIBUTOR", "body": "Sorry, I was out of the loop this weekend. The missing sdists were in some the `datasette-*` plugins... i'll capture my findings more concretely in one spot when i have a chance...", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 727915394, "label": "Include LICENSE in sdist"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1052#issuecomment-716265360", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1052", "id": 716265360, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNjI2NTM2MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-26T02:17:58Z", "updated_at": "2020-10-26T02:17:58Z", "author_association": "OWNER", "body": "The default z-index values for Leaflet are defined here: https://github.com/Leaflet/Leaflet/blob/b346bb8bf7bb80899baa1f4fc1536bae58e7e3e6/dist/leaflet.css#L81-L91\r\n\r\n```css\r\n.leaflet-pane         { z-index: 400; }\r\n\r\n.leaflet-tile-pane    { z-index: 200; }\r\n.leaflet-overlay-pane { z-index: 400; }\r\n.leaflet-shadow-pane  { z-index: 500; }\r\n.leaflet-marker-pane  { z-index: 600; }\r\n.leaflet-tooltip-pane   { z-index: 650; }\r\n.leaflet-popup-pane   { z-index: 700; }\r\n\r\n.leaflet-map-pane canvas { z-index: 100; }\r\n.leaflet-map-pane svg    { z-index: 200; }\r\n```\r\nSo a `z-index` of 1000 on the menu should fix this.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 729183332, "label": "Column action menu overlapped by Leaflet maps"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/976#issuecomment-716305890", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/976", "id": 716305890, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNjMwNTg5MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-26T05:07:10Z", "updated_at": "2020-10-26T05:07:10Z", "author_association": "OWNER", "body": "I used the new `datasette.urls` methods to handle escaping table names.\r\n\r\nhttps://github.com/simonw/datasette/blob/f5dbe61a4568c0915ec6be820095c2960cf0857c/datasette/utils/__init__.py#L996-L1008", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 708289783, "label": "Idea: -o could open to a more convenient location"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1051#issuecomment-716681167", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1051", "id": 716681167, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNjY4MTE2Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-26T16:51:15Z", "updated_at": "2020-10-26T16:51:15Z", "author_association": "OWNER", "body": "Crazy idea: generate a signed URL containing a base64 of the gzip of the binary content (to try and reduce size).\r\n\r\nNo: this will blow through URL limits in various hosting providers and possibly even browsers. It could be made to work a little bit more reliably with some extra JavaScript that turns it into a download on the browser-side, but that would be hideously complicated.\r\n\r\nAlso the signed bit doesn't prevent people from generating SQL queries that generate nasty binary blobs for download.\r\n\r\nI'm beginning to think that restricting this feature to just table view, not query view, is a better idea. Query view can still get at the binary using JSON and base64.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 729096595, "label": "Better display of binary data on arbitrary query results page"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1051#issuecomment-716681602", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1051", "id": 716681602, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNjY4MTYwMg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-26T16:51:58Z", "updated_at": "2020-10-26T16:51:58Z", "author_association": "OWNER", "body": "I still need to improve the current binary display on the query page though, where it outputs a Python `b'...'` literal.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 729096595, "label": "Better display of binary data on arbitrary query results page"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/189#issuecomment-716756103", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/189", "id": 716756103, "node_id": "MDEyOklzc3VlQ29tbWVudDcxNjc1NjEwMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-10-26T18:56:19Z", "updated_at": "2020-10-26T18:56:19Z", "author_association": "OWNER", "body": "This is a great fix, thanks! If you add a unit test somewhere in here I'll merge the PR:  https://github.com/simonw/sqlite-utils/blob/main/tests/test_m2m.py", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 729818242, "label": "Allow iterables other than Lists in m2m records"}, "performed_via_github_app": null}