{"html_url": "https://github.com/simonw/datasette/pull/1085#issuecomment-725731685", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1085", "id": 725731685, "node_id": "MDEyOklzc3VlQ29tbWVudDcyNTczMTY4NQ==", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2020-11-12T00:01:18Z", "updated_at": "2020-11-12T00:01:18Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1085?src=pr&el=h1) Report\n> Merging [#1085](https://codecov.io/gh/simonw/datasette/pull/1085?src=pr&el=desc) (51e7651) into [main](https://codecov.io/gh/simonw/datasette/commit/2a981e2ac1d13125973904b777d00ea75e8df4e6?el=desc) (2a981e2) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1085/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1)](https://codecov.io/gh/simonw/datasette/pull/1085?src=pr&el=tree)\n\n```diff\n@@ Coverage Diff @@\n## main #1085 +/- ##\n=======================================\n Coverage 91.38% 91.38% \n=======================================\n Files 30 30 \n Lines 3785 3785 \n=======================================\n Hits 3459 3459 \n Misses 326 326 \n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1085?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `\u0394 = absolute (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1085?src=pr&el=footer). Last update [2a981e2...51e7651](https://codecov.io/gh/simonw/datasette/pull/1085?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 740512882, "label": "Use FTS4 in fixtures"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1088#issuecomment-725829903", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1088", "id": 725829903, "node_id": "MDEyOklzc3VlQ29tbWVudDcyNTgyOTkwMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-11-12T04:33:14Z", "updated_at": "2020-11-12T04:33:14Z", "author_association": "OWNER", "body": "I'm suspicious of this code: https://github.com/simonw/datasette/blob/e8e0a6f284ca953b2980186c4356594c07bd1929/datasette/views/table.py#L1032-L1045\r\n\r\nThis code uses a different exception: https://github.com/simonw/datasette/blob/e8e0a6f284ca953b2980186c4356594c07bd1929/datasette/views/table.py#L658-L663\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 741268956, "label": "OperationalError('interrupted') can 500 on row page"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1088#issuecomment-725830533", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1088", "id": 725830533, "node_id": "MDEyOklzc3VlQ29tbWVudDcyNTgzMDUzMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-11-12T04:35:08Z", "updated_at": "2020-11-12T04:35:08Z", "author_association": "OWNER", "body": "Yup, swapping `QueryInterrupted` fixed this against my giant database.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 741268956, "label": "OperationalError('interrupted') can 500 on row page"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1088#issuecomment-725830716", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1088", "id": 725830716, "node_id": "MDEyOklzc3VlQ29tbWVudDcyNTgzMDcxNg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-11-12T04:35:38Z", "updated_at": "2020-11-12T04:35:38Z", "author_association": "OWNER", "body": "I'm going to fix this without a test, because writing a test for this is a bit fiddly and it's a very minor bug. If it comes back again I'll do the work to test for it.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 741268956, "label": "OperationalError('interrupted') can 500 on row page"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1089#issuecomment-726127465", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1089", "id": 726127465, "node_id": "MDEyOklzc3VlQ29tbWVudDcyNjEyNzQ2NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-11-12T14:54:11Z", "updated_at": "2020-11-12T14:54:11Z", "author_association": "OWNER", "body": "Suggested list to look out for from that PR:\r\n\r\n- simply/simple\r\n- easy/easier/easiest\r\n- obvious/obviously\r\n- just\r\n- merely\r\n- straightforward\r\n- ridiculous", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 741665726, "label": "Sweep documentation for words that minimize involved difficulty"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/865#issuecomment-726385422", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/865", "id": 726385422, "node_id": "MDEyOklzc3VlQ29tbWVudDcyNjM4NTQyMg==", "user": {"value": 6739646, "label": "tballison"}, "created_at": "2020-11-12T22:40:14Z", "updated_at": "2020-11-12T22:40:14Z", "author_association": "NONE", "body": "Just tested with the latest Docker image, and it works pretty much everywhere! THANK YOU!\r\n\r\nI did notice that if I try to export json or csv, the base is not applied. Not sure if I should reopen this issue or open a new one.\r\n\r\nTo see this, go here: https://corpora.tika.apache.org/datasette/corpora-metadata/REF_PARSE_EXCEPTION_TYPES\r\n\r\nClick/hover over json or CSV and you'll see that the 'datasette' base is not included.\r\n\r\nAgain, many thanks!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 644582921, "label": "base_url doesn't seem to work when adding criteria and clicking \"apply\""}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/865#issuecomment-726385782", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/865", "id": 726385782, "node_id": "MDEyOklzc3VlQ29tbWVudDcyNjM4NTc4Mg==", "user": {"value": 6739646, "label": "tballison"}, "created_at": "2020-11-12T22:41:06Z", "updated_at": "2020-11-12T22:41:06Z", "author_association": "NONE", "body": "The same is true if I select advanced export and hit the 'export csv' at the bottom of the page.\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 644582921, "label": "base_url doesn't seem to work when adding criteria and clicking \"apply\""}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/865#issuecomment-726412057", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/865", "id": 726412057, "node_id": "MDEyOklzc3VlQ29tbWVudDcyNjQxMjA1Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-11-12T23:49:23Z", "updated_at": "2020-11-12T23:49:23Z", "author_association": "OWNER", "body": "@tballison thanks, I've split that out into a new issue #1091", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 644582921, "label": "base_url doesn't seem to work when adding criteria and clicking \"apply\""}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1091#issuecomment-726413829", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1091", "id": 726413829, "node_id": "MDEyOklzc3VlQ29tbWVudDcyNjQxMzgyOQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-11-12T23:52:50Z", "updated_at": "2020-11-12T23:54:16Z", "author_association": "OWNER", "body": "Hmm... it's not just the `.csv` and `.json` export links - it's the column headings (which can be clicked to change the sort order) as well. Here's an extract of the HTML from that page:\r\n```html\r\n

This data as \r\n json, \r\n CSV (\r\n advanced)\r\n

\r\n
\r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n \r\n
\r\n Link\r\n \r\n rowid \u25bc\r\n \r\n PARSE_EXCEPTION_ID\r\n \r\n PARSE_EXCEPTION_DESCRIPTION\r\n
\r\n 1\r\n 10RUNTIME
\r\n 2\r\n 21ENCRYPTION
\r\n 3\r\n 32ACCESS_PERMISSION
\r\n 4\r\n 43UNSUPPORTED_VERSION
\r\n
\r\n
\r\n

Advanced export

\r\n

JSON shape:\r\n default,\r\n array,\r\n newline-delimited\r\n

\r\n
\r\n

\r\n CSV options: \r\n \r\n \r\n \r\n

\r\n
\r\n
\r\n```\r\nBut here's something _really_ weird - the links to the individual rows DO include the `/datasette/` prefix:\r\n```html\r\n\r\n 2\r\n\r\n```\r\nThe navigation bar on that page is correct too:\r\n```html\r\n

\r\n home /\r\n corpora-metadata\r\n

\r\n```\r\nI've also been unable to replicate this in my own local environment, running `datasette fixtures.db --config base_url:/datasette/`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 742011049, "label": ".json and .csv exports fail to apply base_url"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1091#issuecomment-726415019", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1091", "id": 726415019, "node_id": "MDEyOklzc3VlQ29tbWVudDcyNjQxNTAxOQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-11-12T23:56:23Z", "updated_at": "2020-11-12T23:56:23Z", "author_association": "OWNER", "body": "@tballison is there any chance you're running any custom templates in that installation? I'm really confused as to why I can't replicate the bug.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 742011049, "label": ".json and .csv exports fail to apply base_url"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1091#issuecomment-726415991", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1091", "id": 726415991, "node_id": "MDEyOklzc3VlQ29tbWVudDcyNjQxNTk5MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2020-11-12T23:59:34Z", "updated_at": "2020-11-12T23:59:34Z", "author_association": "OWNER", "body": "The sort headers are generated by this template code: https://github.com/simonw/datasette/blob/5eb8e9bf250b26e30b017d39a392c33973997656/datasette/templates/_table.html#L11-L15\r\n\r\nThe export links use this code:\r\n\r\nhttps://github.com/simonw/datasette/blob/5eb8e9bf250b26e30b017d39a392c33973997656/datasette/templates/table.html#L134\r\n\r\nhttps://github.com/simonw/datasette/blob/5eb8e9bf250b26e30b017d39a392c33973997656/datasette/templates/table.html#L180-L201", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 742011049, "label": ".json and .csv exports fail to apply base_url"}, "performed_via_github_app": null}