{"html_url": "https://github.com/simonw/datasette/pull/1463#issuecomment-915229323", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1463", "id": 915229323, "node_id": "IC_kwDOBm6k_c42jUqL", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2021-09-08T13:15:26Z", "updated_at": "2021-10-13T21:52:23Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1463?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\n> Merging [#1463](https://codecov.io/gh/simonw/datasette/pull/1463?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (2dd94c5) into [main](https://codecov.io/gh/simonw/datasette/commit/0d5cc20aeffa3537cfc9296d01ec24b9c6e23dcf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (0d5cc20) will **decrease** coverage by `0.00%`.\n> The diff coverage is `n/a`.\n\n> :exclamation: Current head 2dd94c5 differs from pull request most recent head 481212c. Consider uploading reports for the commit 481212c to get more accurate results\n[](https://codecov.io/gh/simonw/datasette/pull/1463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n\n```diff\n@@ Coverage Diff @@\n## main #1463 +/- ##\n==========================================\n- Coverage 91.83% 91.83% -0.01% \n==========================================\n Files 34 34 \n Lines 4422 4421 -1 \n==========================================\n- Hits 4061 4060 -1 \n Misses 361 361 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1463?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage \u0394 | |\n|---|---|---|\n| [datasette/views/table.py](https://codecov.io/gh/simonw/datasette/pull/1463/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL3RhYmxlLnB5) | `96.00% <0.00%> (-0.01%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1463?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n> `\u0394 = absolute (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1463?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [e1012e7...481212c](https://codecov.io/gh/simonw/datasette/pull/1463?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 991121619, "label": "Update beautifulsoup4 requirement from <4.10.0,>=4.8.1 to >=4.8.1,<4.11.0"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1471#issuecomment-919141156", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1471", "id": 919141156, "node_id": "IC_kwDOBm6k_c42yPsk", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2021-09-14T13:16:29Z", "updated_at": "2021-10-13T21:12:25Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1471?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\n> Merging [#1471](https://codecov.io/gh/simonw/datasette/pull/1471?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (01b05ed) into [main](https://codecov.io/gh/simonw/datasette/commit/0d5cc20aeffa3537cfc9296d01ec24b9c6e23dcf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (0d5cc20) will **decrease** coverage by `0.00%`.\n> The diff coverage is `n/a`.\n\n> :exclamation: Current head 01b05ed differs from pull request most recent head 847238a. Consider uploading reports for the commit 847238a to get more accurate results\n[](https://codecov.io/gh/simonw/datasette/pull/1471?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n\n```diff\n@@ Coverage Diff @@\n## main #1471 +/- ##\n==========================================\n- Coverage 91.83% 91.83% -0.01% \n==========================================\n Files 34 34 \n Lines 4422 4421 -1 \n==========================================\n- Hits 4061 4060 -1 \n Misses 361 361 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1471?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage \u0394 | |\n|---|---|---|\n| [datasette/views/table.py](https://codecov.io/gh/simonw/datasette/pull/1471/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL3RhYmxlLnB5) | `96.00% <0.00%> (-0.01%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1471?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n> `\u0394 = absolute (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1471?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [a673a93...847238a](https://codecov.io/gh/simonw/datasette/pull/1471?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 996002181, "label": "Bump black from 21.7b0 to 21.9b0"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1487#issuecomment-942722595", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1487", "id": 942722595, "node_id": "IC_kwDOBm6k_c44MM4j", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-10-13T21:08:53Z", "updated_at": "2021-10-13T21:08:53Z", "author_association": "OWNER", "body": "Thanks for this!", "reactions": "{\"total_count\": 1, \"+1\": 1, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1023245060, "label": "Added instructions for installing plugins via pipx, #1486"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1469#issuecomment-942725632", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1469", "id": 942725632, "node_id": "IC_kwDOBm6k_c44MNoA", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-10-13T21:13:30Z", "updated_at": "2021-10-13T21:13:30Z", "author_association": "OWNER", "body": "The core problem here is treating the `?_facet=` query string parameters as the point of truth for which facets are currently enabled.\r\n\r\nInstead, I could use a `data-` attribute on the displayed facets.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 994450961, "label": "Column cog shows \"facet by this\" when already default faceted"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/330#issuecomment-942752844", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/330", "id": 942752844, "node_id": "IC_kwDOCGYnMM44MURM", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2021-10-13T22:00:31Z", "updated_at": "2021-10-13T22:11:30Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/sqlite-utils/pull/330?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\n> Merging [#330](https://codecov.io/gh/simonw/sqlite-utils/pull/330?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (fc3de90) into [main](https://codecov.io/gh/simonw/sqlite-utils/commit/718a8f61bcaed39c04d5d223104056213f8c8516?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (718a8f6) will **not change** coverage.\n> The diff coverage is `n/a`.\n\n[](https://codecov.io/gh/simonw/sqlite-utils/pull/330?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n\n```diff\n@@ Coverage Diff @@\n## main #330 +/- ##\n=======================================\n Coverage 96.59% 96.59% \n=======================================\n Files 5 5 \n Lines 2230 2230 \n=======================================\n Hits 2154 2154 \n Misses 76 76 \n```\n\n\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/sqlite-utils/pull/330?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n> `\u0394 = absolute (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/sqlite-utils/pull/330?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [718a8f6...fc3de90](https://codecov.io/gh/simonw/sqlite-utils/pull/330?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1025726600, "label": "Test against Python 3.10"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1488#issuecomment-942777414", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1488", "id": 942777414, "node_id": "IC_kwDOBm6k_c44MaRG", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-10-13T22:52:40Z", "updated_at": "2021-10-13T22:52:40Z", "author_association": "OWNER", "body": "Upgrading to 0.20.0 gives me lots of the following errors:\r\n\r\n '{\"ok\": false, \"error\": \"Database not found: .json?_sort=relationships\", \"status\": 404, \"title\": null}'\r\n\r\nIt looks like the full query string is now being treated as the name of the database.\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1025754125, "label": "Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects')"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1488#issuecomment-942778382", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1488", "id": 942778382, "node_id": "IC_kwDOBm6k_c44MagO", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-10-13T22:55:01Z", "updated_at": "2021-10-13T22:55:01Z", "author_association": "OWNER", "body": "I think the issue is in `route_path()`:\r\n```\r\n> /Users/simon/Dropbox/Development/datasette/datasette/app.py(1182)route_path()\r\n-> response = await view(request, send)\r\n(Pdb) path\r\n'/_memory.json?sql=select+sqlite_version()'\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1025754125, "label": "Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects')"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1488#issuecomment-942778673", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1488", "id": 942778673, "node_id": "IC_kwDOBm6k_c44Makx", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-10-13T22:55:44Z", "updated_at": "2021-10-13T22:55:44Z", "author_association": "OWNER", "body": "```\r\n(Pdb) request.scope['path']\r\n'/_memory.json'\r\n(Pdb) request.scope['raw_path']\r\nb'/_memory.json?sql=select+sqlite_version()'\r\n```\r\nSo `raw_path` now includes the query string.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1025754125, "label": "Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects')"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1488#issuecomment-942779926", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1488", "id": 942779926, "node_id": "IC_kwDOBm6k_c44Ma4W", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-10-13T22:59:05Z", "updated_at": "2021-10-13T22:59:05Z", "author_association": "OWNER", "body": "This is weird - as far as I can tell `httpx` has included the query string in `raw_path` for well over a year: https://github.com/encode/httpx/commit/8e4a8a1c73f60fe5754f95b308beaa725cb8791d#diff-c9a78eb3b5f5c4fac4e5552165fbdd5320c7e3fadf9eedabcb5461393466c090R235", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1025754125, "label": "Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects')"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1488#issuecomment-942782673", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1488", "id": 942782673, "node_id": "IC_kwDOBm6k_c44MbjR", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-10-13T23:04:54Z", "updated_at": "2021-10-13T23:04:54Z", "author_association": "OWNER", "body": "I think this is the change in `httpx` which is causing the bug for me: https://github.com/encode/httpx/commit/ff9813e84dab56f0f3c4ef3a159a4cce8c644a91#diff-0d0cbe9ebcd03cc8c780b0407762540a082f70cc64257f2fcd588cc30f43c15cR96\r\n\r\n![\"Transport_API_as_plain_`request_-__response`_method____1840__\u00b7_encode_httpx_ff9813e\"](\"https://user-images.githubusercontent.com/9599/137224339-0aed171f-b351-4d67-8d6c-ad22f2301f18.png\")
\r\n\r\nPreviously it was using `path` from `path, _, query = full_path.partition(b\"?\")` to populate the `raw_path` key - but it changed to instead using `request.url.raw_path` which presumably implements the logic that includes the query string.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1025754125, "label": "Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects')"}, "performed_via_github_app": null}