{"html_url": "https://github.com/simonw/sqlite-utils/pull/407#issuecomment-1040959312", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/407", "id": 1040959312, "node_id": "IC_kwDOCGYnMM4-C8dQ", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-02-16T00:58:32Z", "updated_at": "2022-02-16T00:58:32Z", "author_association": "OWNER", "body": "This is honestly one of the most complete PRs I've ever seen for a feature of this size. Thanks so much for this!", "reactions": "{\"total_count\": 1, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 1, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1138948786, "label": "Add SpatiaLite helpers to CLI"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/398#issuecomment-1040965672", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/398", "id": 1040965672, "node_id": "IC_kwDOCGYnMM4-C-Ao", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-02-16T01:02:29Z", "updated_at": "2022-02-16T01:02:29Z", "author_association": "OWNER", "body": "Documentation:\r\n\r\n- https://sqlite-utils.datasette.io/en/latest/cli-reference.html#create-database\r\n- https://sqlite-utils.datasette.io/en/latest/cli-reference.html#add-geometry-column\r\n- https://sqlite-utils.datasette.io/en/latest/cli-reference.html#create-spatial-index\r\n- https://sqlite-utils.datasette.io/en/latest/cli.html#spatialite-helpers", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1124237013, "label": "Add SpatiaLite helpers to CLI"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/406#issuecomment-1040974519", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/406", "id": 1040974519, "node_id": "IC_kwDOCGYnMM4-DAK3", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-02-16T01:08:17Z", "updated_at": "2022-02-16T01:08:17Z", "author_association": "OWNER", "body": "I had no idea this was possible! I guess SQLite will allow any text string as the column type, defaulting to `TEXT` as the underlying default representation if it doesn't recognize the type.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1128466114, "label": "Creating tables with custom datatypes"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/406#issuecomment-1040978032", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/406", "id": 1040978032, "node_id": "IC_kwDOCGYnMM4-DBBw", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-02-16T01:10:31Z", "updated_at": "2022-02-16T01:10:31Z", "author_association": "OWNER", "body": "Allowing custom strings in the `create()` method, as you suggest in your example, feels like a reasonable way to support this.\r\n```python\r\ndb[\"dummy\"].create({\r\n    \"title\": str,\r\n    \"vector\": \"array\",\r\n})\r\n```\r\nI'm slightly nervous about that just because people might accidentally use this without realizig what they are doing - passing `\"column-name\": \"string\"` for example when they should have used `\"column-name\": str` in order to get a `TEXT` column.\r\n\r\nAlternatively, this could work:\r\n\r\n```python\r\ndb[\"dummy\"].create({\r\n    \"title\": str,\r\n    \"vector\": CustomColumnType(\"array\")\r\n})\r\n```\r\nThis would play better with `mypy` too I think.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1128466114, "label": "Creating tables with custom datatypes"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/pull/407#issuecomment-1040998433", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/407", "id": 1040998433, "node_id": "IC_kwDOCGYnMM4-DGAh", "user": {"value": 25778, "label": "eyeseast"}, "created_at": "2022-02-16T01:29:39Z", "updated_at": "2022-02-16T01:29:39Z", "author_association": "CONTRIBUTOR", "body": "Happy to do it and have it in the library. Going to use it a bunch. This whole SpatiaLite toolchain become a huge part of my work in the past year.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1138948786, "label": "Add SpatiaLite helpers to CLI"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/406#issuecomment-1041313679", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/406", "id": 1041313679, "node_id": "IC_kwDOCGYnMM4-ES-P", "user": {"value": 82988, "label": "psychemedia"}, "created_at": "2022-02-16T09:59:51Z", "updated_at": "2022-02-16T10:00:10Z", "author_association": "NONE", "body": "The `CustomColumnType()` approach looks good. This pushes you into the mindspace that you are defining and working with a custom column type.\r\n\r\nWhen creating the table, you could then error, or at least warn, if someone wasn't setting a column on a `type` or a custom column type, which I guess is where `mypy` comes in?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1128466114, "label": "Creating tables with custom datatypes"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/402#issuecomment-1041325398", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/402", "id": 1041325398, "node_id": "IC_kwDOCGYnMM4-EV1W", "user": {"value": 82988, "label": "psychemedia"}, "created_at": "2022-02-16T10:12:48Z", "updated_at": "2022-02-16T10:18:55Z", "author_association": "NONE", "body": "> My hunch is that the case where you want to consider input from more than one column will actually be pretty rare - the only case I can think of where I would want to do that is for latitude/longitude columns\r\n\r\nOther possible pairs: unconventional date/datetime and timezone pairs eg `2022-02-16::17.00, London`; or more generally, numerical value and unit of measurement pairs (eg if you want to cast into and out of different measurement units using packages like `pint`) or currencies etc. Actually, in that case, I guess you may be presenting things that are unit typed already, and so a conversion would need to parse things into an appropriate, possibly two column `value, unit` format.\r\n\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1125297737, "label": "Advanced class-based `conversions=` mechanism"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/sqlite-utils/issues/406#issuecomment-1041363433", "issue_url": "https://api.github.com/repos/simonw/sqlite-utils/issues/406", "id": 1041363433, "node_id": "IC_kwDOCGYnMM4-EfHp", "user": {"value": 82988, "label": "psychemedia"}, "created_at": "2022-02-16T10:57:03Z", "updated_at": "2022-02-16T10:57:19Z", "author_association": "NONE", "body": "Wondering if this actually relates to https://github.com/simonw/sqlite-utils/issues/402 ?\r\n\r\nI also wonder if this would be a sensible approach for eg registering `pint` based quantity conversions into and out of the db, perhaps storing the quantity as a serialised `magnitude measurement` single column string?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1128466114, "label": "Creating tables with custom datatypes"}, "performed_via_github_app": null}