{"html_url": "https://github.com/simonw/datasette/issues/511#issuecomment-877717791", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/511", "id": 877717791, "node_id": "MDEyOklzc3VlQ29tbWVudDg3NzcxNzc5MQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-10T23:45:35Z", "updated_at": "2021-07-10T23:45:35Z", "author_association": "OWNER", "body": "> Trying to run on Windows today, I get an error from the utils/asgi.py module.\r\n> \r\n> It's trying `from os import EX_CANTCREAT` which is Unix-only. I commented this line out, and (so far) it's working.\r\n\r\nGood news: that line was removed in #1094.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 456578474, "label": "Get Datasette tests passing on Windows in GitHub Actions"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/511#issuecomment-877718286", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/511", "id": 877718286, "node_id": "MDEyOklzc3VlQ29tbWVudDg3NzcxODI4Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-10T23:53:29Z", "updated_at": "2021-07-10T23:53:29Z", "author_association": "OWNER", "body": "Test suite on Windows seems to run a lot slower:\r\n\r\n<img width=\"391\" alt=\"Ran_Black__refs__1388_\u00b7_simonw_datasette_518cb06\" src=\"https://user-images.githubusercontent.com/9599/125179033-4e9e9f00-e19f-11eb-8c2e-8df09fafa795.png\">\r\n\r\nFrom https://github.com/simonw/datasette/actions/runs/1018938850 which is still going.\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 456578474, "label": "Get Datasette tests passing on Windows in GitHub Actions"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/511#issuecomment-877718364", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/511", "id": 877718364, "node_id": "MDEyOklzc3VlQ29tbWVudDg3NzcxODM2NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-10T23:54:37Z", "updated_at": "2021-07-10T23:54:37Z", "author_association": "OWNER", "body": "Looks like it's not even 10% of the way through, and already a bunch of errors:\r\n\r\n<img width=\"777\" alt=\"Ran_Black__refs__1388_\u00b7_simonw_datasette_518cb06\" src=\"https://user-images.githubusercontent.com/9599/125179059-81e12e00-e19f-11eb-94d9-0f2d9ce8afad.png\">\r\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 456578474, "label": "Get Datasette tests passing on Windows in GitHub Actions"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/557#issuecomment-877717392", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/557", "id": 877717392, "node_id": "MDEyOklzc3VlQ29tbWVudDg3NzcxNzM5Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-10T23:39:48Z", "updated_at": "2021-07-10T23:39:48Z", "author_association": "OWNER", "body": "Abandoning this - need to switch to using GitHub Actions for this instead.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 466996584, "label": "Get tests running on Windows using Travis CI"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1388#issuecomment-877714698", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1388", "id": 877714698, "node_id": "MDEyOklzc3VlQ29tbWVudDg3NzcxNDY5OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-10T23:01:37Z", "updated_at": "2021-07-10T23:01:37Z", "author_association": "OWNER", "body": "Can test this with:\r\n```\r\ncurl --unix-socket ${socket} -i \"http://localhost/\" \r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 939051549, "label": "Serve using UNIX domain socket"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1388#issuecomment-877715654", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1388", "id": 877715654, "node_id": "MDEyOklzc3VlQ29tbWVudDg3NzcxNTY1NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-10T23:15:06Z", "updated_at": "2021-07-10T23:15:06Z", "author_association": "OWNER", "body": "I can run tests against it using `httpx`: https://www.python-httpx.org/advanced/#usage_1\r\n\r\n> ```pycon\r\n> >>> import httpx\r\n> >>> # Connect to the Docker API via a Unix Socket.\r\n> >>> transport = httpx.HTTPTransport(uds=\"/var/run/docker.sock\")\r\n> >>> client = httpx.Client(transport=transport)\r\n> >>> response = client.get(\"http://docker/info\")\r\n> ```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 939051549, "label": "Serve using UNIX domain socket"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1388#issuecomment-877716156", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1388", "id": 877716156, "node_id": "MDEyOklzc3VlQ29tbWVudDg3NzcxNjE1Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-10T23:22:21Z", "updated_at": "2021-07-10T23:22:21Z", "author_association": "OWNER", "body": "I don't have the Datasette test suite running on Windows yet, but I'd like it to run there some day - so ideally this test would be skipped if Unix domain sockets are not supported by the underlying operating system.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 939051549, "label": "Serve using UNIX domain socket"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1388#issuecomment-877716359", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1388", "id": 877716359, "node_id": "MDEyOklzc3VlQ29tbWVudDg3NzcxNjM1OQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-10T23:24:58Z", "updated_at": "2021-07-10T23:24:58Z", "author_association": "OWNER", "body": "Apparently Windows 10 has Unix domain socket support: https://bugs.python.org/issue33408\r\n\r\n> Unix socket (AF_UNIX) is now avalible in Windows 10 (April 2018 Update). Please add Python support for it.\r\n> More details about it on https://blogs.msdn.microsoft.com/commandline/2017/12/19/af_unix-comes-to-windows/\r\n\r\nBut it's not clear if this is going to work. That same issue thread (the issue is still open) suggests using `hasattr(socket, 'AF_UNIX'))` to detect support in tests.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 939051549, "label": "Serve using UNIX domain socket"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1388#issuecomment-877716993", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1388", "id": 877716993, "node_id": "MDEyOklzc3VlQ29tbWVudDg3NzcxNjk5Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-10T23:34:02Z", "updated_at": "2021-07-10T23:34:02Z", "author_association": "OWNER", "body": "Figured out an example nginx configuration. This in `nginx.conf`:\r\n\r\n    daemon off;\r\n    events {\r\n      worker_connections  1024;\r\n    }\r\n    http {\r\n      server {\r\n        listen 8092;\r\n        location / {\r\n          proxy_pass              http://datasette;\r\n          proxy_set_header        X-Real-IP $remote_addr;\r\n          proxy_set_header        X-Forwarded-For $proxy_add_x_forwarded_for;\r\n        }\r\n      }\r\n      upstream datasette {\r\n        server unix:/tmp/datasette.sock;\r\n      }\r\n    }\r\n\r\nThen run `datasette --uds /tmp/datasette.sock`\r\n\r\nThen run nginx like this:\r\n\r\n    nginx -c ./nginx.conf\r\n\r\nThen hits to `http://localhost:8092/` will be proxied to Datasette.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 939051549, "label": "Serve using UNIX domain socket"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1388#issuecomment-877717262", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1388", "id": 877717262, "node_id": "MDEyOklzc3VlQ29tbWVudDg3NzcxNzI2Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-10T23:37:54Z", "updated_at": "2021-07-10T23:37:54Z", "author_association": "OWNER", "body": "> I wonder if `--fd` is worth supporting too?\r\n\r\nI'm going to hold off on implementing this until someone asks for it.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 939051549, "label": "Serve using UNIX domain socket"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1389#issuecomment-877681031", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1389", "id": 877681031, "node_id": "MDEyOklzc3VlQ29tbWVudDg3NzY4MTAzMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-10T18:17:29Z", "updated_at": "2021-07-10T18:17:29Z", "author_association": "OWNER", "body": "I don't like `?_searchmode=default` because it suggests \"use the default\" - but it actually over-rides the default that was specified by `\"searchmode\": \"raw\"` in `metadata.json`.\r\n\r\nI'm going with `?_searchmode=escaped` instead.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 940077168, "label": "\"searchmode\": \"raw\" in table metadata"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1391#issuecomment-877682533", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1391", "id": 877682533, "node_id": "MDEyOklzc3VlQ29tbWVudDg3NzY4MjUzMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-10T18:28:05Z", "updated_at": "2021-07-10T18:28:05Z", "author_association": "OWNER", "body": "Here's the test in question: https://github.com/simonw/datasette/blob/a6c55afe8c82ead8deb32f90c9324022fd422324/tests/test_api.py#L2033-L2046\r\n\r\nVarious other places in the test code also need changing - anything that calls `supports_generated_columns()`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 941300946, "label": "Stop using generated columns in fixtures.db"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1391#issuecomment-877686784", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1391", "id": 877686784, "node_id": "MDEyOklzc3VlQ29tbWVudDg3NzY4Njc4NA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-10T18:56:03Z", "updated_at": "2021-07-10T18:56:03Z", "author_association": "OWNER", "body": "Here's the SQL used to generate the table for the test: https://github.com/simonw/datasette/blob/02b19c7a9afd328f22040ab33b5c1911cd904c7c/tests/fixtures.py#L723-L733", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 941300946, "label": "Stop using generated columns in fixtures.db"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1391#issuecomment-877687196", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1391", "id": 877687196, "node_id": "MDEyOklzc3VlQ29tbWVudDg3NzY4NzE5Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-10T18:58:40Z", "updated_at": "2021-07-10T18:58:40Z", "author_association": "OWNER", "body": "I can use the `extra_databases` mechanism as demonstrated here: https://github.com/simonw/datasette/blob/9552414e1f968c6fc704031cec349c05e6bc2371/tests/test_canned_queries.py#L8-L12", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 941300946, "label": "Stop using generated columns in fixtures.db"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1391#issuecomment-877691427", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1391", "id": 877691427, "node_id": "MDEyOklzc3VlQ29tbWVudDg3NzY5MTQyNw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-10T19:26:00Z", "updated_at": "2021-07-10T19:26:00Z", "author_association": "OWNER", "body": "I had to run the tests locally on my macOS laptop using `pysqlite3` to get a version that supported generated columns - wrote up a TIL about that here: https://til.simonwillison.net/sqlite/pysqlite3-on-macos", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 941300946, "label": "Stop using generated columns in fixtures.db"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1391#issuecomment-877691558", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1391", "id": 877691558, "node_id": "MDEyOklzc3VlQ29tbWVudDg3NzY5MTU1OA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-10T19:26:57Z", "updated_at": "2021-07-10T19:26:57Z", "author_association": "OWNER", "body": "The `https://latest.datasette.io/fixtures.db` file no longer includes generated columns, which will help avoid confusion such as seen in #1376.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 941300946, "label": "Stop using generated columns in fixtures.db"}, "performed_via_github_app": null}