{"html_url": "https://github.com/simonw/datasette/issues/2005#issuecomment-1404458011", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2005", "id": 1404458011, "node_id": "IC_kwDOBm6k_c5TtlQb", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-01-26T01:41:30Z", "updated_at": "2023-01-26T01:41:50Z", "author_association": "OWNER", "body": "My code looked like this:\r\n```python\r\n@hookimpl\r\ndef extra_template_vars(datasette, view_name, database):\r\n    async def inner():\r\n        if view_name == \"database\":\r\n            return {\"blah\": 1}\r\n\r\n    return inner\r\n```\r\nIt returns `None` in the case where the `if` condition does not match.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1557507274, "label": "`extra_template_vars` should be OK to return `None`"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/2006#issuecomment-1405488523", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2006", "id": 1405488523, "node_id": "IC_kwDOBm6k_c5Txg2L", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-01-26T19:20:32Z", "updated_at": "2023-01-26T19:20:32Z", "author_association": "OWNER", "body": "This won't actually help that much if the user's GitHub Actions workflow does the equivalent of this:\r\n```\r\npip install datasette\r\ndatasette publish cloudrun mydb.db ...\r\n```\r\nSince they'll get the 1.0 release too.\r\n\r\nSince they'll need to make changes anyway, maybe a better solution is to document this and tell people they should use this instead:\r\n\r\n```\r\ndatasette publish cloudrun mydb.db ... --branch 0.64.1\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1558644003, "label": "Teach `datasette publish` to pin to `datasette<1.0` in a 0.x release"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/2006#issuecomment-1405488884", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/2006", "id": 1405488884, "node_id": "IC_kwDOBm6k_c5Txg70", "user": {"value": 9599, "label": "simonw"}, "created_at": "2023-01-26T19:20:53Z", "updated_at": "2023-01-26T19:20:53Z", "author_association": "OWNER", "body": "I can run a GitHub code search a week or so before the release to give me time to get in touch with anyone who has actions that look like they might break.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1558644003, "label": "Teach `datasette publish` to pin to `datasette<1.0` in a 0.x release"}, "performed_via_github_app": null}