{"html_url": "https://github.com/simonw/datasette/issues/538#issuecomment-508225524", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/538", "id": 508225524, "node_id": "MDEyOklzc3VlQ29tbWVudDUwODIyNTUyNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-03T19:26:32Z", "updated_at": "2019-07-03T19:26:32Z", "author_association": "OWNER", "body": "Another useful option is the ability to load secrets from a file. This allows the file to have permissions set on it to only be read by the Datasette user. It also interacts well with the Kubernetes secrets mechanism, which is file-based.\r\n```json\r\n{\r\n    \"plugins\": {\r\n        \"datasette-auth-github\": {\r\n            \"client_id\": \"986f5d837b45e32ee6dd\",\r\n            \"client_secret\": {\"$file\": \"/secrets/github-client-secret\"}\r\n        }\r\n    }\r\n}", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 463915863, "label": "Mechanism for secrets in plugin configuration"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/538#issuecomment-508224962", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/538", "id": 508224962, "node_id": "MDEyOklzc3VlQ29tbWVudDUwODIyNDk2Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-03T19:24:32Z", "updated_at": "2019-07-03T19:24:32Z", "author_association": "OWNER", "body": "Initial syntax suggestion:\r\n```json\r\n{\r\n    \"title\": \"datasette-auth-github demo\",\r\n    \"plugins\": {\r\n        \"datasette-auth-github\": {\r\n            \"client_id\": \"986f5d837b45e32ee6dd\",\r\n            \"client_secret\": {\"$env\": \"GITHUB_CLIENT_SECRET\"}\r\n        }\r\n    }\r\n}\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 463915863, "label": "Mechanism for secrets in plugin configuration"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/520#issuecomment-507935352", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/520", "id": 507935352, "node_id": "MDEyOklzc3VlQ29tbWVudDUwNzkzNTM1Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-03T04:40:34Z", "updated_at": "2019-07-03T04:40:34Z", "author_association": "OWNER", "body": "Documentation for the new hook: https://datasette.readthedocs.io/en/latest/plugins.html#asgi-wrapper-datasette", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 459598080, "label": "asgi_wrapper plugin hook"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/215#issuecomment-507929913", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/215", "id": 507929913, "node_id": "MDEyOklzc3VlQ29tbWVudDUwNzkyOTkxMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-03T04:08:28Z", "updated_at": "2019-07-03T04:08:28Z", "author_association": "OWNER", "body": "I just closed #520 which means this is now technically possible.\r\n\r\nBut... doing it using the new `asgi_wrapper` hook https://datasette.readthedocs.io/en/latest/plugins.html#asgi-wrapper-datasette isn't particularly obvious.\r\n\r\nI'm going to leave this ticket open for the moment. I think I need at least one example plugin to show that this approach is good enough - and it's still quite possible that I'll add an extra, easier hook for this. ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 314506669, "label": "Allow plugins to define additional URL routes and views"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/521#issuecomment-507922465", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/521", "id": 507922465, "node_id": "MDEyOklzc3VlQ29tbWVudDUwNzkyMjQ2NQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-03T03:23:55Z", "updated_at": "2019-07-03T03:23:55Z", "author_association": "OWNER", "body": "Fixed by #533", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 459621683, "label": "Easier way of creating custom row templates"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/533#issuecomment-507895104", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/533", "id": 507895104, "node_id": "MDEyOklzc3VlQ29tbWVudDUwNzg5NTEwNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-07-03T00:46:20Z", "updated_at": "2019-07-03T00:46:33Z", "author_association": "OWNER", "body": "I'd like to rename `_rows_and_columns.html` to `_table.html`.\r\n\r\nThere is at least one project out there using the current filename though: https://github.com/baltimore-sun-data/salaries-datasette/blob/master/templates/_rows_and_columns.html - I shall file an issue there to let them know about the backwards incompatible change.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 463492395, "label": "Support cleaner custom templates for rows and tables, closes #521"}, "performed_via_github_app": null}