{"html_url": "https://github.com/simonw/datasette/issues/1327#issuecomment-847271122", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1327", "id": 847271122, "node_id": "MDEyOklzc3VlQ29tbWVudDg0NzI3MTEyMg==", "user": {"value": 20846286, "label": "GmGniap"}, "created_at": "2021-05-24T19:10:21Z", "updated_at": "2021-05-24T19:10:21Z", "author_association": "NONE", "body": "wow, thanks a lot @simonw , problem is solved. I converted my current json file into utf-8 format with Python script. It's working now. I'm using with Window 10. ", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 892457208, "label": "Support Unicode characters in metadata.json"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1327#issuecomment-847240470", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1327", "id": 847240470, "node_id": "MDEyOklzc3VlQ29tbWVudDg0NzI0MDQ3MA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-05-24T18:21:44Z", "updated_at": "2021-05-24T18:21:44Z", "author_association": "OWNER", "body": "I'm having trouble replicating this - I tried the following `metadata.json` in my local environment and it displayed correctly:\r\n```json\r\n{\r\n    \"title\": \"\u1019\u103c\u1014\u103a\u1019\u102c\u1005\u102c (\"\r\n}\r\n```\r\nWhat operating system are you using here? Is there a chance that your `metadata.json` file is saved in a text encoding other than utf-8?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 892457208, "label": "Support Unicode characters in metadata.json"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1320#issuecomment-847237524", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1320", "id": 847237524, "node_id": "MDEyOklzc3VlQ29tbWVudDg0NzIzNzUyNA==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-05-24T18:15:56Z", "updated_at": "2021-05-24T18:15:56Z", "author_association": "OWNER", "body": "Added some new documentation about that here: https://github.com/simonw/datasette/blob/c0a748e5c3f498fa8c139b420d07dd3dea612379/docs/installation.rst#installing-plugins", "reactions": "{\"total_count\": 1, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 1, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 884952179, "label": "Can't use apt-get in Dockerfile when using datasetteproj/datasette as base"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1320#issuecomment-847232547", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1320", "id": 847232547, "node_id": "MDEyOklzc3VlQ29tbWVudDg0NzIzMjU0Nw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-05-24T18:06:32Z", "updated_at": "2021-05-24T18:06:32Z", "author_association": "OWNER", "body": "I'm testing tweaks to the Dockerfile by editing it and running:\r\n```\r\ndocker build . -t datasette-057a0 --build-arg VERSION=0.57a0\r\n```\r\nThen running this to inspect the new image:\r\n```\r\ndocker run -it -p 8001:8001 datasette-057a0 bash\r\n```\r\nAfter changing that line to `rm -rf /var/lib/dpkg/info/*` I can run `apt-get` successfully from inside that bash prompt:\r\n```\r\n# apt-get update\r\n# apt-get install ripgrep\r\n# rg --version\r\nripgrep 12.1.1\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 884952179, "label": "Can't use apt-get in Dockerfile when using datasetteproj/datasette as base"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1320#issuecomment-847230866", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1320", "id": 847230866, "node_id": "MDEyOklzc3VlQ29tbWVudDg0NzIzMDg2Ng==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-05-24T18:03:29Z", "updated_at": "2021-05-24T18:03:29Z", "author_association": "OWNER", "body": "```\r\nroot@33c269900821:/# du -h /var/lib/dpkg\r\n6.3M\t/var/lib/dpkg/info\r\n24K\t/var/lib/dpkg/triggers\r\n4.0K\t/var/lib/dpkg/updates\r\n20K\t/var/lib/dpkg/alternatives\r\n4.0K\t/var/lib/dpkg/parts\r\n6.7M\t/var/lib/dpkg\r\n```\r\nSo `/var/lib/dpkg/info` is most of the space, I'll try just deleting that.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 884952179, "label": "Can't use apt-get in Dockerfile when using datasetteproj/datasette as base"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1320#issuecomment-847223853", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1320", "id": 847223853, "node_id": "MDEyOklzc3VlQ29tbWVudDg0NzIyMzg1Mw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-05-24T17:51:12Z", "updated_at": "2021-05-24T17:51:12Z", "author_association": "OWNER", "body": "This is a good catch, thank you.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 884952179, "label": "Can't use apt-get in Dockerfile when using datasetteproj/datasette as base"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/1339#issuecomment-847207804", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1339", "id": 847207804, "node_id": "MDEyOklzc3VlQ29tbWVudDg0NzIwNzgwNA==", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2021-05-24T17:22:13Z", "updated_at": "2021-05-27T04:14:21Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1339?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\n> Merging [#1339](https://codecov.io/gh/simonw/datasette/pull/1339?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (3d8598b) into [main](https://codecov.io/gh/simonw/datasette/commit/a443dba82f43c22b03402a4f86c85558ccb526b8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (a443dba) will **increase** coverage by `0.01%`.\n> The diff coverage is `91.66%`.\n\n> :exclamation: Current head 3d8598b differs from pull request most recent head 387c837. Consider uploading reports for the commit 387c837 to get more accurate results\n[![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1339/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n\n```diff\n@@            Coverage Diff             @@\n##             main    #1339      +/-   ##\n==========================================\n+ Coverage   91.55%   91.56%   +0.01%     \n==========================================\n  Files          34       34              \n  Lines        4262     4280      +18     \n==========================================\n+ Hits         3902     3919      +17     \n- Misses        360      361       +1     \n```\n\n\n| [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1339?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage \u0394 | |\n|---|---|---|\n| [datasette/views/table.py](https://codecov.io/gh/simonw/datasette/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL3RhYmxlLnB5) | `95.83% <90.00%> (-0.05%)` | :arrow_down: |\n| [datasette/app.py](https://codecov.io/gh/simonw/datasette/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2FwcC5weQ==) | `95.84% <100.00%> (-0.01%)` | :arrow_down: |\n| [datasette/views/database.py](https://codecov.io/gh/simonw/datasette/pull/1339/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL2RhdGFiYXNlLnB5) | `97.19% <100.00%> (\u00f8)` | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1339?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n> `\u0394 = absolute <relative> (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1339?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [a443dba...387c837](https://codecov.io/gh/simonw/datasette/pull/1339?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 899851083, "label": "?_col=/?_nocol= to show/hide columns on the table page"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/615#issuecomment-846668419", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/615", "id": 846668419, "node_id": "MDEyOklzc3VlQ29tbWVudDg0NjY2ODQxOQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-05-24T01:14:27Z", "updated_at": "2021-05-24T01:14:27Z", "author_association": "OWNER", "body": "I tried allowing the removal of `rowid` and got this exception:\r\n```\r\n  File \"/Users/simon/Dropbox/Development/datasette/datasette/views/table.py\", line 831, in extra_template\r\n    display_columns, display_rows = await self.display_columns_and_rows(\r\n  File \"/Users/simon/Dropbox/Development/datasette/datasette/views/table.py\", line 163, in display_columns_and_rows\r\n    pk_path = path_from_row_pks(row, pks, not pks, False)\r\n  File \"/Users/simon/Dropbox/Development/datasette/datasette/utils/__init__.py\", line 82, in path_from_row_pks\r\n    bits = [row[\"rowid\"]]\r\nIndexError: No item with that key\r\n```\r\nI'm going to disable the removal of `rowid` - or indeed any of the primary keys, since they are needed to construct the row permalink.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 517451234, "label": "?_col= and ?_nocol= support for toggling columns on table view"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/615#issuecomment-846660103", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/615", "id": 846660103, "node_id": "MDEyOklzc3VlQ29tbWVudDg0NjY2MDEwMw==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-05-24T00:47:00Z", "updated_at": "2021-05-24T00:47:00Z", "author_association": "OWNER", "body": "> Here's a bug: removing the `rowid` column returns an error.\r\n\r\nRemoving the `rowid` column should work. We can continue to show the `Link` column, ensuring users can still navigate to the row page for each row.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 517451234, "label": "?_col= and ?_nocol= support for toggling columns on table view"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/615#issuecomment-846659272", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/615", "id": 846659272, "node_id": "MDEyOklzc3VlQ29tbWVudDg0NjY1OTI3Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-05-24T00:44:47Z", "updated_at": "2021-05-24T00:44:47Z", "author_association": "OWNER", "body": "I can't think of any good reasons to support passing the same column twice `?col=airline&_col=airline` so I'm going to de-duplicate and silently ignore the second one.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 517451234, "label": "?_col= and ?_nocol= support for toggling columns on table view"}, "performed_via_github_app": null}