{"html_url": "https://github.com/simonw/datasette/issues/1605#issuecomment-1016977725", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1605", "id": 1016977725, "node_id": "IC_kwDOBm6k_c48ndk9", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-19T23:55:08Z", "updated_at": "2022-01-19T23:55:08Z", "author_association": "OWNER", "body": "Oh that's interesting. I was thinking about this from a slightly different angle recently - pondering what a static site generator built on top of Datasette might look like.\r\n\r\nJust a sketch at the moment, but I was imagining a YAML configuration file with a SQL query that returns a list of paths - then a tool that runs that query and uses the equivalent of `datasette --get` to create a static copy of each of those paths.\r\n\r\nI think these two ideas can probably be merged. I'd love to know more about how you are solving this right now!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1108671952, "label": "Scripted exports"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1601#issuecomment-1016651485", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1601", "id": 1016651485, "node_id": "IC_kwDOBm6k_c48mN7d", "user": {"value": 25778, "label": "eyeseast"}, "created_at": "2022-01-19T16:39:03Z", "updated_at": "2022-01-19T16:39:03Z", "author_association": "CONTRIBUTOR", "body": "I think both of these are Spatialite specific. They get generated when you first initialize the extension. KNN is actually deprecated in favor of [KNN2](https://www.gaia-gis.it/fossil/libspatialite/wiki?name=KNN2), as I understand it.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1105916061, "label": "Add KNN and data_licenses to hidden tables list"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1601#issuecomment-1016639294", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1601", "id": 1016639294, "node_id": "IC_kwDOBm6k_c48mK8-", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-19T16:26:44Z", "updated_at": "2022-01-20T03:57:17Z", "author_association": "OWNER", "body": "I need to add `sqlite_stat1` to the hidden tables too, see:\r\n- https://github.com/simonw/datasette/issues/1587\r\n- https://github.com/simonw/sqlite-utils/issues/366", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1105916061, "label": "Add KNN and data_licenses to hidden tables list"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1601#issuecomment-1016637722", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1601", "id": 1016637722, "node_id": "IC_kwDOBm6k_c48mKka", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-19T16:25:07Z", "updated_at": "2022-01-19T16:25:07Z", "author_association": "OWNER", "body": "Good idea - though I'm nervous about accidentally hiding a `data_licenses` table outside of the SpatiaLite case. I'll only hide that one if SpatiaLite is loaded.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1105916061, "label": "Add KNN and data_licenses to hidden tables list"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1604#issuecomment-1016636561", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1604", "id": 1016636561, "node_id": "IC_kwDOBm6k_c48mKSR", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-19T16:23:54Z", "updated_at": "2022-01-19T16:23:54Z", "author_association": "OWNER", "body": "Potential design:\r\n\r\n datasette publish cloudrun data.db \\\r\n --service my-service \\\r\n --domain demo.datasette.io\r\n\r\nI think I'm OK with calling this `--domain` even when it is being used with a subdomain.\r\n\r\nThis will require `datasette.io` to already have been verified with Google.\r\n\r\nNot sure how best to handle the DNS part - maybe print out instructions for the necessary CNAME?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1108300685, "label": "Option to assign a domain/subdomain using `datasette publish cloudrun`"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1603#issuecomment-1016589519", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1603", "id": 1016589519, "node_id": "IC_kwDOBm6k_c48l-zP", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-19T15:36:38Z", "updated_at": "2022-01-19T15:36:38Z", "author_association": "OWNER", "body": "Also people can use a custom base template and link to a custom favicon if they want to.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1108235694, "label": "A proper favicon"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1603#issuecomment-1016589140", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1603", "id": 1016589140, "node_id": "IC_kwDOBm6k_c48l-tU", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-19T15:36:16Z", "updated_at": "2022-01-19T15:36:16Z", "author_association": "OWNER", "body": "For the moment then I will hard-code a new favicon and leave it to ASGI plugins if people want to define their own.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1108235694, "label": "A proper favicon"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1603#issuecomment-1016588326", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1603", "id": 1016588326, "node_id": "IC_kwDOBm6k_c48l-gm", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-19T15:35:33Z", "updated_at": "2022-01-19T15:35:33Z", "author_association": "OWNER", "body": "I don't think abusing the template loader mechanism for this will work: Jinja provides an API for loading text templates, but I don't think it can be sensibly abused to open binary image files instead. Loaded code is here: https://github.com/pallets/jinja/blob/main/src/jinja2/loaders.py", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1108235694, "label": "A proper favicon"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1603#issuecomment-1016579661", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1603", "id": 1016579661, "node_id": "IC_kwDOBm6k_c48l8ZN", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-01-19T15:27:05Z", "updated_at": "2022-01-19T15:27:05Z", "author_association": "OWNER", "body": "I'd like this to be customizable. I'm going to load it from the template loading system such that a custom favicon for a specific instance can be dropped in using a file in `templates/`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1108235694, "label": "A proper favicon"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1602#issuecomment-1016456784", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1602", "id": 1016456784, "node_id": "IC_kwDOBm6k_c48leZQ", "user": {"value": 22429695, "label": "codecov[bot]"}, "created_at": "2022-01-19T13:17:24Z", "updated_at": "2022-03-06T01:30:46Z", "author_association": "NONE", "body": "# [Codecov](https://codecov.io/gh/simonw/datasette/pull/1602?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) Report\n> Merging [#1602](https://codecov.io/gh/simonw/datasette/pull/1602?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (9eb0bdf) into [main](https://codecov.io/gh/simonw/datasette/commit/5010d1359b9e9db90a5a69a3ca22d12862893e00?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) (5010d13) will **increase** coverage by `0.13%`.\n> The diff coverage is `n/a`.\n\n> :exclamation: Current head 9eb0bdf differs from pull request most recent head a9c69dc. Consider uploading reports for the commit a9c69dc to get more accurate results\n\n[![Impacted file tree graph](https://codecov.io/gh/simonw/datasette/pull/1602/graphs/tree.svg?width=650&height=150&src=pr&token=eSahVY7kw1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)](https://codecov.io/gh/simonw/datasette/pull/1602?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n\n```diff\n@@ Coverage Diff @@\n## main #1602 +/- ##\n==========================================\n+ Coverage 92.03% 92.16% +0.13% \n==========================================\n Files 34 34 \n Lines 4557 4531 -26 \n==========================================\n- Hits 4194 4176 -18 \n+ Misses 363 355 -8 \n```\n\n\n| [Impacted Files](https://codecov.io/gh/simonw/datasette/pull/1602?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage \u0394 | |\n|---|---|---|\n| [datasette/tracer.py](https://codecov.io/gh/simonw/datasette/pull/1602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3RyYWNlci5weQ==) | `82.95% <0.00%> (-1.09%)` | :arrow_down: |\n| [datasette/cli.py](https://codecov.io/gh/simonw/datasette/pull/1602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2NsaS5weQ==) | `77.85% <0.00%> (-0.09%)` | :arrow_down: |\n| [datasette/utils/\\_\\_init\\_\\_.py](https://codecov.io/gh/simonw/datasette/pull/1602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3V0aWxzL19faW5pdF9fLnB5) | `94.79% <0.00%> (-0.07%)` | :arrow_down: |\n| [datasette/\\_\\_init\\_\\_.py](https://codecov.io/gh/simonw/datasette/pull/1602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL19faW5pdF9fLnB5) | `100.00% <0.00%> (\u00f8)` | |\n| [datasette/app.py](https://codecov.io/gh/simonw/datasette/pull/1602/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2FwcC5weQ==) | `95.37% <0.00%> (+1.05%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/simonw/datasette/pull/1602?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)\n> `\u0394 = absolute (impact)`, `\u00f8 = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/simonw/datasette/pull/1602?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Last update [73f2d25...a9c69dc](https://codecov.io/gh/simonw/datasette/pull/1602?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison).\n", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1108084641, "label": "Update pytest-timeout requirement from <2.1,>=1.4.2 to >=1.4.2,<2.2"}, "performed_via_github_app": null}