{"html_url": "https://github.com/simonw/datasette/issues/1780#issuecomment-1215992640", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1780", "id": 1215992640, "node_id": "IC_kwDOBm6k_c5IepNA", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-08-15T23:50:02Z", "updated_at": "2022-08-15T23:50:02Z", "author_association": "OWNER", "body": "This is deliberate, but maybe it's a bad design decision?\r\n\r\nRight now Datasette assumes you made a mistake if you set `facet_time_limit_ms` higher than `sql_time_limit_ms` and ignores you.\r\n\r\nMaybe it would be better if it refused to start the server at all and showed you an error message?\r\n\r\n```\r\n% datasette . --setting facet_time_limit_ms 30000\r\nError: facet_time_limit_ms greater than sql_time_limit_ms. Try this instead:\r\n\r\n datasette . --setting facet_time_limit_ms 30000 --setting sql_time_limit_ms 30000\r\n```\r\n\r\nOr perhaps running this should set both of the time limits to 30s:\r\n\r\n datasette . --setting facet_time_limit_ms 30000\r\n\r\nI'm nervous about doing that though as it feels like it may surprise people who only wanted to increase one of the limits.\r\n\r\nOption 3: make it so it's possible for facets to have a greater time limit than SQL queries generally.\r\n\r\nMaybe that's the best option? It's not surprising to people, and I think it's reasonable to implement.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1337541526, "label": "`facet_time_limit_ms` and `sql_time_limit_ms` overlap?"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1783#issuecomment-1215742398", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1783", "id": 1215742398, "node_id": "IC_kwDOBm6k_c5IdsG-", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-08-15T20:13:29Z", "updated_at": "2022-08-15T20:13:29Z", "author_association": "OWNER", "body": "This tutorial is relevant: https://datasette.io/tutorials/clean-data - maybe for the moment I can link to that from the documentation in more places?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1339444565, "label": "Better guidance as to what to do after you've installed Datasette"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/issues/1783#issuecomment-1215741101", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1783", "id": 1215741101, "node_id": "IC_kwDOBm6k_c5Idryt", "user": {"value": 9599, "label": "simonw"}, "created_at": "2022-08-15T20:12:04Z", "updated_at": "2022-08-15T20:12:26Z", "author_association": "OWNER", "body": "This will get a whole lot easier if I implement the ideas in here:\r\n\r\n- #1163\r\n\r\nI won't need to talk people through installing `sqlite-utils` too in that case.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1339444565, "label": "Better guidance as to what to do after you've installed Datasette"}, "performed_via_github_app": null} {"html_url": "https://github.com/simonw/datasette/pull/1574#issuecomment-1214765672", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1574", "id": 1214765672, "node_id": "IC_kwDOBm6k_c5IZ9po", "user": {"value": 33631, "label": "fs111"}, "created_at": "2022-08-15T08:49:31Z", "updated_at": "2022-08-15T08:49:31Z", "author_association": "NONE", "body": "closing as this is now the default", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 1084193403, "label": "introduce new option for datasette package to use a slim base image"}, "performed_via_github_app": null}