{"html_url": "https://github.com/simonw/datasette/pull/441#issuecomment-488373631", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/441", "id": 488373631, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4ODM3MzYzMQ==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-01T18:43:17Z", "updated_at": "2019-05-01T18:43:17Z", "author_association": "OWNER", "body": "I plan to merge this in about 7 hours time (after work).\r\n\r\nI may tweak the plugin format a little bit before the next Datasette release though (best to merge first, make changes later I think) - for consistency with some other upcoming hooks (the facet hook in particular). I'll discuss that with you while I'm working on it.\r\n\r\nThanks so much for this, it's a really neat addition!", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 438437973, "label": "Add register_output_renderer hook"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/438#issuecomment-488370672", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/438", "id": 488370672, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4ODM3MDY3Mg==", "user": {"value": 9599, "label": "simonw"}, "created_at": "2019-05-01T18:33:57Z", "updated_at": "2019-05-01T18:33:57Z", "author_association": "OWNER", "body": "Yeah this is a good call. Having pytest set some kind of flag (maybe an environment variable?) that disables auto-plugin discovery is a very reasonable fix here.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 438200529, "label": "Plugins are loaded when running pytest"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/pull/441#issuecomment-488247617", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/441", "id": 488247617, "node_id": "MDEyOklzc3VlQ29tbWVudDQ4ODI0NzYxNw==", "user": {"value": 45057, "label": "russss"}, "created_at": "2019-05-01T09:57:50Z", "updated_at": "2019-05-01T09:57:50Z", "author_association": "CONTRIBUTOR", "body": "Just for the record, this PR is now finished and ready to merge from my perspective.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 438437973, "label": "Add register_output_renderer hook"}, "performed_via_github_app": null}