{"html_url": "https://github.com/simonw/datasette/issues/1241#issuecomment-889539227", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1241", "id": 889539227, "node_id": "IC_kwDOBm6k_c41BUqb", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-30T00:15:26Z", "updated_at": "2021-07-30T00:15:26Z", "author_association": "OWNER", "body": "One possible treatment:\r\n\r\n<img width=\"442\" alt=\"fixtures__sortable__201_rows\" src=\"https://user-images.githubusercontent.com/9599/127581105-dca1193c-1bdd-491e-89d1-ac3136c05c3b.png\">\r\n\r\n```html\r\n<style>\r\na.action-button {\r\n    display: inline-block;\r\n    border: 1.5px solid #666;\r\n    border-radius: 0.5em;\r\n    background-color: #ffffff;\r\n    color: #666;\r\n    padding: 0.1em 0.8em;\r\n    text-decoration: none;\r\n    margin-right: 0.3em;\r\n    font-size: 0.85em;\r\n}\r\n</style>\r\n<p>\r\n    {% if query.sql and allow_execute_sql %}\r\n        <a class=\"action-button\"\r\n            title=\"{{ query.sql }}\"\r\n            href=\"{{ urls.database(database) }}?{{ {'sql': query.sql}|urlencode|safe }}{% if query.params %}&amp;{{ query.params|urlencode|safe }}{% endif %}\">\r\n            View and edit SQL\r\n        </a>\r\n    {% endif %}\r\n    <a href=\"#\" class=\"action-button\">Copy and share link</a>\r\n</p>\r\n```", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 814595021, "label": "Share button for copying current URL"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1406#issuecomment-889547142", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1406", "id": 889547142, "node_id": "IC_kwDOBm6k_c41BWmG", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-30T00:39:49Z", "updated_at": "2021-07-30T00:39:49Z", "author_association": "OWNER", "body": "It happens in CI but not on my laptop. I think I need to run the tests on my laptop like this: https://github.com/simonw/datasette/blob/121e10c29c5b412fddf0326939f1fe46c3ad9d4a/.github/workflows/test.yml#L27-L30", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 956303470, "label": "Tests failing with FileNotFoundError in runner.isolated_filesystem"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1406#issuecomment-889548536", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1406", "id": 889548536, "node_id": "IC_kwDOBm6k_c41BW74", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-30T00:43:47Z", "updated_at": "2021-07-30T00:43:47Z", "author_association": "OWNER", "body": "Still couldn't replicate on my laptop. On a hunch, I'm going to add `@pytest.mark.serial` to every test that uses `runner.isolated_filesystem()`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 956303470, "label": "Tests failing with FileNotFoundError in runner.isolated_filesystem"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1406#issuecomment-889550391", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1406", "id": 889550391, "node_id": "IC_kwDOBm6k_c41BXY3", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-30T00:49:31Z", "updated_at": "2021-07-30T00:49:31Z", "author_association": "OWNER", "body": "That fixed it. My hunch is that Click's `runner.isolated_filesystem()` mechanism doesn't play well with `pytest-xdist`.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 956303470, "label": "Tests failing with FileNotFoundError in runner.isolated_filesystem"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1406#issuecomment-889553052", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1406", "id": 889553052, "node_id": "IC_kwDOBm6k_c41BYCc", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-30T00:58:43Z", "updated_at": "2021-07-30T00:58:43Z", "author_association": "OWNER", "body": "Tests are still failing in the job that calculates coverage.", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 956303470, "label": "Tests failing with FileNotFoundError in runner.isolated_filesystem"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1406#issuecomment-889555977", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1406", "id": 889555977, "node_id": "IC_kwDOBm6k_c41BYwJ", "user": {"value": 9599, "label": "simonw"}, "created_at": "2021-07-30T01:06:57Z", "updated_at": "2021-07-30T01:06:57Z", "author_association": "OWNER", "body": "Looking at the source code in Click for `isolated_filesystem()`: https://github.com/pallets/click/blob/9da166957f5848b641231d485467f6140bca2bc0/src/click/testing.py#L450-L468\r\n\r\n```python\r\n    @contextlib.contextmanager\r\n    def isolated_filesystem(\r\n        self, temp_dir: t.Optional[t.Union[str, os.PathLike]] = None\r\n    ) -> t.Iterator[str]:\r\n        \"\"\"A context manager that creates a temporary directory and\r\n        changes the current working directory to it. This isolates tests\r\n        that affect the contents of the CWD to prevent them from\r\n        interfering with each other.\r\n        :param temp_dir: Create the temporary directory under this\r\n            directory. If given, the created directory is not removed\r\n            when exiting.\r\n        .. versionchanged:: 8.0\r\n            Added the ``temp_dir`` parameter.\r\n        \"\"\"\r\n        cwd = os.getcwd()\r\n        t = tempfile.mkdtemp(dir=temp_dir)\r\n        os.chdir(t)\r\n```\r\nHow about if I pass in that optional `temp_dir` as a temp directory created using the `pytest-xdist` aware pytest mechanisms: https://docs.pytest.org/en/6.2.x/tmpdir.html", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 956303470, "label": "Tests failing with FileNotFoundError in runner.isolated_filesystem"}, "performed_via_github_app": null}
{"html_url": "https://github.com/simonw/datasette/issues/1398#issuecomment-889599513", "issue_url": "https://api.github.com/repos/simonw/datasette/issues/1398", "id": 889599513, "node_id": "IC_kwDOBm6k_c41BjYZ", "user": {"value": 192984, "label": "aitoehigie"}, "created_at": "2021-07-30T03:21:49Z", "updated_at": "2021-07-30T03:21:49Z", "author_association": "NONE", "body": "Does the library support this now?", "reactions": "{\"total_count\": 0, \"+1\": 0, \"-1\": 0, \"laugh\": 0, \"hooray\": 0, \"confused\": 0, \"heart\": 0, \"rocket\": 0, \"eyes\": 0}", "issue": {"value": 947044667, "label": "Documentation on using Datasette as a library"}, "performed_via_github_app": null}